All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthias Kaehlcke <mka@chromium.org>
To: satya priya <skakit@codeaurora.org>
Cc: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	rnayak@codeaurora.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	kgunda@codeaurora.org
Subject: Re: [PATCH V3 3/5] arm64: dts: qcom: sc7280: Add RPMh regulators for sc7280-idp
Date: Wed, 31 Mar 2021 11:30:48 -0700	[thread overview]
Message-ID: <YGS/2FSP8cq2ZiEU@google.com> (raw)
In-Reply-To: <1617192339-3760-4-git-send-email-skakit@codeaurora.org>

On Wed, Mar 31, 2021 at 05:35:37PM +0530, satya priya wrote:
> Add regulator devices for SC7280 as RPMh regulators. This ensures
> that consumers are able to modify the physical state of PMIC
> regulators.
> 
> Signed-off-by: satya priya <skakit@codeaurora.org>

Reviewed-by: Matthias Kaehlcke <mka@chromium.org>

I did not verify the voltage ranges. The datasheet specifies some
ranges, but apparently the settings in the AOP are what really
matters [1].

[1] https://patchwork.kernel.org/project/linux-arm-msm/patch/1615816454-1733-4-git-send-email-skakit@codeaurora.org/#24051523

  reply	other threads:[~2021-03-31 18:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-31 12:05 [PATCH V3 0/5] Add PM7325/PM8350C/PMR735A regulator support satya priya
2021-03-31 12:05 ` [PATCH V3 1/5] regulator: qcom-rpmh: Add pmic5_ftsmps520 buck satya priya
2021-03-31 12:05 ` [PATCH V3 2/5] regulator: qcom-rpmh: Add PM7325/PMR735A regulator support satya priya
2021-03-31 18:10   ` Matthias Kaehlcke
2021-03-31 12:05 ` [PATCH V3 3/5] arm64: dts: qcom: sc7280: Add RPMh regulators for sc7280-idp satya priya
2021-03-31 18:30   ` Matthias Kaehlcke [this message]
2021-03-31 12:05 ` [PATCH V3 4/5] dt-bindings: regulator: Convert RPMh regulator bindings to YAML satya priya
2021-03-31 12:18   ` Mark Brown
2021-04-01 16:56   ` Rob Herring
2021-03-31 12:05 ` [PATCH V3 5/5] dt-bindings: regulator: Add compatibles for PM7325/PMR735A satya priya
2021-04-01 20:43 ` [PATCH V3 0/5] Add PM7325/PM8350C/PMR735A regulator support Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YGS/2FSP8cq2ZiEU@google.com \
    --to=mka@chromium.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kgunda@codeaurora.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rnayak@codeaurora.org \
    --cc=robh+dt@kernel.org \
    --cc=skakit@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.