From: Michal Hocko <mhocko@suse.com> To: Johannes Weiner <hannes@cmpxchg.org> Cc: Waiman Long <llong@redhat.com>, Vladimir Davydov <vdavydov.dev@gmail.com>, Andrew Morton <akpm@linux-foundation.org>, Tejun Heo <tj@kernel.org>, Christoph Lameter <cl@linux.com>, Pekka Enberg <penberg@kernel.org>, David Rientjes <rientjes@google.com>, Joonsoo Kim <iamjoonsoo.kim@lge.com>, Vlastimil Babka <vbabka@suse.cz>, Roman Gushchin <guro@fb.com>, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Shakeel Butt <shakeelb@google.com>, Muchun Song <songmuchun@bytedance.com>, Alex Shi <alex.shi@linux.alibaba.com>, Chris Down <chris@chrisdown.name>, Yafang Shao <laoar.shao@gmail.com>, Wei Yang <richard.weiyang@gmail.com>, Masayoshi Mizuma <msys.mizuma@gmail.com>, Xing Zhengjun <zhengjun.xing@linux.intel.com>, Matthew Wilcox <willy@infradead.org> Subject: Re: [PATCH v4 1/5] mm/memcg: Move mod_objcg_state() to memcontrol.c Date: Tue, 20 Apr 2021 10:05:55 +0200 [thread overview] Message-ID: <YH6LY/N/fqqnv2QT@dhcp22.suse.cz> (raw) In-Reply-To: <YH3yCZn9EeSPKKGY@cmpxchg.org> On Mon 19-04-21 17:11:37, Johannes Weiner wrote: > On Mon, Apr 19, 2021 at 01:26:29PM -0400, Waiman Long wrote: [...] > - the soft limit tree and soft limit reclaim > > - the threshold and oom event notification stuff > > - the charge moving code > > - remaining v1 interface files, as well as their helper functions > > From a quick scan, this adds up to ~2,500 lines of old code with no > actual dependencies from the common code or from v2, and which could > be moved out of the way without disrupting ongoing development much. Moving those into its own file makes sense to me as well. If the code is not conditional (e.g. like swap accounting and some others) then moving it would make memecontrol.c easier to navigate through. -- Michal Hocko SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko-IBi9RG/b67k@public.gmane.org> To: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org> Cc: Waiman Long <llong-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>, Vladimir Davydov <vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>, Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Christoph Lameter <cl-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org>, Pekka Enberg <penberg-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, David Rientjes <rientjes-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>, Joonsoo Kim <iamjoonsoo.kim-Hm3cg6mZ9cc@public.gmane.org>, Vlastimil Babka <vbabka-AlSwsSmVLrQ@public.gmane.org>, Roman Gushchin <guro-b10kYP2dOMg@public.gmane.org>, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, Shakeel Butt <shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>, Muchun Song <songmuchun-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org>, Alex Shi <alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>, Chris Down <chris-6Bi1550iOqEnzZ6mRAm98g@public.gmane.org>, Yafang Shao <laoar.shao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Wei Yang <richard.weiyang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Masayoshi Mizuma <msys.mizuma-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Xing Zhengjun <zhengjun.xing-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>, Matthew Wilcox <wi> Subject: Re: [PATCH v4 1/5] mm/memcg: Move mod_objcg_state() to memcontrol.c Date: Tue, 20 Apr 2021 10:05:55 +0200 [thread overview] Message-ID: <YH6LY/N/fqqnv2QT@dhcp22.suse.cz> (raw) In-Reply-To: <YH3yCZn9EeSPKKGY-druUgvl0LCNAfugRpC6u6w@public.gmane.org> On Mon 19-04-21 17:11:37, Johannes Weiner wrote: > On Mon, Apr 19, 2021 at 01:26:29PM -0400, Waiman Long wrote: [...] > - the soft limit tree and soft limit reclaim > > - the threshold and oom event notification stuff > > - the charge moving code > > - remaining v1 interface files, as well as their helper functions > > From a quick scan, this adds up to ~2,500 lines of old code with no > actual dependencies from the common code or from v2, and which could > be moved out of the way without disrupting ongoing development much. Moving those into its own file makes sense to me as well. If the code is not conditional (e.g. like swap accounting and some others) then moving it would make memecontrol.c easier to navigate through. -- Michal Hocko SUSE Labs
next prev parent reply other threads:[~2021-04-20 8:06 UTC|newest] Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-19 0:00 [PATCH v4 0/5] mm/memcg: Reduce kmemcache memory accounting overhead Waiman Long 2021-04-19 0:00 ` Waiman Long 2021-04-19 0:00 ` [PATCH v4 1/5] mm/memcg: Move mod_objcg_state() to memcontrol.c Waiman Long 2021-04-19 0:00 ` Waiman Long 2021-04-19 15:14 ` Johannes Weiner 2021-04-19 15:14 ` Johannes Weiner 2021-04-19 15:21 ` Waiman Long 2021-04-19 15:21 ` Waiman Long 2021-04-19 16:18 ` Waiman Long 2021-04-19 16:18 ` Waiman Long 2021-04-19 17:13 ` Johannes Weiner 2021-04-19 17:13 ` Johannes Weiner 2021-04-19 17:19 ` Waiman Long 2021-04-19 17:19 ` Waiman Long 2021-04-19 17:26 ` Waiman Long 2021-04-19 17:26 ` Waiman Long 2021-04-19 21:11 ` Johannes Weiner 2021-04-19 21:11 ` Johannes Weiner 2021-04-19 21:24 ` Waiman Long 2021-04-19 21:24 ` Waiman Long 2021-04-20 8:05 ` Michal Hocko [this message] 2021-04-20 8:05 ` Michal Hocko 2021-04-19 15:24 ` Shakeel Butt 2021-04-19 15:24 ` Shakeel Butt 2021-04-19 15:24 ` Shakeel Butt 2021-04-19 0:00 ` [PATCH v4 2/5] mm/memcg: Cache vmstat data in percpu memcg_stock_pcp Waiman Long 2021-04-19 16:38 ` Johannes Weiner 2021-04-19 16:38 ` Johannes Weiner 2021-04-19 23:42 ` Waiman Long 2021-04-19 23:42 ` Waiman Long 2021-04-19 0:00 ` [PATCH v4 3/5] mm/memcg: Optimize user context object stock access Waiman Long 2021-04-19 0:00 ` [PATCH v4 4/5] mm/memcg: Save both reclaimable & unreclaimable bytes in object stock Waiman Long 2021-04-19 0:00 ` Waiman Long 2021-04-19 16:55 ` Johannes Weiner 2021-04-19 16:55 ` Johannes Weiner 2021-04-20 19:09 ` Waiman Long 2021-04-20 19:09 ` Waiman Long 2021-04-19 0:00 ` [PATCH v4 5/5] mm/memcg: Improve refill_obj_stock() performance Waiman Long 2021-04-19 0:00 ` Waiman Long 2021-04-19 6:06 ` [External] " Muchun Song 2021-04-19 6:06 ` Muchun Song 2021-04-19 6:06 ` Muchun Song 2021-04-19 15:00 ` Shakeel Butt 2021-04-19 15:00 ` Shakeel Butt 2021-04-19 15:00 ` Shakeel Butt 2021-04-19 15:19 ` Waiman Long 2021-04-19 15:19 ` Waiman Long 2021-04-19 15:56 ` Waiman Long 2021-04-19 15:56 ` Waiman Long
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YH6LY/N/fqqnv2QT@dhcp22.suse.cz \ --to=mhocko@suse.com \ --cc=akpm@linux-foundation.org \ --cc=alex.shi@linux.alibaba.com \ --cc=cgroups@vger.kernel.org \ --cc=chris@chrisdown.name \ --cc=cl@linux.com \ --cc=guro@fb.com \ --cc=hannes@cmpxchg.org \ --cc=iamjoonsoo.kim@lge.com \ --cc=laoar.shao@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=llong@redhat.com \ --cc=msys.mizuma@gmail.com \ --cc=penberg@kernel.org \ --cc=richard.weiyang@gmail.com \ --cc=rientjes@google.com \ --cc=shakeelb@google.com \ --cc=songmuchun@bytedance.com \ --cc=tj@kernel.org \ --cc=vbabka@suse.cz \ --cc=vdavydov.dev@gmail.com \ --cc=willy@infradead.org \ --cc=zhengjun.xing@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.