From: Andrew Lunn <andrew@lunn.ch>
To: Tobias Waldekranz <tobias@waldekranz.com>
Cc: Vladimir Oltean <olteanv@gmail.com>,
davem@davemloft.net, kuba@kernel.org, vivien.didelot@gmail.com,
f.fainelli@gmail.com, roopa@nvidia.com, nikolay@nvidia.com,
jiri@resnulli.us, idosch@idosch.org, stephen@networkplumber.org,
netdev@vger.kernel.org, bridge@lists.linux-foundation.org
Subject: Re: [RFC net-next 6/9] net: dsa: Forward offloading
Date: Tue, 4 May 2021 22:33:20 +0200 [thread overview]
Message-ID: <YJGvkJBKPj2WloXf@lunn.ch> (raw)
In-Reply-To: <874kfintzh.fsf@waldekranz.com>
> There is really no need to recompute the static parts of the tags on
> each skb. It would mean moving some knowledge of the tagging format to
> the driver. But that boundary is pretty artificial for
> mv88e6xxx. tag_dsa has no use outside of mv88e6xxx, and mv88e6xxx does
> not work with any other tagger. I suppose you could even move the whole
> tagger to drivers/net/dsa/mv88e6xxx/?
>
> What do you think?
>
> Andrew?
We have resisted this before.
What information do you actually need to share between the tagger and
the driver? Both tag_lan9303.c and tag_ocelot_8021q.c do reference
their switch driver data structures, so some sharing is allowed. But
please try to keep the surface areas down.
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Tobias Waldekranz <tobias@waldekranz.com>
Cc: f.fainelli@gmail.com, jiri@resnulli.us, netdev@vger.kernel.org,
bridge@lists.linux-foundation.org, vivien.didelot@gmail.com,
idosch@idosch.org, nikolay@nvidia.com, roopa@nvidia.com,
kuba@kernel.org, Vladimir Oltean <olteanv@gmail.com>,
davem@davemloft.net
Subject: Re: [Bridge] [RFC net-next 6/9] net: dsa: Forward offloading
Date: Tue, 4 May 2021 22:33:20 +0200 [thread overview]
Message-ID: <YJGvkJBKPj2WloXf@lunn.ch> (raw)
In-Reply-To: <874kfintzh.fsf@waldekranz.com>
> There is really no need to recompute the static parts of the tags on
> each skb. It would mean moving some knowledge of the tagging format to
> the driver. But that boundary is pretty artificial for
> mv88e6xxx. tag_dsa has no use outside of mv88e6xxx, and mv88e6xxx does
> not work with any other tagger. I suppose you could even move the whole
> tagger to drivers/net/dsa/mv88e6xxx/?
>
> What do you think?
>
> Andrew?
We have resisted this before.
What information do you actually need to share between the tagger and
the driver? Both tag_lan9303.c and tag_ocelot_8021q.c do reference
their switch driver data structures, so some sharing is allowed. But
please try to keep the surface areas down.
Andrew
next prev parent reply other threads:[~2021-05-04 20:33 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-26 17:04 [RFC net-next 0/9] net: bridge: Forward offloading Tobias Waldekranz
2021-04-26 17:04 ` [Bridge] " Tobias Waldekranz
2021-04-26 17:04 ` [RFC net-next 1/9] net: dfwd: Constrain existing users to macvlan subordinates Tobias Waldekranz
2021-04-26 17:04 ` [Bridge] " Tobias Waldekranz
2021-04-26 17:04 ` [RFC net-next 2/9] net: bridge: Disambiguate offload_fwd_mark Tobias Waldekranz
2021-04-26 17:04 ` [Bridge] " Tobias Waldekranz
2021-05-02 15:00 ` Ido Schimmel
2021-05-02 15:00 ` [Bridge] " Ido Schimmel
2021-05-03 8:49 ` Tobias Waldekranz
2021-05-03 8:49 ` [Bridge] " Tobias Waldekranz
2021-05-05 7:39 ` Ido Schimmel
2021-05-05 7:39 ` [Bridge] " Ido Schimmel
2021-04-26 17:04 ` [RFC net-next 3/9] net: bridge: switchdev: Recycle unused hwdoms Tobias Waldekranz
2021-04-26 17:04 ` [Bridge] " Tobias Waldekranz
2021-04-27 10:42 ` Nikolay Aleksandrov
2021-04-27 10:42 ` [Bridge] " Nikolay Aleksandrov
2021-04-26 17:04 ` [RFC net-next 4/9] net: bridge: switchdev: Forward offloading Tobias Waldekranz
2021-04-26 17:04 ` [Bridge] " Tobias Waldekranz
2021-04-27 10:35 ` Nikolay Aleksandrov
2021-04-27 10:35 ` [Bridge] " Nikolay Aleksandrov
2021-04-28 22:47 ` Tobias Waldekranz
2021-04-28 22:47 ` [Bridge] " Tobias Waldekranz
2021-04-29 9:16 ` Nikolay Aleksandrov
2021-04-29 9:16 ` [Bridge] " Nikolay Aleksandrov
2021-04-29 14:55 ` Tobias Waldekranz
2021-04-29 14:55 ` [Bridge] " Tobias Waldekranz
2021-05-02 15:04 ` Ido Schimmel
2021-05-02 15:04 ` [Bridge] " Ido Schimmel
2021-05-03 8:53 ` Tobias Waldekranz
2021-05-03 8:53 ` [Bridge] " Tobias Waldekranz
2021-05-06 11:01 ` Vladimir Oltean
2021-05-06 11:01 ` [Bridge] " Vladimir Oltean
2021-04-26 17:04 ` [RFC net-next 5/9] net: dsa: Track port PVIDs Tobias Waldekranz
2021-04-26 17:04 ` [Bridge] " Tobias Waldekranz
2021-04-26 19:40 ` Vladimir Oltean
2021-04-26 19:40 ` [Bridge] " Vladimir Oltean
2021-04-26 20:05 ` Tobias Waldekranz
2021-04-26 20:05 ` [Bridge] " Tobias Waldekranz
2021-04-26 20:28 ` Vladimir Oltean
2021-04-26 20:28 ` [Bridge] " Vladimir Oltean
2021-04-27 9:12 ` Tobias Waldekranz
2021-04-27 9:12 ` [Bridge] " Tobias Waldekranz
2021-04-27 9:27 ` Vladimir Oltean
2021-04-27 9:27 ` [Bridge] " Vladimir Oltean
2021-04-27 10:07 ` Vladimir Oltean
2021-04-27 10:07 ` [Bridge] " Vladimir Oltean
2021-04-28 23:10 ` Tobias Waldekranz
2021-04-28 23:10 ` [Bridge] " Tobias Waldekranz
2021-04-26 17:04 ` [RFC net-next 6/9] net: dsa: Forward offloading Tobias Waldekranz
2021-04-26 17:04 ` [Bridge] " Tobias Waldekranz
2021-04-27 10:17 ` Vladimir Oltean
2021-04-27 10:17 ` [Bridge] " Vladimir Oltean
2021-05-04 14:44 ` Tobias Waldekranz
2021-05-04 14:44 ` [Bridge] " Tobias Waldekranz
2021-05-04 15:21 ` Vladimir Oltean
2021-05-04 15:21 ` [Bridge] " Vladimir Oltean
2021-05-04 20:07 ` Tobias Waldekranz
2021-05-04 20:07 ` [Bridge] " Tobias Waldekranz
2021-05-04 20:33 ` Andrew Lunn [this message]
2021-05-04 20:33 ` Andrew Lunn
2021-05-04 21:24 ` Tobias Waldekranz
2021-05-04 21:24 ` [Bridge] " Tobias Waldekranz
2021-05-04 20:58 ` Vladimir Oltean
2021-05-04 20:58 ` [Bridge] " Vladimir Oltean
2021-05-04 22:12 ` Tobias Waldekranz
2021-05-04 22:12 ` [Bridge] " Tobias Waldekranz
2021-05-04 23:04 ` Vladimir Oltean
2021-05-04 23:04 ` [Bridge] " Vladimir Oltean
2021-05-05 9:01 ` Tobias Waldekranz
2021-05-05 9:01 ` [Bridge] " Tobias Waldekranz
2021-05-05 16:12 ` Vladimir Oltean
2021-05-05 16:12 ` [Bridge] " Vladimir Oltean
2021-04-26 17:04 ` [RFC net-next 7/9] net: dsa: mv88e6xxx: Allocate a virtual DSA port for each bridge Tobias Waldekranz
2021-04-26 17:04 ` [Bridge] " Tobias Waldekranz
2021-04-26 17:04 ` [RFC net-next 8/9] net: dsa: mv88e6xxx: Map virtual bridge port in PVT Tobias Waldekranz
2021-04-26 17:04 ` [Bridge] " Tobias Waldekranz
2021-04-26 17:04 ` [RFC net-next 9/9] net: dsa: mv88e6xxx: Forward offloading Tobias Waldekranz
2021-04-26 17:04 ` [Bridge] " Tobias Waldekranz
2021-04-27 1:31 ` kernel test robot
2021-05-02 14:58 ` [RFC net-next 0/9] net: bridge: " Ido Schimmel
2021-05-02 14:58 ` [Bridge] " Ido Schimmel
2021-05-03 9:44 ` Tobias Waldekranz
2021-05-03 9:44 ` [Bridge] " Tobias Waldekranz
2021-05-06 10:59 ` Vladimir Oltean
2021-05-06 10:59 ` [Bridge] " Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJGvkJBKPj2WloXf@lunn.ch \
--to=andrew@lunn.ch \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=idosch@idosch.org \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@nvidia.com \
--cc=olteanv@gmail.com \
--cc=roopa@nvidia.com \
--cc=stephen@networkplumber.org \
--cc=tobias@waldekranz.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.