From: David Gibson <david@gibson.dropbear.id.au> To: "Philippe Mathieu-Daudé" <philmd@redhat.com> Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, qemu-ppc@nongnu.org, qemu-arm@nongnu.org, "Gerd Hoffmann" <kraxel@redhat.com>, "Paolo Bonzini" <pbonzini@redhat.com>, "Alex Bennée" <alex.bennee@linaro.org>, "Greg Kurz" <groug@kaod.org> Subject: Re: [PATCH v2 9/9] target/ppc/kvm: Replace alloca() by g_malloc() Date: Fri, 7 May 2021 11:05:35 +1000 [thread overview] Message-ID: <YJSSX1eUIecBpwwX@yekko> (raw) In-Reply-To: <20210506133758.1749233-10-philmd@redhat.com> [-- Attachment #1: Type: text/plain, Size: 1369 bytes --] On Thu, May 06, 2021 at 03:37:58PM +0200, Philippe Mathieu-Daudé wrote: > The ALLOCA(3) man-page mentions its "use is discouraged". > > Replace it by a g_malloc() call. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > target/ppc/kvm.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c > index 104a308abb5..63c458e2211 100644 > --- a/target/ppc/kvm.c > +++ b/target/ppc/kvm.c > @@ -2698,11 +2698,10 @@ int kvmppc_save_htab(QEMUFile *f, int fd, size_t bufsize, int64_t max_ns) > int kvmppc_load_htab_chunk(QEMUFile *f, int fd, uint32_t index, > uint16_t n_valid, uint16_t n_invalid, Error **errp) > { > - struct kvm_get_htab_header *buf; > size_t chunksize = sizeof(*buf) + n_valid * HASH_PTE_SIZE_64; > + g_autofree struct kvm_get_htab_header *buf = g_malloc(chunksize); Um.. that doesn't look like it would compile, since you use sizeof(*buf) before declaring buf. > ssize_t rc; > > - buf = alloca(chunksize); > buf->index = index; > buf->n_valid = n_valid; > buf->n_invalid = n_invalid; -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: David Gibson <david@gibson.dropbear.id.au> To: "Philippe Mathieu-Daudé" <philmd@redhat.com> Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org, "Greg Kurz" <groug@kaod.org>, qemu-arm@nongnu.org, qemu-ppc@nongnu.org, "Gerd Hoffmann" <kraxel@redhat.com>, "Paolo Bonzini" <pbonzini@redhat.com>, "Alex Bennée" <alex.bennee@linaro.org> Subject: Re: [PATCH v2 9/9] target/ppc/kvm: Replace alloca() by g_malloc() Date: Fri, 7 May 2021 11:05:35 +1000 [thread overview] Message-ID: <YJSSX1eUIecBpwwX@yekko> (raw) In-Reply-To: <20210506133758.1749233-10-philmd@redhat.com> [-- Attachment #1: Type: text/plain, Size: 1369 bytes --] On Thu, May 06, 2021 at 03:37:58PM +0200, Philippe Mathieu-Daudé wrote: > The ALLOCA(3) man-page mentions its "use is discouraged". > > Replace it by a g_malloc() call. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > target/ppc/kvm.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c > index 104a308abb5..63c458e2211 100644 > --- a/target/ppc/kvm.c > +++ b/target/ppc/kvm.c > @@ -2698,11 +2698,10 @@ int kvmppc_save_htab(QEMUFile *f, int fd, size_t bufsize, int64_t max_ns) > int kvmppc_load_htab_chunk(QEMUFile *f, int fd, uint32_t index, > uint16_t n_valid, uint16_t n_invalid, Error **errp) > { > - struct kvm_get_htab_header *buf; > size_t chunksize = sizeof(*buf) + n_valid * HASH_PTE_SIZE_64; > + g_autofree struct kvm_get_htab_header *buf = g_malloc(chunksize); Um.. that doesn't look like it would compile, since you use sizeof(*buf) before declaring buf. > ssize_t rc; > > - buf = alloca(chunksize); > buf->index = index; > buf->n_valid = n_valid; > buf->n_invalid = n_invalid; -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-05-07 3:00 UTC|newest] Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-06 13:37 [PATCH v2 0/9] misc: Replace alloca() by g_malloc() Philippe Mathieu-Daudé 2021-05-06 13:37 ` Philippe Mathieu-Daudé 2021-05-06 13:37 ` [PATCH v2 1/9] audio/alsaaudio: Replace ALSA alloca() by malloc() equivalent Philippe Mathieu-Daudé 2021-05-06 13:37 ` Philippe Mathieu-Daudé 2021-05-06 13:37 ` [PATCH v2 2/9] backends/tpm: Replace qemu_mutex_lock calls with QEMU_LOCK_GUARD Philippe Mathieu-Daudé 2021-05-06 13:37 ` Philippe Mathieu-Daudé 2021-05-06 14:46 ` Stefan Berger 2021-05-06 15:07 ` Christophe de Dinechin 2021-05-06 15:07 ` Christophe de Dinechin 2021-05-06 13:37 ` [PATCH v2 3/9] backends/tpm: Replace g_alloca() by g_malloc() Philippe Mathieu-Daudé 2021-05-06 13:37 ` Philippe Mathieu-Daudé 2021-05-06 14:46 ` Stefan Berger 2021-05-06 14:46 ` Stefan Berger 2021-05-06 13:37 ` [PATCH v2 4/9] bsd-user/syscall: Replace alloca() by g_new() Philippe Mathieu-Daudé 2021-05-06 13:37 ` Philippe Mathieu-Daudé 2021-05-06 14:16 ` Warner Losh 2021-05-06 14:20 ` Peter Maydell 2021-05-06 14:20 ` Peter Maydell 2021-05-06 14:48 ` Warner Losh 2021-05-06 14:57 ` Philippe Mathieu-Daudé 2021-05-06 15:07 ` Warner Losh 2021-05-06 14:25 ` Eric Blake 2021-05-06 14:55 ` Warner Losh 2021-05-06 15:12 ` Eric Blake 2021-05-06 15:12 ` Eric Blake 2021-05-06 15:30 ` Warner Losh 2021-05-06 15:42 ` Eric Blake 2021-05-06 15:42 ` Eric Blake 2021-05-06 16:03 ` Peter Maydell 2021-05-06 16:03 ` Peter Maydell 2021-05-06 16:09 ` Warner Losh 2021-05-06 15:58 ` Peter Maydell 2021-05-06 15:58 ` Peter Maydell 2021-05-06 16:08 ` Warner Losh 2021-05-06 13:37 ` [PATCH v2 5/9] gdbstub: Constify GdbCmdParseEntry Philippe Mathieu-Daudé 2021-05-06 13:37 ` Philippe Mathieu-Daudé 2021-05-06 13:37 ` [PATCH v2 6/9] gdbstub: Only call cmd_parse_params() with non-NULL command schema Philippe Mathieu-Daudé 2021-05-06 13:37 ` Philippe Mathieu-Daudé 2021-05-06 19:21 ` Alex Bennée 2021-05-06 19:21 ` Alex Bennée 2021-05-06 13:37 ` [PATCH v2 7/9] gdbstub: Replace alloca() + memset(0) by g_new0() Philippe Mathieu-Daudé 2021-05-06 13:37 ` Philippe Mathieu-Daudé 2021-05-06 19:22 ` Alex Bennée 2021-05-06 19:22 ` Alex Bennée 2021-05-06 13:37 ` [PATCH v2 8/9] hw/misc/pca9552: Replace g_newa() by g_new() Philippe Mathieu-Daudé 2021-05-06 13:37 ` Philippe Mathieu-Daudé 2021-05-06 13:37 ` [PATCH v2 9/9] target/ppc/kvm: Replace alloca() by g_malloc() Philippe Mathieu-Daudé 2021-05-06 13:37 ` Philippe Mathieu-Daudé 2021-05-06 14:45 ` Greg Kurz 2021-05-06 14:45 ` Greg Kurz 2021-05-07 1:05 ` David Gibson [this message] 2021-05-07 1:05 ` David Gibson 2021-05-06 14:22 ` [PATCH v2 0/9] misc: " Warner Losh 2021-05-06 14:28 ` Eric Blake 2021-05-06 15:02 ` Warner Losh
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YJSSX1eUIecBpwwX@yekko \ --to=david@gibson.dropbear.id.au \ --cc=alex.bennee@linaro.org \ --cc=groug@kaod.org \ --cc=kraxel@redhat.com \ --cc=kvm@vger.kernel.org \ --cc=pbonzini@redhat.com \ --cc=philmd@redhat.com \ --cc=qemu-arm@nongnu.org \ --cc=qemu-devel@nongnu.org \ --cc=qemu-ppc@nongnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.