All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Tomasz Figa <tfiga@chromium.org>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	DRI Development <dri-devel@lists.freedesktop.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Linux-MM <linux-mm@kvack.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Linux Media Mailing List <linux-media@vger.kernel.org>,
	linux-samsung-soc <linux-samsung-soc@vger.kernel.org>
Subject: Re: [PULL] topic/iomem-mmap-vs-gup
Date: Mon, 10 May 2021 08:29:32 +0100	[thread overview]
Message-ID: <YJjg3DRnG1RG6VDK@infradead.org> (raw)
In-Reply-To: <CAKMK7uELBbkhFBQoSfvMx+AKnbk-fgbamBm3sC20-dJwMq3Xmg@mail.gmail.com>

On Mon, May 10, 2021 at 09:16:58AM +0200, Daniel Vetter wrote:
> > End result: not pulling it, unless somebody can explain to me in small
> > words why I'm wrong and have the mental capacity of a damaged rodent.
> 
> No rodents I think, just more backstory of how this all fits. tldr;
> pin_user_pages is the only safe use of this vb2 userptr thing.

Yes, which is why I advocate for just ripping the follow_pfn path
out entirely.  It could have been used for crazy ad dangerous peer to
peer transfers outside of any infrastructure making it safe, or for
pre-CMA kernel memory carveouts for lage contiguous memory allocations
(which are pretty broken by design as well).  So IMHO the only sensible
thing is to remove this cruft entirely, and if it breaks a currently
working setup (which I think is unlikely) we'll have to make sure it
can work the proper way.

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Tomasz Figa <tfiga@chromium.org>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	DRI Development <dri-devel@lists.freedesktop.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Linux-MM <linux-mm@kvack.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Linux Media Mailing List <linux-media@vger.kernel.org>,
	linux-samsung-soc <linux-samsung-soc@vger.kernel.org>
Subject: Re: [PULL] topic/iomem-mmap-vs-gup
Date: Mon, 10 May 2021 08:29:32 +0100	[thread overview]
Message-ID: <YJjg3DRnG1RG6VDK@infradead.org> (raw)
In-Reply-To: <CAKMK7uELBbkhFBQoSfvMx+AKnbk-fgbamBm3sC20-dJwMq3Xmg@mail.gmail.com>

On Mon, May 10, 2021 at 09:16:58AM +0200, Daniel Vetter wrote:
> > End result: not pulling it, unless somebody can explain to me in small
> > words why I'm wrong and have the mental capacity of a damaged rodent.
> 
> No rodents I think, just more backstory of how this all fits. tldr;
> pin_user_pages is the only safe use of this vb2 userptr thing.

Yes, which is why I advocate for just ripping the follow_pfn path
out entirely.  It could have been used for crazy ad dangerous peer to
peer transfers outside of any infrastructure making it safe, or for
pre-CMA kernel memory carveouts for lage contiguous memory allocations
(which are pretty broken by design as well).  So IMHO the only sensible
thing is to remove this cruft entirely, and if it breaks a currently
working setup (which I think is unlikely) we'll have to make sure it
can work the proper way.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-05-10  7:31 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-03 19:15 [PULL] topic/iomem-mmap-vs-gup Daniel Vetter
2021-05-03 19:15 ` Daniel Vetter
2021-05-03 19:15 ` Daniel Vetter
2021-05-06 22:30 ` Linus Torvalds
2021-05-06 22:30   ` Linus Torvalds
2021-05-06 22:30   ` Linus Torvalds
2021-05-06 22:30   ` Linus Torvalds
2021-05-07 15:53   ` Daniel Vetter
2021-05-07 15:53     ` Daniel Vetter
2021-05-07 15:53     ` Daniel Vetter
2021-05-08 16:46     ` Linus Torvalds
2021-05-08 16:46       ` Linus Torvalds
2021-05-08 16:46       ` Linus Torvalds
2021-05-08 16:46       ` Linus Torvalds
2021-05-10  7:16       ` Daniel Vetter
2021-05-10  7:16         ` Daniel Vetter
2021-05-10  7:16         ` Daniel Vetter
2021-05-10  7:16         ` Daniel Vetter
2021-05-10  7:29         ` Christoph Hellwig [this message]
2021-05-10  7:29           ` Christoph Hellwig
2021-05-17 15:29           ` Daniel Vetter
2021-05-17 15:29             ` Daniel Vetter
2021-05-17 15:29             ` Daniel Vetter
2021-05-17 15:29             ` Daniel Vetter
2021-05-17 22:04             ` Stephen Rothwell
2021-05-17 22:04               ` Stephen Rothwell
2021-05-17 22:04               ` Stephen Rothwell
2021-05-10 13:50       ` Jason Gunthorpe
2021-05-10 13:50         ` Jason Gunthorpe
2021-05-10 13:50         ` Jason Gunthorpe
2021-05-10 14:55         ` Daniel Vetter
2021-05-10 14:55           ` Daniel Vetter
2021-05-10 14:55           ` Daniel Vetter
2021-05-10 14:55           ` Daniel Vetter
2021-05-10 15:34           ` Jason Gunthorpe
2021-05-10 15:34             ` Jason Gunthorpe
2021-05-10 15:34             ` Jason Gunthorpe
2021-05-10 17:57             ` Sean Christopherson
2021-05-10 17:57               ` Sean Christopherson
2021-05-10 17:57               ` Sean Christopherson
2021-05-10 18:13               ` Paolo Bonzini
2021-05-10 18:13                 ` Paolo Bonzini
2021-05-10 18:13                 ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YJjg3DRnG1RG6VDK@infradead.org \
    --to=hch@infradead.org \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=mchehab@kernel.org \
    --cc=tfiga@chromium.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.