From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Ard Biesheuvel <ardb@kernel.org>,
"# 3.4.x" <stable@vger.kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Russell King <linux@armlinux.org.uk>,
Nicolas Pitre <nico@fluxnic.net>,
Linus Walleij <linus.walleij@linaro.org>,
Mike Rapoport <rppt@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Nick Desaulniers <ndesaulniers@gooogle.com>,
Joe Perches <joe@perches.com>, Max Filippov <jcmvbkbc@gmail.com>,
Tian Tao <tiantao6@hisilicon.com>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
"moderated list:ARM PORT" <linux-arm-kernel@lists.infradead.org>,
Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH stable 5.10 0/3] ARM FDT relocation backports
Date: Mon, 10 May 2021 09:43:52 +0200 [thread overview]
Message-ID: <YJjkOLg/Ivo2kMOS@kroah.com> (raw)
In-Reply-To: <5f8fed97-8c73-73b0-6576-bf3fbcdb1440@gmail.com>
On Sun, May 09, 2021 at 06:22:05PM -0700, Florian Fainelli wrote:
>
>
> On 5/9/2021 12:17 PM, Ard Biesheuvel wrote:
> > On Sun, 9 May 2021 at 19:30, Florian Fainelli <f.fainelli@gmail.com> wrote:
> >>
> >> Hi Greg, Sasha,
> >>
> >> These patches were not marked with a Fixes: tag but they do fix booting
> >> ARM 32-bit platforms that have specific FDT placement and would cause
> >> boot failures like these:
> >>
> >
> > I don't have any objections to backporting these changes, but it would
> > be helpful if you could explain why this is a regression. Also, you'll
> > need to pull in the following patch as well
>
> This does not qualify as a regression in that it has never worked for
> the specific platform that I have shown above until your 3 commits came
> in and fixed that particular FDT placement. To me this qualifies as a
> bug fix, and given that the 3 (now 4) commits applied without hunks, it
> seems reasonable to me to back port those to stable.
As this isn't a regression, why not just use 5.12 on these platforms?
Why is 5.4 and 5.10 needed?
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Ard Biesheuvel <ardb@kernel.org>,
"# 3.4.x" <stable@vger.kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Russell King <linux@armlinux.org.uk>,
Nicolas Pitre <nico@fluxnic.net>,
Linus Walleij <linus.walleij@linaro.org>,
Mike Rapoport <rppt@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Nick Desaulniers <ndesaulniers@gooogle.com>,
Joe Perches <joe@perches.com>, Max Filippov <jcmvbkbc@gmail.com>,
Tian Tao <tiantao6@hisilicon.com>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
"moderated list:ARM PORT" <linux-arm-kernel@lists.infradead.org>,
Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH stable 5.10 0/3] ARM FDT relocation backports
Date: Mon, 10 May 2021 09:43:52 +0200 [thread overview]
Message-ID: <YJjkOLg/Ivo2kMOS@kroah.com> (raw)
In-Reply-To: <5f8fed97-8c73-73b0-6576-bf3fbcdb1440@gmail.com>
On Sun, May 09, 2021 at 06:22:05PM -0700, Florian Fainelli wrote:
>
>
> On 5/9/2021 12:17 PM, Ard Biesheuvel wrote:
> > On Sun, 9 May 2021 at 19:30, Florian Fainelli <f.fainelli@gmail.com> wrote:
> >>
> >> Hi Greg, Sasha,
> >>
> >> These patches were not marked with a Fixes: tag but they do fix booting
> >> ARM 32-bit platforms that have specific FDT placement and would cause
> >> boot failures like these:
> >>
> >
> > I don't have any objections to backporting these changes, but it would
> > be helpful if you could explain why this is a regression. Also, you'll
> > need to pull in the following patch as well
>
> This does not qualify as a regression in that it has never worked for
> the specific platform that I have shown above until your 3 commits came
> in and fixed that particular FDT placement. To me this qualifies as a
> bug fix, and given that the 3 (now 4) commits applied without hunks, it
> seems reasonable to me to back port those to stable.
As this isn't a regression, why not just use 5.12 on these platforms?
Why is 5.4 and 5.10 needed?
thanks,
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-10 7:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-09 17:30 [PATCH stable 5.10 0/3] ARM FDT relocation backports Florian Fainelli
2021-05-09 17:30 ` Florian Fainelli
2021-05-09 17:30 ` [PATCH stable 5.10 1/3] ARM: 9011/1: centralize phys-to-virt conversion of DT/ATAGS address Florian Fainelli
2021-05-09 17:30 ` Florian Fainelli
2021-05-09 17:30 ` [PATCH stable 5.10 2/3] ARM: 9012/1: move device tree mapping out of linear region Florian Fainelli
2021-05-09 17:30 ` Florian Fainelli
2021-05-09 17:30 ` [PATCH stable 5.10 3/3] ARM: 9020/1: mm: use correct section size macro to describe the FDT virtual address Florian Fainelli
2021-05-09 17:30 ` Florian Fainelli
2021-05-09 19:17 ` [PATCH stable 5.10 0/3] ARM FDT relocation backports Ard Biesheuvel
2021-05-09 19:17 ` Ard Biesheuvel
2021-05-10 1:22 ` Florian Fainelli
2021-05-10 1:22 ` Florian Fainelli
2021-05-10 7:43 ` Greg Kroah-Hartman [this message]
2021-05-10 7:43 ` Greg Kroah-Hartman
2021-05-10 9:37 ` Linus Walleij
2021-05-10 9:37 ` Linus Walleij
2021-05-10 9:46 ` Greg Kroah-Hartman
2021-05-10 9:46 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJjkOLg/Ivo2kMOS@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=ardb@kernel.org \
--cc=corbet@lwn.net \
--cc=f.fainelli@gmail.com \
--cc=jcmvbkbc@gmail.com \
--cc=joe@perches.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=ndesaulniers@gooogle.com \
--cc=nico@fluxnic.net \
--cc=rppt@kernel.org \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tiantao6@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.