From: David Gibson <david@gibson.dropbear.id.au>
To: Shivaprasad G Bhat <sbhat@linux.ibm.com>
Cc: groug@kaod.org, qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
aneesh.kumar@linux.ibm.com, nvdimm@lists.linux.dev
Subject: Re: [PATCH] spapr: nvdimm: Fix the persistent-memory root node name in device tree
Date: Thu, 27 May 2021 11:09:26 +1000 [thread overview]
Message-ID: <YK7xRlswfpLtkLES@yekko> (raw)
In-Reply-To: <162204278956.219.9061511386011411578.stgit@cc493db1e665>
[-- Attachment #1: Type: text/plain, Size: 1731 bytes --]
On Wed, May 26, 2021 at 11:27:15AM -0400, Shivaprasad G Bhat wrote:
> The FDT code is adding the pmem root node by name "persistent-memory"
> which should have been "ibm,persistent-memory".
>
> The linux fetches the device tree nodes by type and it has been working
> correctly as the type is correct. If someone searches by its intended
> name it would fail, so fix that.
>
> Reported-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
> Signed-off-by: Shivaprasad G Bhat <sbhat@linux.ibm.com>
Applied to ppc-for-6.1, thanks.
> ---
> hw/ppc/spapr_nvdimm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/ppc/spapr_nvdimm.c b/hw/ppc/spapr_nvdimm.c
> index 252204e25f..d7a4a0a051 100644
> --- a/hw/ppc/spapr_nvdimm.c
> +++ b/hw/ppc/spapr_nvdimm.c
> @@ -163,11 +163,11 @@ int spapr_pmem_dt_populate(SpaprDrc *drc, SpaprMachineState *spapr,
>
> void spapr_dt_persistent_memory(SpaprMachineState *spapr, void *fdt)
> {
> - int offset = fdt_subnode_offset(fdt, 0, "persistent-memory");
> + int offset = fdt_subnode_offset(fdt, 0, "ibm,persistent-memory");
> GSList *iter, *nvdimms = nvdimm_get_device_list();
>
> if (offset < 0) {
> - offset = fdt_add_subnode(fdt, 0, "persistent-memory");
> + offset = fdt_add_subnode(fdt, 0, "ibm,persistent-memory");
> _FDT(offset);
> _FDT((fdt_setprop_cell(fdt, offset, "#address-cells", 0x1)));
> _FDT((fdt_setprop_cell(fdt, offset, "#size-cells", 0x0)));
>
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: David Gibson <david@gibson.dropbear.id.au>
To: Shivaprasad G Bhat <sbhat@linux.ibm.com>
Cc: aneesh.kumar@linux.ibm.com, nvdimm@lists.linux.dev,
qemu-ppc@nongnu.org, groug@kaod.org, qemu-devel@nongnu.org
Subject: Re: [PATCH] spapr: nvdimm: Fix the persistent-memory root node name in device tree
Date: Thu, 27 May 2021 11:09:26 +1000 [thread overview]
Message-ID: <YK7xRlswfpLtkLES@yekko> (raw)
In-Reply-To: <162204278956.219.9061511386011411578.stgit@cc493db1e665>
[-- Attachment #1: Type: text/plain, Size: 1731 bytes --]
On Wed, May 26, 2021 at 11:27:15AM -0400, Shivaprasad G Bhat wrote:
> The FDT code is adding the pmem root node by name "persistent-memory"
> which should have been "ibm,persistent-memory".
>
> The linux fetches the device tree nodes by type and it has been working
> correctly as the type is correct. If someone searches by its intended
> name it would fail, so fix that.
>
> Reported-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
> Signed-off-by: Shivaprasad G Bhat <sbhat@linux.ibm.com>
Applied to ppc-for-6.1, thanks.
> ---
> hw/ppc/spapr_nvdimm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/ppc/spapr_nvdimm.c b/hw/ppc/spapr_nvdimm.c
> index 252204e25f..d7a4a0a051 100644
> --- a/hw/ppc/spapr_nvdimm.c
> +++ b/hw/ppc/spapr_nvdimm.c
> @@ -163,11 +163,11 @@ int spapr_pmem_dt_populate(SpaprDrc *drc, SpaprMachineState *spapr,
>
> void spapr_dt_persistent_memory(SpaprMachineState *spapr, void *fdt)
> {
> - int offset = fdt_subnode_offset(fdt, 0, "persistent-memory");
> + int offset = fdt_subnode_offset(fdt, 0, "ibm,persistent-memory");
> GSList *iter, *nvdimms = nvdimm_get_device_list();
>
> if (offset < 0) {
> - offset = fdt_add_subnode(fdt, 0, "persistent-memory");
> + offset = fdt_add_subnode(fdt, 0, "ibm,persistent-memory");
> _FDT(offset);
> _FDT((fdt_setprop_cell(fdt, offset, "#address-cells", 0x1)));
> _FDT((fdt_setprop_cell(fdt, offset, "#size-cells", 0x0)));
>
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-05-27 1:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 15:27 [PATCH] spapr: nvdimm: Fix the persistent-memory root node name in device tree Shivaprasad G Bhat
2021-05-26 15:27 ` Shivaprasad G Bhat
2021-05-27 1:09 ` David Gibson [this message]
2021-05-27 1:09 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YK7xRlswfpLtkLES@yekko \
--to=david@gibson.dropbear.id.au \
--cc=aneesh.kumar@linux.ibm.com \
--cc=groug@kaod.org \
--cc=nvdimm@lists.linux.dev \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=sbhat@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.