From: Vinod Koul <vkoul@kernel.org> To: Yang Li <yang.lee@linux.alibaba.com> Cc: kishon@ti.com, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] phy: ti: Fix an error code in wiz_probe() Date: Mon, 31 May 2021 14:09:59 +0530 [thread overview] Message-ID: <YLSg3z3hYsT/QQ1n@vkoul-mobl.Dlink> (raw) In-Reply-To: <1621939832-65535-1-git-send-email-yang.lee@linux.alibaba.com> On 25-05-21, 18:50, Yang Li wrote: > When the code execute this if statement, the value of ret is 0. > However, we can see from the dev_err() log that the value of > ret should be -EINVAL. > > Clean up smatch warning: > > drivers/phy/ti/phy-j721e-wiz.c:1216 wiz_probe() warn: missing error code > 'ret' Single line is fine for this > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Fixes: 'commit c9f9eba06629 ("phy: ti: j721e-wiz: Manage > typec-gpio-dir")' Please dont split to two lines for fixes tag > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> I have fixed while applying so Applied, thanks > --- > drivers/phy/ti/phy-j721e-wiz.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/phy/ti/phy-j721e-wiz.c b/drivers/phy/ti/phy-j721e-wiz.c > index 9eb6d37..126f5b8 100644 > --- a/drivers/phy/ti/phy-j721e-wiz.c > +++ b/drivers/phy/ti/phy-j721e-wiz.c > @@ -1212,6 +1212,7 @@ static int wiz_probe(struct platform_device *pdev) > > if (wiz->typec_dir_delay < WIZ_TYPEC_DIR_DEBOUNCE_MIN || > wiz->typec_dir_delay > WIZ_TYPEC_DIR_DEBOUNCE_MAX) { > + ret = -EINVAL; > dev_err(dev, "Invalid typec-dir-debounce property\n"); > goto err_addr_to_resource; > } > -- > 1.8.3.1 -- ~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org> To: Yang Li <yang.lee@linux.alibaba.com> Cc: kishon@ti.com, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] phy: ti: Fix an error code in wiz_probe() Date: Mon, 31 May 2021 14:09:59 +0530 [thread overview] Message-ID: <YLSg3z3hYsT/QQ1n@vkoul-mobl.Dlink> (raw) In-Reply-To: <1621939832-65535-1-git-send-email-yang.lee@linux.alibaba.com> On 25-05-21, 18:50, Yang Li wrote: > When the code execute this if statement, the value of ret is 0. > However, we can see from the dev_err() log that the value of > ret should be -EINVAL. > > Clean up smatch warning: > > drivers/phy/ti/phy-j721e-wiz.c:1216 wiz_probe() warn: missing error code > 'ret' Single line is fine for this > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Fixes: 'commit c9f9eba06629 ("phy: ti: j721e-wiz: Manage > typec-gpio-dir")' Please dont split to two lines for fixes tag > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> I have fixed while applying so Applied, thanks > --- > drivers/phy/ti/phy-j721e-wiz.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/phy/ti/phy-j721e-wiz.c b/drivers/phy/ti/phy-j721e-wiz.c > index 9eb6d37..126f5b8 100644 > --- a/drivers/phy/ti/phy-j721e-wiz.c > +++ b/drivers/phy/ti/phy-j721e-wiz.c > @@ -1212,6 +1212,7 @@ static int wiz_probe(struct platform_device *pdev) > > if (wiz->typec_dir_delay < WIZ_TYPEC_DIR_DEBOUNCE_MIN || > wiz->typec_dir_delay > WIZ_TYPEC_DIR_DEBOUNCE_MAX) { > + ret = -EINVAL; > dev_err(dev, "Invalid typec-dir-debounce property\n"); > goto err_addr_to_resource; > } > -- > 1.8.3.1 -- ~Vinod -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2021-05-31 8:41 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-25 10:50 [PATCH] phy: ti: Fix an error code in wiz_probe() Yang Li 2021-05-25 10:50 ` Yang Li 2021-05-31 8:39 ` Vinod Koul [this message] 2021-05-31 8:39 ` Vinod Koul
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YLSg3z3hYsT/QQ1n@vkoul-mobl.Dlink \ --to=vkoul@kernel.org \ --cc=kishon@ti.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-phy@lists.infradead.org \ --cc=yang.lee@linux.alibaba.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.