From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com> To: sean.wang@mediatek.com Cc: nbd@nbd.name, Soul.Huang@mediatek.com, YN.Chen@mediatek.com, Leon.Yen@mediatek.com, Eric-SY.Chang@mediatek.com, Deren.Wu@mediatek.com, km.lin@mediatek.com, robin.chiu@mediatek.com, ch.yeh@mediatek.com, posh.sun@mediatek.com, Eric.Liang@mediatek.com, Stella.Chang@mediatek.com, jemele@google.com, yenlinlai@google.com, linux-wireless@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v2 2/3] mt76: mt7921: add mt7921_mcu_sta_update support Date: Wed, 2 Jun 2021 10:00:45 +0200 [thread overview] Message-ID: <YLc6rWoCtuCdJDiZ@lore-desk> (raw) In-Reply-To: <b6998d5ed25f86e1afce68060d840e0e37cb6670.1622610746.git.objelf@gmail.com> [-- Attachment #1: Type: text/plain, Size: 2814 bytes --] > From: Sean Wang <sean.wang@mediatek.com> > > Add mt7921_mcu_sta_update support to make we are able to update the station > record with the current state the station has into the mt7921 firmware at > runtime. That is the prerequisite patch to fix .sta_state incorrect > implementation for the mt7921 driver. > > Signed-off-by: Sean Wang <sean.wang@mediatek.com> > --- > v1->v2: no change > --- > .../net/wireless/mediatek/mt76/mt7921/mcu.c | 20 +++++++++++++++++++ > .../wireless/mediatek/mt76/mt7921/mt7921.h | 2 ++ > 2 files changed, 22 insertions(+) What about squashing this patch with 3/3? it is just used there. Regards, Lorenzo > > diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c > index 631f408520c9..3f53bd9b2b55 100644 > --- a/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c > +++ b/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c > @@ -1342,6 +1342,26 @@ int mt7921_mcu_sta_add(struct mt7921_dev *dev, struct ieee80211_sta *sta, > return mt76_connac_mcu_add_sta_cmd(&dev->mphy, &info); > } > > +int mt7921_mcu_sta_update(struct mt7921_dev *dev, struct ieee80211_sta *sta, > + struct ieee80211_vif *vif, u8 state) > +{ > + struct mt7921_vif *mvif = (struct mt7921_vif *)vif->drv_priv; > + int rssi = -ewma_rssi_read(&mvif->rssi); > + struct mt76_sta_cmd_info info = { > + .sta = sta, > + .vif = vif, > + .enable = true, > + .state = state, > + .cmd = MCU_UNI_CMD_STA_REC_UPDATE, > + .rcpi = to_rcpi(rssi), > + }; > + struct mt7921_sta *msta; > + > + msta = sta ? (struct mt7921_sta *)sta->drv_priv : NULL; > + info.wcid = msta ? &msta->wcid : &mvif->sta.wcid; > + return mt76_connac_mcu_update_sta_cmd(&dev->mphy, &info); > +} > + > int __mt7921_mcu_drv_pmctrl(struct mt7921_dev *dev) > { > struct mt76_phy *mphy = &dev->mt76.phy; > diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/mt7921.h b/drivers/net/wireless/mediatek/mt76/mt7921/mt7921.h > index 694f85e52222..13d0f472b043 100644 > --- a/drivers/net/wireless/mediatek/mt76/mt7921/mt7921.h > +++ b/drivers/net/wireless/mediatek/mt76/mt7921/mt7921.h > @@ -262,6 +262,8 @@ int mt7921_mcu_add_key(struct mt7921_dev *dev, struct ieee80211_vif *vif, > int mt7921_set_channel(struct mt7921_phy *phy); > int mt7921_mcu_sta_add(struct mt7921_dev *dev, struct ieee80211_sta *sta, > struct ieee80211_vif *vif, bool enable, u8 state); > +int mt7921_mcu_sta_update(struct mt7921_dev *dev, struct ieee80211_sta *sta, > + struct ieee80211_vif *vif, u8 state); > int mt7921_mcu_set_chan_info(struct mt7921_phy *phy, int cmd); > int mt7921_mcu_set_tx(struct mt7921_dev *dev, struct ieee80211_vif *vif); > int mt7921_mcu_set_eeprom(struct mt7921_dev *dev); > -- > 2.25.1 > [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com> To: sean.wang@mediatek.com Cc: nbd@nbd.name, Soul.Huang@mediatek.com, YN.Chen@mediatek.com, Leon.Yen@mediatek.com, Eric-SY.Chang@mediatek.com, Deren.Wu@mediatek.com, km.lin@mediatek.com, robin.chiu@mediatek.com, ch.yeh@mediatek.com, posh.sun@mediatek.com, Eric.Liang@mediatek.com, Stella.Chang@mediatek.com, jemele@google.com, yenlinlai@google.com, linux-wireless@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v2 2/3] mt76: mt7921: add mt7921_mcu_sta_update support Date: Wed, 2 Jun 2021 10:00:45 +0200 [thread overview] Message-ID: <YLc6rWoCtuCdJDiZ@lore-desk> (raw) In-Reply-To: <b6998d5ed25f86e1afce68060d840e0e37cb6670.1622610746.git.objelf@gmail.com> [-- Attachment #1.1: Type: text/plain, Size: 2814 bytes --] > From: Sean Wang <sean.wang@mediatek.com> > > Add mt7921_mcu_sta_update support to make we are able to update the station > record with the current state the station has into the mt7921 firmware at > runtime. That is the prerequisite patch to fix .sta_state incorrect > implementation for the mt7921 driver. > > Signed-off-by: Sean Wang <sean.wang@mediatek.com> > --- > v1->v2: no change > --- > .../net/wireless/mediatek/mt76/mt7921/mcu.c | 20 +++++++++++++++++++ > .../wireless/mediatek/mt76/mt7921/mt7921.h | 2 ++ > 2 files changed, 22 insertions(+) What about squashing this patch with 3/3? it is just used there. Regards, Lorenzo > > diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c > index 631f408520c9..3f53bd9b2b55 100644 > --- a/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c > +++ b/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c > @@ -1342,6 +1342,26 @@ int mt7921_mcu_sta_add(struct mt7921_dev *dev, struct ieee80211_sta *sta, > return mt76_connac_mcu_add_sta_cmd(&dev->mphy, &info); > } > > +int mt7921_mcu_sta_update(struct mt7921_dev *dev, struct ieee80211_sta *sta, > + struct ieee80211_vif *vif, u8 state) > +{ > + struct mt7921_vif *mvif = (struct mt7921_vif *)vif->drv_priv; > + int rssi = -ewma_rssi_read(&mvif->rssi); > + struct mt76_sta_cmd_info info = { > + .sta = sta, > + .vif = vif, > + .enable = true, > + .state = state, > + .cmd = MCU_UNI_CMD_STA_REC_UPDATE, > + .rcpi = to_rcpi(rssi), > + }; > + struct mt7921_sta *msta; > + > + msta = sta ? (struct mt7921_sta *)sta->drv_priv : NULL; > + info.wcid = msta ? &msta->wcid : &mvif->sta.wcid; > + return mt76_connac_mcu_update_sta_cmd(&dev->mphy, &info); > +} > + > int __mt7921_mcu_drv_pmctrl(struct mt7921_dev *dev) > { > struct mt76_phy *mphy = &dev->mt76.phy; > diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/mt7921.h b/drivers/net/wireless/mediatek/mt76/mt7921/mt7921.h > index 694f85e52222..13d0f472b043 100644 > --- a/drivers/net/wireless/mediatek/mt76/mt7921/mt7921.h > +++ b/drivers/net/wireless/mediatek/mt76/mt7921/mt7921.h > @@ -262,6 +262,8 @@ int mt7921_mcu_add_key(struct mt7921_dev *dev, struct ieee80211_vif *vif, > int mt7921_set_channel(struct mt7921_phy *phy); > int mt7921_mcu_sta_add(struct mt7921_dev *dev, struct ieee80211_sta *sta, > struct ieee80211_vif *vif, bool enable, u8 state); > +int mt7921_mcu_sta_update(struct mt7921_dev *dev, struct ieee80211_sta *sta, > + struct ieee80211_vif *vif, u8 state); > int mt7921_mcu_set_chan_info(struct mt7921_phy *phy, int cmd); > int mt7921_mcu_set_tx(struct mt7921_dev *dev, struct ieee80211_vif *vif); > int mt7921_mcu_set_eeprom(struct mt7921_dev *dev); > -- > 2.25.1 > [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] [-- Attachment #2: Type: text/plain, Size: 170 bytes --] _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2021-06-02 8:01 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-02 5:24 [PATCH v2 1/3] mt76: connac: add mt76_connac_mcu_update_sta_cmd support sean.wang 2021-06-02 5:24 ` sean.wang 2021-06-02 5:24 ` [PATCH v2 2/3] mt76: mt7921: add mt7921_mcu_sta_update support sean.wang 2021-06-02 5:24 ` sean.wang 2021-06-02 8:00 ` Lorenzo Bianconi [this message] 2021-06-02 8:00 ` Lorenzo Bianconi 2021-06-02 5:24 ` [PATCH v2 3/3] mt76: mt7921: fix sta_state incorrect implementation sean.wang 2021-06-02 5:24 ` sean.wang 2021-06-02 7:51 ` Lorenzo Bianconi 2021-06-02 7:51 ` Lorenzo Bianconi 2021-06-02 5:59 ` [PATCH v2 1/3] mt76: connac: add mt76_connac_mcu_update_sta_cmd support Felix Fietkau 2021-06-02 5:59 ` Felix Fietkau 2021-06-02 7:43 ` Lorenzo Bianconi 2021-06-02 7:43 ` Lorenzo Bianconi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YLc6rWoCtuCdJDiZ@lore-desk \ --to=lorenzo.bianconi@redhat.com \ --cc=Deren.Wu@mediatek.com \ --cc=Eric-SY.Chang@mediatek.com \ --cc=Eric.Liang@mediatek.com \ --cc=Leon.Yen@mediatek.com \ --cc=Soul.Huang@mediatek.com \ --cc=Stella.Chang@mediatek.com \ --cc=YN.Chen@mediatek.com \ --cc=ch.yeh@mediatek.com \ --cc=jemele@google.com \ --cc=km.lin@mediatek.com \ --cc=linux-mediatek@lists.infradead.org \ --cc=linux-wireless@vger.kernel.org \ --cc=nbd@nbd.name \ --cc=posh.sun@mediatek.com \ --cc=robin.chiu@mediatek.com \ --cc=sean.wang@mediatek.com \ --cc=yenlinlai@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.