From: Joerg Roedel <joro@8bytes.org>
To: Tianyu Lan <ltykernel@gmail.com>
Cc: kys@microsoft.com, haiyangz@microsoft.com,
sthemmin@microsoft.com, wei.liu@kernel.org, decui@microsoft.com,
tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
x86@kernel.org, hpa@zytor.com, arnd@arndb.de,
dave.hansen@linux.intel.com, luto@kernel.org,
peterz@infradead.org, akpm@linux-foundation.org,
kirill.shutemov@linux.intel.com, rppt@kernel.org,
hannes@cmpxchg.org, cai@lca.pw, krish.sadhukhan@oracle.com,
saravanand@fb.com, Tianyu.Lan@microsoft.com,
konrad.wilk@oracle.com, hch@lst.de, m.szyprowski@samsung.com,
robin.murphy@arm.com, boris.ostrovsky@oracle.com,
jgross@suse.com, sstabellini@kernel.org, will@kernel.org,
xen-devel@lists.xenproject.org, davem@davemloft.net,
kuba@kernel.org, jejb@linux.ibm.com, martin.petersen@oracle.com,
iommu@lists.linux-foundation.org, linux-arch@vger.kernel.org,
linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org, netdev@vger.kernel.org,
vkuznets@redhat.com, thomas.lendacky@amd.com,
brijesh.singh@amd.com, sunilmut@microsoft.com
Subject: Re: [RFC PATCH V3 05/11] HV: Add ghcb hvcall support for SNP VM
Date: Wed, 9 Jun 2021 14:49:19 +0200 [thread overview]
Message-ID: <YMC4z6L0PU3+HCTD@8bytes.org> (raw)
In-Reply-To: <20210530150628.2063957-6-ltykernel@gmail.com>
On Sun, May 30, 2021 at 11:06:22AM -0400, Tianyu Lan wrote:
> +u64 hv_ghcb_hypercall(u64 control, void *input, void *output, u32 input_size)
> +{
> + union hv_ghcb *hv_ghcb;
> + void **ghcb_base;
> + unsigned long flags;
> +
> + if (!ms_hyperv.ghcb_base)
> + return -EFAULT;
> +
> + local_irq_save(flags);
> + ghcb_base = (void **)this_cpu_ptr(ms_hyperv.ghcb_base);
> + hv_ghcb = (union hv_ghcb *)*ghcb_base;
> + if (!hv_ghcb) {
> + local_irq_restore(flags);
> + return -EFAULT;
> + }
> +
> + memset(hv_ghcb, 0x00, HV_HYP_PAGE_SIZE);
> + hv_ghcb->ghcb.protocol_version = 1;
> + hv_ghcb->ghcb.ghcb_usage = 1;
> +
> + hv_ghcb->hypercall.outputgpa = (u64)output;
> + hv_ghcb->hypercall.hypercallinput.asuint64 = 0;
> + hv_ghcb->hypercall.hypercallinput.callcode = control;
> +
> + if (input_size)
> + memcpy(hv_ghcb->hypercall.hypercalldata, input, input_size);
> +
> + VMGEXIT();
Also not NMI-safe. When you re-use the existing GHCB setup code from
from SEV-ES code, you can also use sev_es_get/put_ghcb() which takes
care of re-using a GHCB already in use.
Regards,
Joerg
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Tianyu Lan <ltykernel@gmail.com>
Cc: linux-hyperv@vger.kernel.org, brijesh.singh@amd.com,
thomas.lendacky@amd.com, peterz@infradead.org,
dave.hansen@linux.intel.com, hpa@zytor.com, kys@microsoft.com,
will@kernel.org, hch@lst.de, linux-arch@vger.kernel.org,
wei.liu@kernel.org, sstabellini@kernel.org,
sthemmin@microsoft.com, linux-scsi@vger.kernel.org,
x86@kernel.org, decui@microsoft.com, mingo@redhat.com,
xen-devel@lists.xenproject.org, jejb@linux.ibm.com,
jgross@suse.com, Tianyu.Lan@microsoft.com, arnd@arndb.de,
konrad.wilk@oracle.com, haiyangz@microsoft.com, kuba@kernel.org,
bp@alien8.de, luto@kernel.org, krish.sadhukhan@oracle.com,
tglx@linutronix.de, vkuznets@redhat.com,
boris.ostrovsky@oracle.com, martin.petersen@oracle.com,
saravanand@fb.com, netdev@vger.kernel.org,
sunilmut@microsoft.com, linux-kernel@vger.kernel.org,
iommu@lists.linux-foundation.org,
kirill.shutemov@linux.intel.com, hannes@cmpxchg.org, cai@lca.pw,
akpm@linux-foundation.org, robin.murphy@arm.com,
davem@davemloft.net, rppt@kernel.org
Subject: Re: [RFC PATCH V3 05/11] HV: Add ghcb hvcall support for SNP VM
Date: Wed, 9 Jun 2021 14:49:19 +0200 [thread overview]
Message-ID: <YMC4z6L0PU3+HCTD@8bytes.org> (raw)
In-Reply-To: <20210530150628.2063957-6-ltykernel@gmail.com>
On Sun, May 30, 2021 at 11:06:22AM -0400, Tianyu Lan wrote:
> +u64 hv_ghcb_hypercall(u64 control, void *input, void *output, u32 input_size)
> +{
> + union hv_ghcb *hv_ghcb;
> + void **ghcb_base;
> + unsigned long flags;
> +
> + if (!ms_hyperv.ghcb_base)
> + return -EFAULT;
> +
> + local_irq_save(flags);
> + ghcb_base = (void **)this_cpu_ptr(ms_hyperv.ghcb_base);
> + hv_ghcb = (union hv_ghcb *)*ghcb_base;
> + if (!hv_ghcb) {
> + local_irq_restore(flags);
> + return -EFAULT;
> + }
> +
> + memset(hv_ghcb, 0x00, HV_HYP_PAGE_SIZE);
> + hv_ghcb->ghcb.protocol_version = 1;
> + hv_ghcb->ghcb.ghcb_usage = 1;
> +
> + hv_ghcb->hypercall.outputgpa = (u64)output;
> + hv_ghcb->hypercall.hypercallinput.asuint64 = 0;
> + hv_ghcb->hypercall.hypercallinput.callcode = control;
> +
> + if (input_size)
> + memcpy(hv_ghcb->hypercall.hypercalldata, input, input_size);
> +
> + VMGEXIT();
Also not NMI-safe. When you re-use the existing GHCB setup code from
from SEV-ES code, you can also use sev_es_get/put_ghcb() which takes
care of re-using a GHCB already in use.
Regards,
Joerg
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2021-06-09 12:49 UTC|newest]
Thread overview: 98+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-30 15:06 [RFC PATCH V3 00/11] x86/Hyper-V: Add Hyper-V Isolation VM support Tianyu Lan
2021-05-30 15:06 ` Tianyu Lan
2021-05-30 15:06 ` [RFC PATCH V3 01/11] x86/HV: Initialize GHCB page in Isolation VM Tianyu Lan
2021-05-30 15:06 ` Tianyu Lan
2021-06-07 6:41 ` Christoph Hellwig
2021-06-07 6:41 ` Christoph Hellwig
2021-06-07 8:14 ` Tianyu Lan
2021-06-07 8:14 ` Tianyu Lan
2021-06-09 12:38 ` Joerg Roedel
2021-06-09 12:38 ` Joerg Roedel
2021-06-10 14:13 ` Tianyu Lan
2021-06-10 14:13 ` Tianyu Lan
2021-05-30 15:06 ` [RFC PATCH V3 02/11] x86/HV: Initialize shared memory boundary in the " Tianyu Lan
2021-05-30 15:06 ` Tianyu Lan
2021-05-30 15:06 ` [RFC PATCH V3 03/11] x86/Hyper-V: Add new hvcall guest address host visibility support Tianyu Lan
2021-05-30 15:06 ` Tianyu Lan
2021-05-30 18:25 ` Borislav Petkov
2021-05-30 18:25 ` Borislav Petkov
2021-05-31 4:08 ` Tianyu Lan
2021-05-31 4:08 ` Tianyu Lan
2021-06-10 9:47 ` Vitaly Kuznetsov
2021-06-10 9:47 ` Vitaly Kuznetsov
2021-06-10 14:18 ` Tianyu Lan
2021-06-10 14:18 ` Tianyu Lan
2021-05-30 15:06 ` [RFC PATCH V3 04/11] HV: Add Write/Read MSR registers via ghcb Tianyu Lan
2021-05-30 15:06 ` Tianyu Lan
2021-06-09 12:46 ` Joerg Roedel
2021-06-09 12:46 ` Joerg Roedel
2021-06-10 14:15 ` Tianyu Lan
2021-06-10 14:15 ` Tianyu Lan
2021-05-30 15:06 ` [RFC PATCH V3 05/11] HV: Add ghcb hvcall support for SNP VM Tianyu Lan
2021-05-30 15:06 ` Tianyu Lan
2021-06-09 12:49 ` Joerg Roedel [this message]
2021-06-09 12:49 ` Joerg Roedel
2021-05-30 15:06 ` [RFC PATCH V3 06/11] HV/Vmbus: Add SNP support for VMbus channel initiate message Tianyu Lan
2021-05-30 15:06 ` Tianyu Lan
2021-05-30 15:06 ` [RFC PATCH V3 07/11] HV/Vmbus: Initialize VMbus ring buffer for Isolation VM Tianyu Lan
2021-05-30 15:06 ` Tianyu Lan
2021-05-30 15:06 ` [RFC PATCH V3 08/11] swiotlb: Add bounce buffer remap address setting function Tianyu Lan
2021-05-30 15:06 ` Tianyu Lan
2021-06-07 6:43 ` Christoph Hellwig
2021-06-07 6:43 ` Christoph Hellwig
2021-06-07 14:56 ` Tianyu Lan
2021-06-07 14:56 ` Tianyu Lan
2021-06-10 14:25 ` Tianyu Lan
2021-06-10 14:25 ` Tianyu Lan
2021-06-14 7:12 ` Christoph Hellwig
2021-06-14 7:12 ` Christoph Hellwig
2021-06-14 13:29 ` Tom Lendacky
2021-06-14 13:29 ` Tom Lendacky via iommu
2021-06-14 13:37 ` Tianyu Lan
2021-06-14 13:37 ` Tianyu Lan
2021-06-14 13:42 ` Tianyu Lan
2021-06-14 13:42 ` Tianyu Lan
2021-06-14 13:49 ` Robin Murphy
2021-06-14 13:49 ` Robin Murphy
2021-06-14 15:32 ` Christoph Hellwig
2021-06-14 15:32 ` Christoph Hellwig
2021-06-15 15:24 ` Tianyu Lan
2021-06-15 15:24 ` Tianyu Lan
2021-07-12 9:40 ` Tianyu Lan
2021-07-12 9:40 ` Tianyu Lan
2021-05-30 15:06 ` [RFC PATCH V3 09/11] HV/IOMMU: Enable swiotlb bounce buffer for Isolation VM Tianyu Lan
2021-05-30 15:06 ` Tianyu Lan
2021-06-02 1:16 ` Boris Ostrovsky
2021-06-02 1:16 ` Boris Ostrovsky
2021-06-02 15:01 ` Tianyu Lan
2021-06-02 15:01 ` Tianyu Lan
2021-06-02 16:02 ` Boris Ostrovsky
2021-06-02 16:02 ` Boris Ostrovsky
2021-06-03 15:37 ` Tianyu Lan
2021-06-03 15:37 ` Tianyu Lan
2021-06-03 17:04 ` Boris Ostrovsky
2021-06-03 17:04 ` Boris Ostrovsky
2021-06-07 6:44 ` Christoph Hellwig
2021-06-07 6:44 ` Christoph Hellwig
2021-05-30 15:06 ` [RFC PATCH V3 10/11] HV/Netvsc: Add Isolation VM support for netvsc driver Tianyu Lan
2021-05-30 15:06 ` Tianyu Lan
2021-06-07 6:50 ` Christoph Hellwig
2021-06-07 6:50 ` Christoph Hellwig
2021-06-07 15:21 ` Tianyu Lan
2021-06-07 15:21 ` Tianyu Lan
2021-06-14 7:09 ` Christoph Hellwig
2021-06-14 7:09 ` Christoph Hellwig
2021-06-14 14:04 ` Tianyu Lan
2021-06-14 14:04 ` Tianyu Lan
2021-06-14 15:33 ` Christoph Hellwig
2021-06-14 15:33 ` Christoph Hellwig
2021-06-15 14:31 ` Tianyu Lan
2021-06-15 14:31 ` Tianyu Lan
2021-06-10 9:52 ` Vitaly Kuznetsov
2021-06-10 9:52 ` Vitaly Kuznetsov
2021-05-30 15:06 ` [RFC PATCH V3 11/11] HV/Storvsc: Add Isolation VM support for storvsc driver Tianyu Lan
2021-05-30 15:06 ` Tianyu Lan
2021-06-07 6:46 ` Christoph Hellwig
2021-06-07 6:46 ` Christoph Hellwig
2021-06-07 14:59 ` Tianyu Lan
2021-06-07 14:59 ` Tianyu Lan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMC4z6L0PU3+HCTD@8bytes.org \
--to=joro@8bytes.org \
--cc=Tianyu.Lan@microsoft.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=brijesh.singh@amd.com \
--cc=cai@lca.pw \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=hannes@cmpxchg.org \
--cc=hch@lst.de \
--cc=hpa@zytor.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jejb@linux.ibm.com \
--cc=jgross@suse.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=konrad.wilk@oracle.com \
--cc=krish.sadhukhan@oracle.com \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=ltykernel@gmail.com \
--cc=luto@kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=martin.petersen@oracle.com \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=robin.murphy@arm.com \
--cc=rppt@kernel.org \
--cc=saravanand@fb.com \
--cc=sstabellini@kernel.org \
--cc=sthemmin@microsoft.com \
--cc=sunilmut@microsoft.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=vkuznets@redhat.com \
--cc=wei.liu@kernel.org \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.