From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Bhupesh Sharma <bhupesh.sharma@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, bhupesh.linux@gmail.com,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Vinod Koul <vkoul@kernel.org>,
Rob Herring <robh+dt@kernel.org>, Andy Gross <agross@kernel.org>
Subject: Re: [PATCH v2 06/10] regulator: qcom-rpmh: Add new regulator found on SA8155p adp board
Date: Tue, 15 Jun 2021 16:10:42 -0500 [thread overview]
Message-ID: <YMkXUj9A6qHcO3e4@builder.lan> (raw)
In-Reply-To: <20210615074543.26700-7-bhupesh.sharma@linaro.org>
On Tue 15 Jun 02:45 CDT 2021, Bhupesh Sharma wrote:
> SA8155p-adp board supports a new regulator - pmm8155au.
>
> The output power management circuits in this regulator include:
> - FTS510 smps,
> - HFS510 smps, and
> - LDO510 linear regulators
>
> Add support for the same.
>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Liam Girdwood <lgirdwood@gmail.com>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Andy Gross <agross@kernel.org>
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
Not sure if I should interpret Mark's comment in the way that he already
picked this patch up.
> ---
> drivers/regulator/qcom-rpmh-regulator.c | 36 +++++++++++++++++++++++++
> 1 file changed, 36 insertions(+)
>
> diff --git a/drivers/regulator/qcom-rpmh-regulator.c b/drivers/regulator/qcom-rpmh-regulator.c
> index af41a517da99..73623d51929b 100644
> --- a/drivers/regulator/qcom-rpmh-regulator.c
> +++ b/drivers/regulator/qcom-rpmh-regulator.c
> @@ -883,6 +883,38 @@ static const struct rpmh_vreg_init_data pm8150l_vreg_data[] = {
> {}
> };
>
> +static const struct rpmh_vreg_init_data pmm8155au_vreg_data[] = {
> + RPMH_VREG("smps1", "smp%s1", &pmic5_ftsmps510, "vdd-s1"),
> + RPMH_VREG("smps2", "smp%s2", &pmic5_ftsmps510, "vdd-s2"),
> + RPMH_VREG("smps3", "smp%s3", &pmic5_ftsmps510, "vdd-s3"),
> + RPMH_VREG("smps4", "smp%s4", &pmic5_hfsmps510, "vdd-s4"),
> + RPMH_VREG("smps5", "smp%s5", &pmic5_hfsmps510, "vdd-s5"),
> + RPMH_VREG("smps6", "smp%s6", &pmic5_ftsmps510, "vdd-s6"),
> + RPMH_VREG("smps7", "smp%s7", &pmic5_ftsmps510, "vdd-s7"),
> + RPMH_VREG("smps8", "smp%s8", &pmic5_ftsmps510, "vdd-s8"),
> + RPMH_VREG("smps9", "smp%s9", &pmic5_ftsmps510, "vdd-s9"),
> + RPMH_VREG("smps10", "smp%s10", &pmic5_ftsmps510, "vdd-s10"),
> + RPMH_VREG("ldo1", "ldo%s1", &pmic5_nldo, "vdd-l1-l8-l11"),
> + RPMH_VREG("ldo2", "ldo%s2", &pmic5_pldo, "vdd-l2-l10"),
> + RPMH_VREG("ldo3", "ldo%s3", &pmic5_nldo, "vdd-l3-l4-l5-l18"),
> + RPMH_VREG("ldo4", "ldo%s4", &pmic5_nldo, "vdd-l3-l4-l5-l18"),
> + RPMH_VREG("ldo5", "ldo%s5", &pmic5_nldo, "vdd-l3-l4-l5-l18"),
> + RPMH_VREG("ldo6", "ldo%s6", &pmic5_nldo, "vdd-l6-l9"),
> + RPMH_VREG("ldo7", "ldo%s7", &pmic5_pldo_lv, "vdd-l7-l12-l14-l15"),
> + RPMH_VREG("ldo8", "ldo%s8", &pmic5_nldo, "vdd-l1-l8-l11"),
> + RPMH_VREG("ldo9", "ldo%s9", &pmic5_nldo, "vdd-l6-l9"),
> + RPMH_VREG("ldo10", "ldo%s10", &pmic5_pldo, "vdd-l2-l10"),
> + RPMH_VREG("ldo11", "ldo%s11", &pmic5_nldo, "vdd-l1-l8-l11"),
> + RPMH_VREG("ldo12", "ldo%s12", &pmic5_pldo_lv, "vdd-l7-l12-l14-l15"),
> + RPMH_VREG("ldo13", "ldo%s13", &pmic5_pldo, "vdd-l13-l16-l17"),
> + RPMH_VREG("ldo14", "ldo%s14", &pmic5_pldo_lv, "vdd-l7-l12-l14-l15"),
> + RPMH_VREG("ldo15", "ldo%s15", &pmic5_pldo_lv, "vdd-l7-l12-l14-l15"),
> + RPMH_VREG("ldo16", "ldo%s16", &pmic5_pldo, "vdd-l13-l16-l17"),
> + RPMH_VREG("ldo17", "ldo%s17", &pmic5_pldo, "vdd-l13-l16-l17"),
> + RPMH_VREG("ldo18", "ldo%s18", &pmic5_nldo, "vdd-l3-l4-l5-l18"),
> + {}
> +};
> +
> static const struct rpmh_vreg_init_data pm8350_vreg_data[] = {
> RPMH_VREG("smps1", "smp%s1", &pmic5_ftsmps510, "vdd-s1"),
> RPMH_VREG("smps2", "smp%s2", &pmic5_ftsmps510, "vdd-s2"),
> @@ -1145,6 +1177,10 @@ static const struct of_device_id __maybe_unused rpmh_regulator_match_table[] = {
> .compatible = "qcom,pm8150l-rpmh-regulators",
> .data = pm8150l_vreg_data,
> },
> + {
> + .compatible = "qcom,pmm8155au-rpmh-regulators",
It would be preferable if this was sorted alphabetically (on the
compatible).
With that,
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> + .data = pmm8155au_vreg_data,
> + },
> {
> .compatible = "qcom,pm8350-rpmh-regulators",
> .data = pm8350_vreg_data,
> --
> 2.31.1
>
next prev parent reply other threads:[~2021-06-15 21:10 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 7:45 [PATCH v2 00/10] arm64: dts: qcom: Add SA8155p-adp board DTS Bhupesh Sharma
2021-06-15 7:45 ` [PATCH v2 01/10] dt-bindings: qcom: rpmh-regulator: Add compatible for SA8155p-adp board pmic Bhupesh Sharma
2021-06-24 20:47 ` Rob Herring
2021-06-15 7:45 ` [PATCH v2 02/10] dt-bindings: pinctrl: qcom,pmic-gpio: Add compatible for SA8155p-adp Bhupesh Sharma
2021-06-15 21:00 ` Bjorn Andersson
2021-06-16 6:26 ` Bhupesh Sharma
2021-06-15 7:45 ` [PATCH v2 03/10] dt-bindings: arm: qcom: Add compatible for sm8150-mtp board Bhupesh Sharma
2021-06-15 7:45 ` [PATCH v2 04/10] dt-bindings: arm: qcom: Add compatible for SA8155p-adp board Bhupesh Sharma
2021-06-15 7:45 ` [PATCH v2 05/10] regulator: qcom-rpmh: Cleanup terminator line commas Bhupesh Sharma
2021-06-15 21:06 ` Bjorn Andersson
2021-06-15 7:45 ` [PATCH v2 06/10] regulator: qcom-rpmh: Add new regulator found on SA8155p adp board Bhupesh Sharma
2021-06-15 11:12 ` Mark Brown
2021-06-15 14:38 ` Bhupesh Sharma
2021-06-15 15:35 ` Mark Brown
2021-06-15 21:10 ` Bjorn Andersson [this message]
2021-06-15 7:45 ` [PATCH v2 07/10] pinctrl: qcom/pinctrl-spmi-gpio: Add compatible for pmic-gpio on SA8155p-adp Bhupesh Sharma
2021-06-15 21:07 ` Bjorn Andersson
2021-06-15 7:45 ` [PATCH v2 08/10] arm64: dts: qcom: pmm8155au_1: Add base dts file Bhupesh Sharma
2021-06-15 21:08 ` Bjorn Andersson
2021-06-15 7:45 ` [PATCH v2 09/10] arm64: dts: qcom: pmm8155au_2: " Bhupesh Sharma
2021-06-15 21:09 ` Bjorn Andersson
2021-06-15 7:45 ` [PATCH v2 10/10] arm64: dts: qcom: sa8155p-adp: " Bhupesh Sharma
2021-06-15 14:53 ` Konrad Dybcio
2021-06-15 17:00 ` Bhupesh Sharma
2021-06-15 21:13 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMkXUj9A6qHcO3e4@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=bhupesh.linux@gmail.com \
--cc=bhupesh.sharma@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.