From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Kieran Bingham <kieran.bingham@ideasonboard.com>
Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
"open list:DRM DRIVERS FOR RENESAS"
<dri-devel@lists.freedesktop.org>,
"open list:DRM DRIVERS FOR RENESAS"
<linux-renesas-soc@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] drm: rcar-du: Sort the DU outputs
Date: Wed, 23 Jun 2021 05:13:02 +0300 [thread overview]
Message-ID: <YNKYrmf4p65DruSh@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20210622232024.3215248-2-kieran.bingham@ideasonboard.com>
Hi Kieran,
Thank you for the patch.
On Wed, Jun 23, 2021 at 12:20:22AM +0100, Kieran Bingham wrote:
> From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>
> Sort the DU outputs alphabetically, with the exception of the final
> entry which is there as a sentinal.
>
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/gpu/drm/rcar-du/rcar_du_crtc.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_crtc.h b/drivers/gpu/drm/rcar-du/rcar_du_crtc.h
> index 5f2940c42225..440e6b4fbb58 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_crtc.h
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_crtc.h
> @@ -96,10 +96,10 @@ struct rcar_du_crtc_state {
> enum rcar_du_output {
> RCAR_DU_OUTPUT_DPAD0,
> RCAR_DU_OUTPUT_DPAD1,
> - RCAR_DU_OUTPUT_LVDS0,
> - RCAR_DU_OUTPUT_LVDS1,
> RCAR_DU_OUTPUT_HDMI0,
> RCAR_DU_OUTPUT_HDMI1,
> + RCAR_DU_OUTPUT_LVDS0,
> + RCAR_DU_OUTPUT_LVDS1,
> RCAR_DU_OUTPUT_TCON,
> RCAR_DU_OUTPUT_MAX,
> };
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Kieran Bingham <kieran.bingham@ideasonboard.com>
Cc: David Airlie <airlied@linux.ie>,
open list <linux-kernel@vger.kernel.org>,
"open list:DRM DRIVERS FOR RENESAS"
<dri-devel@lists.freedesktop.org>,
"open list:DRM DRIVERS FOR RENESAS"
<linux-renesas-soc@vger.kernel.org>,
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Subject: Re: [PATCH 1/3] drm: rcar-du: Sort the DU outputs
Date: Wed, 23 Jun 2021 05:13:02 +0300 [thread overview]
Message-ID: <YNKYrmf4p65DruSh@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20210622232024.3215248-2-kieran.bingham@ideasonboard.com>
Hi Kieran,
Thank you for the patch.
On Wed, Jun 23, 2021 at 12:20:22AM +0100, Kieran Bingham wrote:
> From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>
> Sort the DU outputs alphabetically, with the exception of the final
> entry which is there as a sentinal.
>
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/gpu/drm/rcar-du/rcar_du_crtc.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_crtc.h b/drivers/gpu/drm/rcar-du/rcar_du_crtc.h
> index 5f2940c42225..440e6b4fbb58 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_crtc.h
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_crtc.h
> @@ -96,10 +96,10 @@ struct rcar_du_crtc_state {
> enum rcar_du_output {
> RCAR_DU_OUTPUT_DPAD0,
> RCAR_DU_OUTPUT_DPAD1,
> - RCAR_DU_OUTPUT_LVDS0,
> - RCAR_DU_OUTPUT_LVDS1,
> RCAR_DU_OUTPUT_HDMI0,
> RCAR_DU_OUTPUT_HDMI1,
> + RCAR_DU_OUTPUT_LVDS0,
> + RCAR_DU_OUTPUT_LVDS1,
> RCAR_DU_OUTPUT_TCON,
> RCAR_DU_OUTPUT_MAX,
> };
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2021-06-23 2:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210622232024.3215248-1-kieran.bingham@ideasonboard.com>
2021-06-22 23:20 ` [PATCH 1/3] drm: rcar-du: Sort the DU outputs Kieran Bingham
2021-06-22 23:20 ` Kieran Bingham
2021-06-23 2:13 ` Laurent Pinchart [this message]
2021-06-23 2:13 ` Laurent Pinchart
2021-06-22 23:20 ` [PATCH 2/3] drm: rcar-du: Only initialise TVM_TVSYNC mode when supported Kieran Bingham
2021-06-22 23:20 ` Kieran Bingham
2021-06-23 2:16 ` Laurent Pinchart
2021-06-23 2:16 ` Laurent Pinchart
2021-06-22 23:20 ` [PATCH 3/3] drm: rcar-du: Add r8a779a0 device support Kieran Bingham
2021-06-22 23:20 ` Kieran Bingham
2021-06-23 2:27 ` Laurent Pinchart
2021-06-23 2:27 ` Laurent Pinchart
2021-06-23 10:50 ` Kieran Bingham
2021-06-23 10:50 ` Kieran Bingham
2021-06-23 5:51 ` kernel test robot
2021-06-23 8:59 ` kernel test robot
2021-06-23 2:09 ` [PATCH 0/3] drm: rcar-du: V3U support Laurent Pinchart
2021-06-23 2:09 ` Laurent Pinchart
2021-06-23 8:28 ` Kieran Bingham
2021-06-23 8:28 ` Kieran Bingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNKYrmf4p65DruSh@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.