From: Matthias Kaehlcke <mka@chromium.org> To: Sibi Sankar <sibis@codeaurora.org> Cc: bjorn.andersson@linaro.org, robh+dt@kernel.org, will@kernel.org, saiprakash.ranjan@codeaurora.org, ohad@wizery.com, agross@kernel.org, mathieu.poirier@linaro.org, robin.murphy@arm.com, joro@8bytes.org, p.zabel@pengutronix.de, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, evgreen@chromium.org, dianders@chromium.org, swboyd@chromium.org Subject: Re: [PATCH 6/9] arm64: dts: qcom: sc7280: Update reserved memory map Date: Mon, 28 Jun 2021 11:11:33 -0700 [thread overview] Message-ID: <YNoQ1d1hUyIh/qxz@google.com> (raw) In-Reply-To: <1624564058-24095-7-git-send-email-sibis@codeaurora.org> On Fri, Jun 25, 2021 at 01:17:35AM +0530, Sibi Sankar wrote: > Subject: arm64: dts: qcom: sc7280: Update reserved memory map That's very vague. Also personally I'm not a fan of patches that touch SoC and board files with a commit message that only mentions the SoC, as is frequently done for IDP boards. Why not split this in (at least) two, one for adding the missing memory regions to the SoC, and one for the IDP. > Add missing regions and remove unused regions from the reserved memory > map, as described in version 1. What is this 'version 1'?
WARNING: multiple messages have this Message-ID (diff)
From: Matthias Kaehlcke <mka@chromium.org> To: Sibi Sankar <sibis@codeaurora.org> Cc: bjorn.andersson@linaro.org, robh+dt@kernel.org, will@kernel.org, saiprakash.ranjan@codeaurora.org, ohad@wizery.com, agross@kernel.org, mathieu.poirier@linaro.org, robin.murphy@arm.com, joro@8bytes.org, p.zabel@pengutronix.de, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, evgreen@chromium.org, dianders@chromium.org, swboyd@chromium.org Subject: Re: [PATCH 6/9] arm64: dts: qcom: sc7280: Update reserved memory map Date: Mon, 28 Jun 2021 11:11:33 -0700 [thread overview] Message-ID: <YNoQ1d1hUyIh/qxz@google.com> (raw) In-Reply-To: <1624564058-24095-7-git-send-email-sibis@codeaurora.org> On Fri, Jun 25, 2021 at 01:17:35AM +0530, Sibi Sankar wrote: > Subject: arm64: dts: qcom: sc7280: Update reserved memory map That's very vague. Also personally I'm not a fan of patches that touch SoC and board files with a commit message that only mentions the SoC, as is frequently done for IDP boards. Why not split this in (at least) two, one for adding the missing memory regions to the SoC, and one for the IDP. > Add missing regions and remove unused regions from the reserved memory > map, as described in version 1. What is this 'version 1'? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-28 18:11 UTC|newest] Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-24 19:47 [PATCH 0/9] Add Modem support on SC7280 SoCs Sibi Sankar 2021-06-24 19:47 ` [PATCH 1/9] dt-bindings: remoteproc: qcom: pas: Add SC7280 MPSS support Sibi Sankar 2021-06-25 17:12 ` Matthias Kaehlcke 2021-06-25 17:12 ` Matthias Kaehlcke 2021-06-25 17:28 ` Sibi Sankar 2021-06-25 23:20 ` Matthias Kaehlcke 2021-06-25 23:20 ` Matthias Kaehlcke 2021-07-14 19:36 ` Rob Herring 2021-07-14 19:36 ` Rob Herring 2021-06-24 19:47 ` [PATCH 2/9] remoteproc: qcom: pas: Add SC7280 Modem support Sibi Sankar 2021-06-25 23:23 ` Matthias Kaehlcke 2021-06-25 23:23 ` Matthias Kaehlcke 2021-06-24 19:47 ` [PATCH 3/9] dt-bindings: remoteproc: qcom: Add Q6V5 Modem PIL binding Sibi Sankar 2021-06-25 23:43 ` Matthias Kaehlcke 2021-06-25 23:43 ` Matthias Kaehlcke 2021-06-30 19:57 ` Sibi Sankar 2021-07-14 19:37 ` Rob Herring 2021-07-14 19:37 ` Rob Herring 2021-06-24 19:47 ` [PATCH 4/9] iommu/arm-smmu-qcom: Request direct mapping for modem device Sibi Sankar 2021-06-25 4:27 ` Sai Prakash Ranjan 2021-06-24 19:47 ` [PATCH 5/9] remoteproc: mss: q6v5-mss: Add modem support on SC7280 Sibi Sankar 2021-06-25 0:35 ` Matthias Kaehlcke 2021-06-25 0:35 ` Matthias Kaehlcke 2021-06-25 14:21 ` Sibi Sankar 2021-06-25 16:39 ` Matthias Kaehlcke 2021-06-25 16:39 ` Matthias Kaehlcke 2021-06-24 19:47 ` [PATCH 6/9] arm64: dts: qcom: sc7280: Update reserved memory map Sibi Sankar 2021-06-28 18:11 ` Matthias Kaehlcke [this message] 2021-06-28 18:11 ` Matthias Kaehlcke 2021-06-30 20:02 ` Sibi Sankar 2021-07-30 18:24 ` Bjorn Andersson 2021-07-30 18:24 ` Bjorn Andersson 2021-06-24 19:47 ` [PATCH 7/9] arm64: dts: qcom: sc7280: Add nodes to boot modem Sibi Sankar 2021-07-30 18:00 ` Bjorn Andersson 2021-07-30 18:00 ` Bjorn Andersson 2021-06-24 19:47 ` [PATCH 8/9] arm64: dts: qcom: sc7280: Add Q6V5 MSS node Sibi Sankar 2021-06-28 18:39 ` Matthias Kaehlcke 2021-06-28 18:39 ` Matthias Kaehlcke 2021-06-30 20:03 ` Sibi Sankar 2021-07-30 18:01 ` Bjorn Andersson 2021-07-30 18:01 ` Bjorn Andersson 2021-06-24 19:47 ` [PATCH 9/9] arm64: dts: qcom: sc7280: Update " Sibi Sankar 2021-06-28 19:05 ` Matthias Kaehlcke 2021-06-28 19:05 ` Matthias Kaehlcke 2021-06-30 20:08 ` Sibi Sankar 2021-07-30 18:14 ` Bjorn Andersson 2021-07-30 18:14 ` Bjorn Andersson 2021-07-01 20:02 ` [PATCH 0/9] Add Modem support on SC7280 SoCs Pavel Machek 2021-07-01 20:02 ` Pavel Machek
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YNoQ1d1hUyIh/qxz@google.com \ --to=mka@chromium.org \ --cc=agross@kernel.org \ --cc=bjorn.andersson@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=dianders@chromium.org \ --cc=evgreen@chromium.org \ --cc=joro@8bytes.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-remoteproc@vger.kernel.org \ --cc=mathieu.poirier@linaro.org \ --cc=ohad@wizery.com \ --cc=p.zabel@pengutronix.de \ --cc=robh+dt@kernel.org \ --cc=robin.murphy@arm.com \ --cc=saiprakash.ranjan@codeaurora.org \ --cc=sibis@codeaurora.org \ --cc=swboyd@chromium.org \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.