From: Mike Rapoport <rppt@kernel.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Rob Herring <robh+dt@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Nicolas Pitre <nico@fluxnic.net>,
Ard Biesheuvel <ardb@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Nick Kossifidis <mick@ics.forth.gr>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Frank Rowand <frowand.list@gmail.com>,
Dave Young <dyoung@redhat.com>, Baoquan He <bhe@redhat.com>,
Vivek Goyal <vgoyal@redhat.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mips@vger.kernel.org, linux-riscv@lists.infradead.org,
kexec@lists.infradead.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/9] MIPS: Avoid future duplicate elf core header reservation
Date: Mon, 16 Aug 2021 08:52:12 +0300 [thread overview]
Message-ID: <YRn9DHlB/pdNPJyP@kernel.org> (raw)
In-Reply-To: <92b6718f5618d5469f67b48fbea189cca0c12f4b.1628670468.git.geert+renesas@glider.be>
Hi Geert,
On Wed, Aug 11, 2021 at 10:50:59AM +0200, Geert Uytterhoeven wrote:
> Prepare for early_init_fdt_scan_reserved_mem() reserving the memory
> occupied by an elf core header described in the device tree.
> As arch_mem_init() calls early_init_fdt_scan_reserved_mem() before
> mips_reserve_vmcore(), the latter needs to check if the memory has
> already been reserved before.
Doing memblock_reserve() for the same region is usually fine, did you
encounter any issues without this patch?
> Note that mips_reserve_vmcore() cannot just be removed, as not all MIPS
> systems use DT.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v5:
> - New.
> ---
> arch/mips/kernel/setup.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c
> index 23a140327a0bac1b..4693add05743d78b 100644
> --- a/arch/mips/kernel/setup.c
> +++ b/arch/mips/kernel/setup.c
> @@ -429,7 +429,8 @@ static void __init mips_reserve_vmcore(void)
> pr_info("Reserving %ldKB of memory at %ldKB for kdump\n",
> (unsigned long)elfcorehdr_size >> 10, (unsigned long)elfcorehdr_addr >> 10);
>
> - memblock_reserve(elfcorehdr_addr, elfcorehdr_size);
> + if (!memblock_is_region_reserved(elfcorehdr_addr, elfcorehdr_size)
> + memblock_reserve(elfcorehdr_addr, elfcorehdr_size);
> #endif
> }
>
> --
> 2.25.1
>
--
Sincerely yours,
Mike.
WARNING: multiple messages have this Message-ID (diff)
From: Mike Rapoport <rppt@kernel.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Rob Herring <robh+dt@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Nicolas Pitre <nico@fluxnic.net>,
Ard Biesheuvel <ardb@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Nick Kossifidis <mick@ics.forth.gr>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Frank Rowand <frowand.list@gmail.com>,
Dave Young <dyoung@redhat.com>, Baoquan He <bhe@redhat.com>,
Vivek Goyal <vgoyal@redhat.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mips@vger.kernel.org, linux-riscv@lists.infradead.org,
kexec@lists.infradead.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/9] MIPS: Avoid future duplicate elf core header reservation
Date: Mon, 16 Aug 2021 08:52:12 +0300 [thread overview]
Message-ID: <YRn9DHlB/pdNPJyP@kernel.org> (raw)
In-Reply-To: <92b6718f5618d5469f67b48fbea189cca0c12f4b.1628670468.git.geert+renesas@glider.be>
Hi Geert,
On Wed, Aug 11, 2021 at 10:50:59AM +0200, Geert Uytterhoeven wrote:
> Prepare for early_init_fdt_scan_reserved_mem() reserving the memory
> occupied by an elf core header described in the device tree.
> As arch_mem_init() calls early_init_fdt_scan_reserved_mem() before
> mips_reserve_vmcore(), the latter needs to check if the memory has
> already been reserved before.
Doing memblock_reserve() for the same region is usually fine, did you
encounter any issues without this patch?
> Note that mips_reserve_vmcore() cannot just be removed, as not all MIPS
> systems use DT.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v5:
> - New.
> ---
> arch/mips/kernel/setup.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c
> index 23a140327a0bac1b..4693add05743d78b 100644
> --- a/arch/mips/kernel/setup.c
> +++ b/arch/mips/kernel/setup.c
> @@ -429,7 +429,8 @@ static void __init mips_reserve_vmcore(void)
> pr_info("Reserving %ldKB of memory at %ldKB for kdump\n",
> (unsigned long)elfcorehdr_size >> 10, (unsigned long)elfcorehdr_addr >> 10);
>
> - memblock_reserve(elfcorehdr_addr, elfcorehdr_size);
> + if (!memblock_is_region_reserved(elfcorehdr_addr, elfcorehdr_size)
> + memblock_reserve(elfcorehdr_addr, elfcorehdr_size);
> #endif
> }
>
> --
> 2.25.1
>
--
Sincerely yours,
Mike.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Mike Rapoport <rppt@kernel.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Rob Herring <robh+dt@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Nicolas Pitre <nico@fluxnic.net>,
Ard Biesheuvel <ardb@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Nick Kossifidis <mick@ics.forth.gr>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Frank Rowand <frowand.list@gmail.com>,
Dave Young <dyoung@redhat.com>, Baoquan He <bhe@redhat.com>,
Vivek Goyal <vgoyal@redhat.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mips@vger.kernel.org, linux-riscv@lists.infradead.org,
kexec@lists.infradead.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/9] MIPS: Avoid future duplicate elf core header reservation
Date: Mon, 16 Aug 2021 08:52:12 +0300 [thread overview]
Message-ID: <YRn9DHlB/pdNPJyP@kernel.org> (raw)
In-Reply-To: <92b6718f5618d5469f67b48fbea189cca0c12f4b.1628670468.git.geert+renesas@glider.be>
Hi Geert,
On Wed, Aug 11, 2021 at 10:50:59AM +0200, Geert Uytterhoeven wrote:
> Prepare for early_init_fdt_scan_reserved_mem() reserving the memory
> occupied by an elf core header described in the device tree.
> As arch_mem_init() calls early_init_fdt_scan_reserved_mem() before
> mips_reserve_vmcore(), the latter needs to check if the memory has
> already been reserved before.
Doing memblock_reserve() for the same region is usually fine, did you
encounter any issues without this patch?
> Note that mips_reserve_vmcore() cannot just be removed, as not all MIPS
> systems use DT.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v5:
> - New.
> ---
> arch/mips/kernel/setup.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c
> index 23a140327a0bac1b..4693add05743d78b 100644
> --- a/arch/mips/kernel/setup.c
> +++ b/arch/mips/kernel/setup.c
> @@ -429,7 +429,8 @@ static void __init mips_reserve_vmcore(void)
> pr_info("Reserving %ldKB of memory at %ldKB for kdump\n",
> (unsigned long)elfcorehdr_size >> 10, (unsigned long)elfcorehdr_addr >> 10);
>
> - memblock_reserve(elfcorehdr_addr, elfcorehdr_size);
> + if (!memblock_is_region_reserved(elfcorehdr_addr, elfcorehdr_size)
> + memblock_reserve(elfcorehdr_addr, elfcorehdr_size);
> #endif
> }
>
> --
> 2.25.1
>
--
Sincerely yours,
Mike.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Mike Rapoport <rppt@kernel.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Rob Herring <robh+dt@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Nicolas Pitre <nico@fluxnic.net>,
Ard Biesheuvel <ardb@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Nick Kossifidis <mick@ics.forth.gr>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Frank Rowand <frowand.list@gmail.com>,
Dave Young <dyoung@redhat.com>, Baoquan He <bhe@redhat.com>,
Vivek Goyal <vgoyal@redhat.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mips@vger.kernel.org, linux-riscv@lists.infradead.org,
kexec@lists.infradead.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/9] MIPS: Avoid future duplicate elf core header reservation
Date: Mon, 16 Aug 2021 08:52:12 +0300 [thread overview]
Message-ID: <YRn9DHlB/pdNPJyP@kernel.org> (raw)
In-Reply-To: <92b6718f5618d5469f67b48fbea189cca0c12f4b.1628670468.git.geert+renesas@glider.be>
Hi Geert,
On Wed, Aug 11, 2021 at 10:50:59AM +0200, Geert Uytterhoeven wrote:
> Prepare for early_init_fdt_scan_reserved_mem() reserving the memory
> occupied by an elf core header described in the device tree.
> As arch_mem_init() calls early_init_fdt_scan_reserved_mem() before
> mips_reserve_vmcore(), the latter needs to check if the memory has
> already been reserved before.
Doing memblock_reserve() for the same region is usually fine, did you
encounter any issues without this patch?
> Note that mips_reserve_vmcore() cannot just be removed, as not all MIPS
> systems use DT.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v5:
> - New.
> ---
> arch/mips/kernel/setup.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c
> index 23a140327a0bac1b..4693add05743d78b 100644
> --- a/arch/mips/kernel/setup.c
> +++ b/arch/mips/kernel/setup.c
> @@ -429,7 +429,8 @@ static void __init mips_reserve_vmcore(void)
> pr_info("Reserving %ldKB of memory at %ldKB for kdump\n",
> (unsigned long)elfcorehdr_size >> 10, (unsigned long)elfcorehdr_addr >> 10);
>
> - memblock_reserve(elfcorehdr_addr, elfcorehdr_size);
> + if (!memblock_is_region_reserved(elfcorehdr_addr, elfcorehdr_size)
> + memblock_reserve(elfcorehdr_addr, elfcorehdr_size);
> #endif
> }
>
> --
> 2.25.1
>
--
Sincerely yours,
Mike.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2021-08-16 5:52 UTC|newest]
Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 8:50 [PATCH v5 0/9] Add generic support for kdump DT properties Geert Uytterhoeven
2021-08-11 8:50 ` Geert Uytterhoeven
2021-08-11 8:50 ` Geert Uytterhoeven
2021-08-11 8:50 ` Geert Uytterhoeven
2021-08-11 8:50 ` [PATCH v5 1/9] MIPS: Avoid future duplicate elf core header reservation Geert Uytterhoeven
2021-08-11 8:50 ` Geert Uytterhoeven
2021-08-11 8:50 ` Geert Uytterhoeven
2021-08-11 8:50 ` Geert Uytterhoeven
2021-08-11 14:02 ` kernel test robot
2021-08-11 15:35 ` Geert Uytterhoeven
2021-08-11 15:35 ` Geert Uytterhoeven
2021-08-11 15:35 ` Geert Uytterhoeven
2021-08-11 15:35 ` Geert Uytterhoeven
2021-08-16 5:52 ` Mike Rapoport [this message]
2021-08-16 5:52 ` Mike Rapoport
2021-08-16 5:52 ` Mike Rapoport
2021-08-16 5:52 ` Mike Rapoport
2021-08-23 10:17 ` Geert Uytterhoeven
2021-08-23 10:17 ` Geert Uytterhoeven
2021-08-23 10:17 ` Geert Uytterhoeven
2021-08-23 10:17 ` Geert Uytterhoeven
2021-08-23 13:09 ` Mike Rapoport
2021-08-23 13:09 ` Mike Rapoport
2021-08-23 13:09 ` Mike Rapoport
2021-08-23 13:09 ` Mike Rapoport
2021-08-23 14:44 ` Rob Herring
2021-08-23 14:44 ` Rob Herring
2021-08-23 14:44 ` Rob Herring
2021-08-23 14:44 ` Rob Herring
2021-08-23 15:20 ` Mike Rapoport
2021-08-23 15:20 ` Mike Rapoport
2021-08-23 15:20 ` Mike Rapoport
2021-08-23 15:20 ` Mike Rapoport
2021-08-11 8:51 ` [PATCH v5 2/9] crash_dump: Make elfcorehdr address/size symbols always visible Geert Uytterhoeven
2021-08-11 8:51 ` Geert Uytterhoeven
2021-08-11 8:51 ` Geert Uytterhoeven
2021-08-11 8:51 ` Geert Uytterhoeven
2021-08-11 8:51 ` [PATCH v5 3/9] of: fdt: Add generic support for handling elf core headers property Geert Uytterhoeven
2021-08-11 8:51 ` Geert Uytterhoeven
2021-08-11 8:51 ` Geert Uytterhoeven
2021-08-11 8:51 ` Geert Uytterhoeven
2021-08-11 20:46 ` kernel test robot
2021-08-12 8:16 ` Geert Uytterhoeven
2021-08-11 8:51 ` [PATCH v5 4/9] of: fdt: Add generic support for handling usable memory range property Geert Uytterhoeven
2021-08-11 8:51 ` Geert Uytterhoeven
2021-08-11 8:51 ` Geert Uytterhoeven
2021-08-11 8:51 ` Geert Uytterhoeven
2021-08-11 8:51 ` [PATCH v5 5/9] of: fdt: Use IS_ENABLED(CONFIG_BLK_DEV_INITRD) instead of #ifdef Geert Uytterhoeven
2021-08-11 8:51 ` Geert Uytterhoeven
2021-08-11 8:51 ` Geert Uytterhoeven
2021-08-11 8:51 ` Geert Uytterhoeven
2021-08-11 8:51 ` [PATCH v5 6/9] riscv: Remove non-standard linux,elfcorehdr handling Geert Uytterhoeven
2021-08-11 8:51 ` Geert Uytterhoeven
2021-08-11 8:51 ` Geert Uytterhoeven
2021-08-11 8:51 ` Geert Uytterhoeven
2021-08-11 8:51 ` [PATCH v5 7/9] arm64: kdump: Remove custom " Geert Uytterhoeven
2021-08-11 8:51 ` Geert Uytterhoeven
2021-08-11 8:51 ` Geert Uytterhoeven
2021-08-11 8:51 ` Geert Uytterhoeven
2021-08-23 12:55 ` Catalin Marinas
2021-08-23 12:55 ` Catalin Marinas
2021-08-23 12:55 ` Catalin Marinas
2021-08-23 12:55 ` Catalin Marinas
2021-08-11 8:51 ` [PATCH v5 8/9] arm64: kdump: Remove custom linux,usable-memory-range handling Geert Uytterhoeven
2021-08-11 8:51 ` [PATCH v5 8/9] arm64: kdump: Remove custom linux, usable-memory-range handling Geert Uytterhoeven
2021-08-11 8:51 ` Geert Uytterhoeven
2021-08-11 8:51 ` Geert Uytterhoeven
2021-08-23 12:55 ` [PATCH v5 8/9] arm64: kdump: Remove custom linux,usable-memory-range handling Catalin Marinas
2021-08-23 12:55 ` Catalin Marinas
2021-08-23 12:55 ` Catalin Marinas
2021-08-23 12:55 ` Catalin Marinas
2021-08-11 8:51 ` [PATCH v5 9/9] ARM: uncompress: Parse "linux,usable-memory-range" DT property Geert Uytterhoeven
2021-08-11 8:51 ` [PATCH v5 9/9] ARM: uncompress: Parse "linux, usable-memory-range" " Geert Uytterhoeven
2021-08-11 8:51 ` Geert Uytterhoeven
2021-08-11 8:51 ` Geert Uytterhoeven
2021-08-15 15:25 ` [PATCH v5 0/9] Add generic support for kdump DT properties Rob Herring
2021-08-15 15:25 ` Rob Herring
2021-08-15 15:25 ` Rob Herring
2021-08-15 15:25 ` Rob Herring
2021-08-23 10:13 ` Geert Uytterhoeven
2021-08-23 10:13 ` Geert Uytterhoeven
2021-08-23 10:13 ` Geert Uytterhoeven
2021-08-23 10:13 ` Geert Uytterhoeven
2021-08-23 14:52 ` Rob Herring
2021-08-23 14:52 ` Rob Herring
2021-08-23 14:52 ` Rob Herring
2021-08-23 14:52 ` Rob Herring
2021-08-24 11:55 ` Geert Uytterhoeven
2021-08-24 11:55 ` Geert Uytterhoeven
2021-08-24 11:55 ` Geert Uytterhoeven
2021-08-24 11:55 ` Geert Uytterhoeven
2021-08-24 22:43 ` Rob Herring
2021-08-24 22:43 ` Rob Herring
2021-08-24 22:43 ` Rob Herring
2021-08-24 22:43 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRn9DHlB/pdNPJyP@kernel.org \
--to=rppt@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=ardb@kernel.org \
--cc=bhe@redhat.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=dyoung@redhat.com \
--cc=frowand.list@gmail.com \
--cc=geert+renesas@glider.be \
--cc=kexec@lists.infradead.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=mick@ics.forth.gr \
--cc=nico@fluxnic.net \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=vgoyal@redhat.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.