From: Borislav Petkov <bp@alien8.de>
To: "Chatradhi, Naveen Krishna" <nchatrad@amd.com>,
platform-driver-x86@vger.kernel.org
Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
x86@kernel.org, linux@roeck-us.net, yazen.ghannam@amd.com,
mingo@redhat.com, nathan.fontenot@amd.com, lewis.carroll@amd.com,
Ingo Molnar <mingo@kernel.org>, Jean Delvare <jdelvare@suse.com>
Subject: Re: [PATCH 1/3] x86/amd_nb: Add support for HSMP mailbox access
Date: Fri, 10 Sep 2021 11:57:58 +0200 [thread overview]
Message-ID: <YTssJkXH/ATm9zaA@zn.tnic> (raw)
In-Reply-To: <ad2bbcad-857c-f39d-9bee-49cd8ad582b2@amd.com>
On Wed, Sep 08, 2021 at 10:41:20PM +0530, Chatradhi, Naveen Krishna wrote:
> In all the future server platforms, AMD's direction is the support HSMP
> interface, which exposes system management knobs.
I know you all think about the future only but there's the past too and
there's a bunch of AMD hardware out there which doesn't have that.
> > You could make it a separate driver module called amd_hsmp.ko which
> > loads only on the appropriate hw and uses amd_nb.c for detection only
> > like the other drivers, for example.
>
> How about, creating a module under drivers/platform/x86/ (lets say
> amd_hsmp.c) export an API from here and it can be extended to support all
> the knobs that does not fit in an existing frameworks (such as hwmon, etc)
> and provide a user space access.
>
> I can see similar references in the drivers/platform/x86/ directory.
That sounds ok to me too. There's also arch/x86/platform/, btw, and I
still have to find out what the difference is. :-)
Lemme add the platform drivers folks.
Thread begins at:
https://lkml.kernel.org/r/20210902174155.7365-1-nchatrad@amd.com
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
prev parent reply other threads:[~2021-09-10 9:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 17:41 [PATCH 1/3] x86/amd_nb: Add support for HSMP mailbox access Naveen Krishna Chatradhi
2021-09-02 17:41 ` [PATCH 2/3] k10temp: Remove residues of current and voltage Naveen Krishna Chatradhi
2021-09-02 19:15 ` Guenter Roeck
2021-09-02 17:41 ` [PATCH 3/3] k10temp: Add power sensor for family 19h Naveen Krishna Chatradhi
2021-09-02 19:26 ` Guenter Roeck
2021-09-02 17:58 ` [PATCH 1/3] x86/amd_nb: Add support for HSMP mailbox access Borislav Petkov
2021-09-08 17:11 ` Chatradhi, Naveen Krishna
2021-09-10 9:57 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTssJkXH/ATm9zaA@zn.tnic \
--to=bp@alien8.de \
--cc=jdelvare@suse.com \
--cc=lewis.carroll@amd.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=nathan.fontenot@amd.com \
--cc=nchatrad@amd.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=x86@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.