All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Chatradhi, Naveen Krishna" <nchatrad@amd.com>
To: Borislav Petkov <bp@alien8.de>
Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
	x86@kernel.org, linux@roeck-us.net, yazen.ghannam@amd.com,
	mingo@redhat.com, nathan.fontenot@amd.com, lewis.carroll@amd.com,
	Ingo Molnar <mingo@kernel.org>, Jean Delvare <jdelvare@suse.com>
Subject: Re: [PATCH 1/3] x86/amd_nb: Add support for HSMP mailbox access
Date: Wed, 8 Sep 2021 22:41:20 +0530	[thread overview]
Message-ID: <ad2bbcad-857c-f39d-9bee-49cd8ad582b2@amd.com> (raw)
In-Reply-To: <YTEQzIVfY/A1uy32@zn.tnic>

HI Boris,

On 9/2/2021 11:28 PM, Borislav Petkov wrote:
> [CAUTION: External Email]
>
> On Thu, Sep 02, 2021 at 11:11:53PM +0530, Naveen Krishna Chatradhi wrote:
>> On Fam19h server CPUs from AMD an HSMP (Host System Management Port)
>> mailbox interface is added to monitor and manage the CPU parameters.
> Mailbox? Hmm, that rings a bell. There's drivers/mailbox/ with a bunch
> of drivers in there. Those are
>
> "Mailbox is a framework to control hardware communication between
> on-chip processors through queued messages and interrupt driven
> signals."
>
> I wonder if that HSMP thing can be wrapped like a mailbox driver...

Sure, I will look into the mailbox framework.

>
> If not, I still don't like it being slapped in amd_nb.c where it would
> be built in on *all* AMD hardware which is kinda too much.

In all the future server platforms, AMD's direction is the support HSMP 
interface, which exposes system management knobs.

>
> You could make it a separate driver module called amd_hsmp.ko which
> loads only on the appropriate hw and uses amd_nb.c for detection only
> like the other drivers, for example.

How about, creating a module under drivers/platform/x86/ (lets say 
amd_hsmp.c) export an API from here and it can be extended to support 
all the knobs that does not fit in an existing frameworks (such as 
hwmon, etc) and provide a user space access.

I can see similar references in the drivers/platform/x86/ directory.

>
> --
> Regards/Gruss,
>      Boris.
>
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpeople.kernel.org%2Ftglx%2Fnotes-about-netiquette&amp;data=04%7C01%7CNaveenKrishna.Chatradhi%40amd.com%7C52aacf76c0d74c526ade08d96e3b3765%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637662022905004162%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=DYcj%2BcjedWpUaJYMl7yPDy%2BB%2FIe6YDucA00JcJtfLFk%3D&amp;reserved=0

  reply	other threads:[~2021-09-08 17:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-02 17:41 [PATCH 1/3] x86/amd_nb: Add support for HSMP mailbox access Naveen Krishna Chatradhi
2021-09-02 17:41 ` [PATCH 2/3] k10temp: Remove residues of current and voltage Naveen Krishna Chatradhi
2021-09-02 19:15   ` Guenter Roeck
2021-09-02 17:41 ` [PATCH 3/3] k10temp: Add power sensor for family 19h Naveen Krishna Chatradhi
2021-09-02 19:26   ` Guenter Roeck
2021-09-02 17:58 ` [PATCH 1/3] x86/amd_nb: Add support for HSMP mailbox access Borislav Petkov
2021-09-08 17:11   ` Chatradhi, Naveen Krishna [this message]
2021-09-10  9:57     ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ad2bbcad-857c-f39d-9bee-49cd8ad582b2@amd.com \
    --to=nchatrad@amd.com \
    --cc=bp@alien8.de \
    --cc=jdelvare@suse.com \
    --cc=lewis.carroll@amd.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mingo@kernel.org \
    --cc=mingo@redhat.com \
    --cc=nathan.fontenot@amd.com \
    --cc=x86@kernel.org \
    --cc=yazen.ghannam@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.