From: Rob Herring <robh@kernel.org>
To: Naveen Naidu <naveennaidu479@gmail.com>
Cc: bhelgaas@google.com,
linux-kernel-mentees@lists.linuxfoundation.org,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
"Pali Rohár" <pali@kernel.org>
Subject: Re: [PATCH v2 02/24] PCI: Set error response in config access defines when ops->read() fails
Date: Wed, 20 Oct 2021 08:41:30 -0500 [thread overview]
Message-ID: <YXAciic84q49qoZm@robh.at.kernel.org> (raw)
In-Reply-To: <b913b4966938b7cad8c049dc34093e6c4b2fae68.1634306198.git.naveennaidu479@gmail.com>
On Fri, Oct 15, 2021 at 07:58:17PM +0530, Naveen Naidu wrote:
> Make PCI_OP_READ and PCI_USER_READ_CONFIG set the data value with error
> response (~0), when the PCI device read by a host controller fails.
>
> This ensures that the controller drivers no longer need to fabricate
> (~0) value when they detect error. It also gurantees that the error
> response (~0) is always set when the controller drivers fails to read a
> config register from a device.
>
> This makes error response fabrication consistent and helps in removal of
> a lot of repeated code.
>
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Naveen Naidu <naveennaidu479@gmail.com>
> ---
> drivers/pci/access.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
Reviewed-by: Rob Herring <robh@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Naveen Naidu <naveennaidu479@gmail.com>
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org,
"Pali Rohár" <pali@kernel.org>,
linux-kernel-mentees@lists.linuxfoundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 02/24] PCI: Set error response in config access defines when ops->read() fails
Date: Wed, 20 Oct 2021 08:41:30 -0500 [thread overview]
Message-ID: <YXAciic84q49qoZm@robh.at.kernel.org> (raw)
In-Reply-To: <b913b4966938b7cad8c049dc34093e6c4b2fae68.1634306198.git.naveennaidu479@gmail.com>
On Fri, Oct 15, 2021 at 07:58:17PM +0530, Naveen Naidu wrote:
> Make PCI_OP_READ and PCI_USER_READ_CONFIG set the data value with error
> response (~0), when the PCI device read by a host controller fails.
>
> This ensures that the controller drivers no longer need to fabricate
> (~0) value when they detect error. It also gurantees that the error
> response (~0) is always set when the controller drivers fails to read a
> config register from a device.
>
> This makes error response fabrication consistent and helps in removal of
> a lot of repeated code.
>
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Naveen Naidu <naveennaidu479@gmail.com>
> ---
> drivers/pci/access.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
Reviewed-by: Rob Herring <robh@kernel.org>
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2021-10-20 13:41 UTC|newest]
Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 14:35 [PATCH v2 00/24] Unify PCI error response checking Naveen Naidu
2021-10-15 14:35 ` Naveen Naidu
2021-10-15 14:35 ` Naveen Naidu
2021-10-15 14:35 ` Naveen Naidu
2021-10-15 14:35 ` Naveen Naidu
2021-10-15 14:35 ` Naveen Naidu
2021-10-15 14:28 ` [PATCH v2 01/24] PCI: Add PCI_ERROR_RESPONSE and it's related definitions Naveen Naidu
2021-10-15 14:28 ` Naveen Naidu
2021-10-20 13:24 ` Rob Herring
2021-10-20 13:24 ` Rob Herring
2021-10-15 14:28 ` [PATCH v2 02/24] PCI: Set error response in config access defines when ops->read() fails Naveen Naidu
2021-10-15 14:28 ` Naveen Naidu
2021-10-20 13:41 ` Rob Herring [this message]
2021-10-20 13:41 ` Rob Herring
2021-10-20 13:52 ` Pali Rohár
2021-10-20 13:52 ` Pali Rohár
2021-10-20 15:13 ` Naveen Naidu
2021-10-20 15:13 ` Naveen Naidu
2021-10-15 14:38 ` [PATCH v2 03/24] PCI: Unify PCI error response checking Naveen Naidu
2021-10-15 14:38 ` Naveen Naidu
2021-10-20 13:13 ` Rob Herring
2021-10-20 13:13 ` Rob Herring
2021-10-20 15:15 ` Naveen Naidu
2021-10-20 15:15 ` Naveen Naidu
2021-10-15 14:38 ` [PATCH v2 04/24] PCI: Remove redundant error fabrication when device read fails Naveen Naidu
2021-10-15 14:38 ` Naveen Naidu
2021-10-20 13:42 ` Rob Herring
2021-10-20 13:42 ` Rob Herring
2021-10-15 14:38 ` [PATCH v2 05/24] PCI: thunder: " Naveen Naidu
2021-10-15 14:38 ` Naveen Naidu
2021-10-15 14:38 ` Naveen Naidu
2021-10-15 14:38 ` [PATCH v2 06/24] PCI: iproc: " Naveen Naidu
2021-10-15 14:38 ` Naveen Naidu
2021-10-15 14:38 ` Naveen Naidu
2021-10-15 16:49 ` Ray Jui
2021-10-15 16:49 ` Ray Jui
2021-10-15 16:49 ` Ray Jui via Linux-kernel-mentees
2021-10-15 17:05 ` Naveen Naidu
2021-10-15 17:05 ` Naveen Naidu
2021-10-15 17:05 ` Naveen Naidu
2021-10-15 14:38 ` [PATCH v2 07/24] PCI: mediatek: " Naveen Naidu
2021-10-15 14:38 ` Naveen Naidu
2021-10-15 14:38 ` Naveen Naidu
2021-10-15 14:38 ` Naveen Naidu
2021-10-15 14:38 ` [PATCH v2 08/24] PCI: exynos: " Naveen Naidu
2021-10-15 14:38 ` Naveen Naidu
2021-10-15 14:38 ` Naveen Naidu
2021-10-15 14:38 ` [PATCH v2 09/24] PCI: histb: " Naveen Naidu
2021-10-15 14:38 ` Naveen Naidu
2021-10-15 14:38 ` [PATCH v2 10/24] PCI: kirin: " Naveen Naidu
2021-10-15 14:38 ` Naveen Naidu
2021-10-15 14:38 ` [PATCH v2 11/24] PCI: aardvark: " Naveen Naidu
2021-10-15 14:38 ` Naveen Naidu
2021-10-15 14:38 ` Naveen Naidu
2021-10-15 14:38 ` [PATCH v2 12/24] PCI: mvebu: " Naveen Naidu
2021-10-15 14:38 ` Naveen Naidu
2021-10-15 14:38 ` Naveen Naidu
2021-10-15 14:38 ` [PATCH v2 13/24] PCI: altera: " Naveen Naidu
2021-10-15 14:38 ` Naveen Naidu
2021-10-15 14:38 ` [PATCH v2 14/24] PCI: rcar: " Naveen Naidu
2021-10-15 14:38 ` Naveen Naidu
2021-10-18 11:32 ` Geert Uytterhoeven
2021-10-18 11:32 ` Geert Uytterhoeven
2021-10-18 11:51 ` Naveen Naidu
2021-10-18 11:51 ` Naveen Naidu
2021-10-18 12:00 ` Geert Uytterhoeven
2021-10-18 12:00 ` Geert Uytterhoeven
2021-10-15 14:38 ` [PATCH v2 15/24] PCI: rockchip: " Naveen Naidu
2021-10-15 14:38 ` Naveen Naidu
2021-10-15 14:38 ` Naveen Naidu
2021-10-15 14:38 ` Naveen Naidu
2021-10-15 14:38 ` [PATCH v2 16/24] PCI/ERR: Use RESPONSE_IS_PCI_ERROR() to check read from hardware Naveen Naidu
2021-10-15 14:38 ` Naveen Naidu
2021-10-15 14:38 ` [PATCH v2 17/24] PCI: vmd: " Naveen Naidu
2021-10-15 14:38 ` Naveen Naidu
2021-10-15 14:52 ` Naveen Naidu
2021-10-15 14:52 ` Naveen Naidu
2021-10-15 14:38 ` [PATCH v2 18/24] PCI: pciehp: " Naveen Naidu
2021-10-15 14:38 ` Naveen Naidu
2021-10-15 15:15 ` Naveen Naidu
2021-10-15 15:15 ` Naveen Naidu
2021-10-15 14:39 ` [PATCH v2 19/24] PCI/DPC: " Naveen Naidu
2021-10-15 14:39 ` Naveen Naidu
2021-10-15 14:39 ` Naveen Naidu
2021-10-15 14:39 ` [PATCH v2 20/24] PCI/PME: " Naveen Naidu
2021-10-15 14:39 ` Naveen Naidu
2021-10-15 14:39 ` [PATCH v2 21/24] PCI: cpqphp: " Naveen Naidu
2021-10-15 14:39 ` Naveen Naidu
2021-10-15 14:39 ` [PATCH v2 22/24] PCI: keystone: Use PCI_ERROR_RESPONSE to specify hardware error Naveen Naidu
2021-10-15 14:39 ` Naveen Naidu
2021-10-15 14:39 ` [PATCH v2 23/24] PCI: hv: Use PCI_ERROR_RESPONSE to specify hardware read error Naveen Naidu
2021-10-15 14:39 ` Naveen Naidu
2021-10-15 14:39 ` [PATCH v2 24/24] PCI: xgene: Use PCI_ERROR_RESPONSE to specify hardware error Naveen Naidu
2021-10-15 14:39 ` Naveen Naidu
2021-10-15 14:39 ` Naveen Naidu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXAciic84q49qoZm@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=bhelgaas@google.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=naveennaidu479@gmail.com \
--cc=pali@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.