From: Vinod Koul <vkoul@kernel.org>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
steen.hegelund@microchip.com
Subject: Re: [PATCH] phy: Sparx5 Eth SerDes: Fix return value check in sparx5_serdes_probe()
Date: Mon, 25 Oct 2021 13:52:01 +0530 [thread overview]
Message-ID: <YXZpKXqn0iY4td2G@matsya> (raw)
In-Reply-To: <20210909072149.2934047-1-yangyingliang@huawei.com>
On 09-09-21, 15:21, Yang Yingliang wrote:
> In case of error, the function devm_ioremap() returns NULL
> pointer not ERR_PTR(). The IS_ERR() test in the return value
> check should be replaced with NULL test.
Applied, thanks
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
steen.hegelund@microchip.com
Subject: Re: [PATCH] phy: Sparx5 Eth SerDes: Fix return value check in sparx5_serdes_probe()
Date: Mon, 25 Oct 2021 13:52:01 +0530 [thread overview]
Message-ID: <YXZpKXqn0iY4td2G@matsya> (raw)
In-Reply-To: <20210909072149.2934047-1-yangyingliang@huawei.com>
On 09-09-21, 15:21, Yang Yingliang wrote:
> In case of error, the function devm_ioremap() returns NULL
> pointer not ERR_PTR(). The IS_ERR() test in the return value
> check should be replaced with NULL test.
Applied, thanks
--
~Vinod
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2021-10-25 8:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-09 7:21 [PATCH] phy: Sparx5 Eth SerDes: Fix return value check in sparx5_serdes_probe() Yang Yingliang
2021-09-09 7:21 ` Yang Yingliang
2021-10-25 8:22 ` Vinod Koul [this message]
2021-10-25 8:22 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXZpKXqn0iY4td2G@matsya \
--to=vkoul@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=steen.hegelund@microchip.com \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.