From: Sean Christopherson <seanjc@google.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, kvm <kvm@vger.kernel.org>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Joao Martins <joao.m.martins@oracle.com>,
"jmattson @ google . com" <jmattson@google.com>,
"wanpengli @ tencent . com" <wanpengli@tencent.com>,
"vkuznets @ redhat . com" <vkuznets@redhat.com>,
"mtosatti @ redhat . com" <mtosatti@redhat.com>,
"joro @ 8bytes . org" <joro@8bytes.org>,
karahmed@amazon.com, Marc Zyngier <maz@kernel.org>,
James Morse <james.morse@arm.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Huacai Chen <chenhuacai@kernel.org>,
Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Anup Patel <anup.patel@wdc.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
kvm-riscv@lists.infradead.org, linux-s390@vger.kernel.org
Subject: Re: [PATCH 6/7] KVM: powerpc: Use Makefile.kvm for common files
Date: Tue, 16 Nov 2021 18:43:53 +0000 [thread overview]
Message-ID: <YZP76Un0mip17E1K@google.com> (raw)
In-Reply-To: <20211116115051.119956-6-dwmw2@infradead.org>
On Tue, Nov 16, 2021, David Woodhouse wrote:
> From: David Woodhouse <dwmw@amazon.co.uk>
>
> It's all fairly baroque but in the end, I don't think there's any reason
> for $(KVM)/irqchip.o to have been handled differently, as they all end
> up in $(kvm-y) in the end anyway, regardless of whether they get there
> via $(common-objs-y) and the CPU-specific object lists.
>
> The generic Makefile.kvm uses HAVE_KVM_IRQCHIP for irqchip.o instead of
> HAVE_KVM_IRQ_ROUTING. That change is fine (and arguably correct) because
> they are both set together for KVM_MPIC, or neither is set.
Nope.
Symbol: HAVE_KVM_IRQCHIP [=y]
Type : bool
Defined at virt/kvm/Kconfig:7
Selected by [m]:
- KVM_XICS [=y] && VIRTUALIZATION [=y] && KVM_BOOK3S_64 [=m] && !KVM_MPIC [=n]
Selected by [n]:
- KVM_MPIC [=n] && VIRTUALIZATION [=y] && KVM [=y] && E500 [=n]
leads to this and a whole pile of other errors
arch/powerpc/kvm/../../../virt/kvm/irqchip.c: In function ‘kvm_irq_map_gsi’:
arch/powerpc/kvm/../../../virt/kvm/irqchip.c:31:35: error: invalid use of undefined type ‘struct kvm_irq_routing_table’
31 | if (irq_rt && gsi < irq_rt->nr_rt_entries) {
| ^~
Side topic, please don't post a new version/series in-reply-to a different series.
b4 also gets confused in this case, e.g. it tried to grab the original patch. b4
has also made me really lazy, heaven forbid I actually had to manually grab these
from mutt :-)
WARNING: multiple messages have this Message-ID (diff)
From: Sean Christopherson <seanjc@google.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Anup Patel <anup.patel@wdc.com>,
"wanpengli @ tencent . com" <wanpengli@tencent.com>,
kvm <kvm@vger.kernel.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Joao Martins <joao.m.martins@oracle.com>,
Will Deacon <will@kernel.org>,
kvmarm@lists.cs.columbia.edu, linux-s390@vger.kernel.org,
Michael Ellerman <mpe@ellerman.id.au>,
"joro @ 8bytes . org" <joro@8bytes.org>,
Huacai Chen <chenhuacai@kernel.org>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>,
karahmed@amazon.com, Catalin Marinas <catalin.marinas@arm.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
"jmattson @ google . com" <jmattson@google.com>,
"mtosatti @ redhat . com" <mtosatti@redhat.com>,
linux-mips@vger.kernel.org, kvm-riscv@lists.infradead.org,
Marc Zyngier <maz@kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>,
"vkuznets @ redhat . com" <vkuznets@redhat.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 6/7] KVM: powerpc: Use Makefile.kvm for common files
Date: Tue, 16 Nov 2021 18:43:53 +0000 [thread overview]
Message-ID: <YZP76Un0mip17E1K@google.com> (raw)
In-Reply-To: <20211116115051.119956-6-dwmw2@infradead.org>
On Tue, Nov 16, 2021, David Woodhouse wrote:
> From: David Woodhouse <dwmw@amazon.co.uk>
>
> It's all fairly baroque but in the end, I don't think there's any reason
> for $(KVM)/irqchip.o to have been handled differently, as they all end
> up in $(kvm-y) in the end anyway, regardless of whether they get there
> via $(common-objs-y) and the CPU-specific object lists.
>
> The generic Makefile.kvm uses HAVE_KVM_IRQCHIP for irqchip.o instead of
> HAVE_KVM_IRQ_ROUTING. That change is fine (and arguably correct) because
> they are both set together for KVM_MPIC, or neither is set.
Nope.
Symbol: HAVE_KVM_IRQCHIP [=y]
Type : bool
Defined at virt/kvm/Kconfig:7
Selected by [m]:
- KVM_XICS [=y] && VIRTUALIZATION [=y] && KVM_BOOK3S_64 [=m] && !KVM_MPIC [=n]
Selected by [n]:
- KVM_MPIC [=n] && VIRTUALIZATION [=y] && KVM [=y] && E500 [=n]
leads to this and a whole pile of other errors
arch/powerpc/kvm/../../../virt/kvm/irqchip.c: In function ‘kvm_irq_map_gsi’:
arch/powerpc/kvm/../../../virt/kvm/irqchip.c:31:35: error: invalid use of undefined type ‘struct kvm_irq_routing_table’
31 | if (irq_rt && gsi < irq_rt->nr_rt_entries) {
| ^~
Side topic, please don't post a new version/series in-reply-to a different series.
b4 also gets confused in this case, e.g. it tried to grab the original patch. b4
has also made me really lazy, heaven forbid I actually had to manually grab these
from mutt :-)
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: Sean Christopherson <seanjc@google.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Anup Patel <anup.patel@wdc.com>,
"wanpengli @ tencent . com" <wanpengli@tencent.com>,
kvm <kvm@vger.kernel.org>,
Joao Martins <joao.m.martins@oracle.com>,
Will Deacon <will@kernel.org>,
kvmarm@lists.cs.columbia.edu, linux-s390@vger.kernel.org,
"joro @ 8bytes . org" <joro@8bytes.org>,
Huacai Chen <chenhuacai@kernel.org>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>,
karahmed@amazon.com, Catalin Marinas <catalin.marinas@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
"jmattson @ google . com" <jmattson@google.com>,
"mtosatti @ redhat . com" <mtosatti@redhat.com>,
linux-mips@vger.kernel.org, James Morse <james.morse@arm.com>,
kvm-riscv@lists.infradead.org, Marc Zyngier <maz@kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>,
"vkuznets @ redhat . com" <vkuznets@redhat.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 6/7] KVM: powerpc: Use Makefile.kvm for common files
Date: Tue, 16 Nov 2021 18:43:53 +0000 [thread overview]
Message-ID: <YZP76Un0mip17E1K@google.com> (raw)
In-Reply-To: <20211116115051.119956-6-dwmw2@infradead.org>
On Tue, Nov 16, 2021, David Woodhouse wrote:
> From: David Woodhouse <dwmw@amazon.co.uk>
>
> It's all fairly baroque but in the end, I don't think there's any reason
> for $(KVM)/irqchip.o to have been handled differently, as they all end
> up in $(kvm-y) in the end anyway, regardless of whether they get there
> via $(common-objs-y) and the CPU-specific object lists.
>
> The generic Makefile.kvm uses HAVE_KVM_IRQCHIP for irqchip.o instead of
> HAVE_KVM_IRQ_ROUTING. That change is fine (and arguably correct) because
> they are both set together for KVM_MPIC, or neither is set.
Nope.
Symbol: HAVE_KVM_IRQCHIP [=y]
Type : bool
Defined at virt/kvm/Kconfig:7
Selected by [m]:
- KVM_XICS [=y] && VIRTUALIZATION [=y] && KVM_BOOK3S_64 [=m] && !KVM_MPIC [=n]
Selected by [n]:
- KVM_MPIC [=n] && VIRTUALIZATION [=y] && KVM [=y] && E500 [=n]
leads to this and a whole pile of other errors
arch/powerpc/kvm/../../../virt/kvm/irqchip.c: In function ‘kvm_irq_map_gsi’:
arch/powerpc/kvm/../../../virt/kvm/irqchip.c:31:35: error: invalid use of undefined type ‘struct kvm_irq_routing_table’
31 | if (irq_rt && gsi < irq_rt->nr_rt_entries) {
| ^~
Side topic, please don't post a new version/series in-reply-to a different series.
b4 also gets confused in this case, e.g. it tried to grab the original patch. b4
has also made me really lazy, heaven forbid I actually had to manually grab these
from mutt :-)
WARNING: multiple messages have this Message-ID (diff)
From: Sean Christopherson <seanjc@google.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, kvm <kvm@vger.kernel.org>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Joao Martins <joao.m.martins@oracle.com>,
"jmattson @ google . com" <jmattson@google.com>,
"wanpengli @ tencent . com" <wanpengli@tencent.com>,
"vkuznets @ redhat . com" <vkuznets@redhat.com>,
"mtosatti @ redhat . com" <mtosatti@redhat.com>,
"joro @ 8bytes . org" <joro@8bytes.org>,
karahmed@amazon.com, Marc Zyngier <maz@kernel.org>,
James Morse <james.morse@arm.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Huacai Chen <chenhuacai@kernel.org>,
Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Anup Patel <anup.patel@wdc.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
kvm-riscv@lists.infradead.org, linux-s390@vger.kernel.org
Subject: Re: [PATCH 6/7] KVM: powerpc: Use Makefile.kvm for common files
Date: Tue, 16 Nov 2021 18:43:53 +0000 [thread overview]
Message-ID: <YZP76Un0mip17E1K@google.com> (raw)
In-Reply-To: <20211116115051.119956-6-dwmw2@infradead.org>
On Tue, Nov 16, 2021, David Woodhouse wrote:
> From: David Woodhouse <dwmw@amazon.co.uk>
>
> It's all fairly baroque but in the end, I don't think there's any reason
> for $(KVM)/irqchip.o to have been handled differently, as they all end
> up in $(kvm-y) in the end anyway, regardless of whether they get there
> via $(common-objs-y) and the CPU-specific object lists.
>
> The generic Makefile.kvm uses HAVE_KVM_IRQCHIP for irqchip.o instead of
> HAVE_KVM_IRQ_ROUTING. That change is fine (and arguably correct) because
> they are both set together for KVM_MPIC, or neither is set.
Nope.
Symbol: HAVE_KVM_IRQCHIP [=y]
Type : bool
Defined at virt/kvm/Kconfig:7
Selected by [m]:
- KVM_XICS [=y] && VIRTUALIZATION [=y] && KVM_BOOK3S_64 [=m] && !KVM_MPIC [=n]
Selected by [n]:
- KVM_MPIC [=n] && VIRTUALIZATION [=y] && KVM [=y] && E500 [=n]
leads to this and a whole pile of other errors
arch/powerpc/kvm/../../../virt/kvm/irqchip.c: In function ‘kvm_irq_map_gsi’:
arch/powerpc/kvm/../../../virt/kvm/irqchip.c:31:35: error: invalid use of undefined type ‘struct kvm_irq_routing_table’
31 | if (irq_rt && gsi < irq_rt->nr_rt_entries) {
| ^~
Side topic, please don't post a new version/series in-reply-to a different series.
b4 also gets confused in this case, e.g. it tried to grab the original patch. b4
has also made me really lazy, heaven forbid I actually had to manually grab these
from mutt :-)
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-11-16 18:44 UTC|newest]
Thread overview: 103+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 14:09 [PATCH] KVM: x86: Fix recording of guest steal time / preempted status David Woodhouse
2021-11-02 16:38 ` [PATCH v2] " David Woodhouse
2021-11-02 17:01 ` Paolo Bonzini
2021-11-02 17:11 ` David Woodhouse
2021-11-02 17:19 ` Paolo Bonzini
2021-11-02 17:26 ` David Woodhouse
2021-11-02 17:36 ` [PATCH v3] " David Woodhouse
2021-11-11 13:23 ` Paolo Bonzini
2021-11-12 8:28 ` David Woodhouse
2021-11-12 9:31 ` Paolo Bonzini
2021-11-12 9:54 ` David Woodhouse
2021-11-12 10:49 ` Paolo Bonzini
2021-11-12 11:29 ` David Woodhouse
2021-11-12 12:27 ` Paolo Bonzini
2021-11-12 13:28 ` David Woodhouse
2021-11-12 14:56 ` Paolo Bonzini
2021-11-12 15:27 ` David Woodhouse
2021-11-15 16:47 ` [RFC PATCH 0/11] Rework gfn_to_pfn_cache David Woodhouse
2021-11-15 16:50 ` [PATCH 01/11] KVM: x86: Fix steal time asm constraints in 32-bit mode David Woodhouse
2021-11-15 16:50 ` [PATCH 02/11] KVM: x86/xen: Fix get_attr of KVM_XEN_ATTR_TYPE_SHARED_INFO David Woodhouse
2021-11-15 16:50 ` [PATCH 03/11] KVM: selftests: Add event channel upcall support to xen_shinfo_test David Woodhouse
2021-11-15 16:50 ` [PATCH 04/11] KVM: x86/xen: Use sizeof_field() instead of open-coding it David Woodhouse
2021-11-15 16:50 ` [PATCH 05/11] KVM: nVMX: Use kvm_{read,write}_guest_cached() for shadow_vmcs12 David Woodhouse
2021-11-15 16:50 ` [PATCH 06/11] KVM: nVMX: Use kvm_read_guest_offset_cached() for nested VMCS check David Woodhouse
2021-11-15 16:50 ` [PATCH 07/11] KVM: nVMX: Use a gfn_to_hva_cache for vmptrld David Woodhouse
2021-11-15 16:50 ` [PATCH 08/11] KVM: Kill kvm_map_gfn() / kvm_unmap_gfn() and gfn_to_pfn_cache David Woodhouse
2021-11-16 10:21 ` Paolo Bonzini
2021-11-17 17:18 ` David Woodhouse
2021-11-15 16:50 ` [PATCH 09/11] KVM: Reinstate gfn_to_pfn_cache with invalidation support David Woodhouse
2021-11-15 16:50 ` [PATCH 10/11] KVM: x86/xen: Maintain valid mapping of Xen shared_info page David Woodhouse
2021-11-15 16:50 ` [PATCH 11/11] KVM: x86/xen: Add KVM_IRQ_ROUTING_XEN_EVTCHN and event channel delivery David Woodhouse
2021-11-15 17:02 ` David Woodhouse
2021-11-15 18:49 ` Paolo Bonzini
2021-11-15 18:55 ` David Woodhouse
2021-11-15 18:50 ` [RFC PATCH 0/11] Rework gfn_to_pfn_cache Paolo Bonzini
2021-11-15 19:11 ` David Woodhouse
2021-11-15 19:26 ` Paolo Bonzini
2021-11-15 22:59 ` Sean Christopherson
2021-11-15 23:22 ` David Woodhouse
2021-11-16 13:17 ` David Woodhouse
2021-11-16 14:11 ` Paolo Bonzini
2021-11-16 14:25 ` David Woodhouse
2021-11-16 14:57 ` Paolo Bonzini
2021-11-16 15:09 ` David Woodhouse
2021-11-16 15:49 ` Paolo Bonzini
2021-11-16 16:06 ` David Woodhouse
2021-11-16 17:42 ` Paolo Bonzini
2021-11-16 17:57 ` David Woodhouse
2021-11-16 18:46 ` Paolo Bonzini
2021-11-16 19:34 ` David Woodhouse
2021-11-15 23:24 ` David Woodhouse
2021-11-16 11:50 ` [PATCH 0/7] KVM: Add Makefile.kvm for common files David Woodhouse
2021-11-16 11:50 ` David Woodhouse
2021-11-16 11:50 ` David Woodhouse
2021-11-16 11:50 ` David Woodhouse
2021-11-16 11:50 ` [PATCH 1/7] KVM: Introduce CONFIG_HAVE_KVM_DIRTY_RING David Woodhouse
2021-11-16 11:50 ` David Woodhouse
2021-11-16 11:50 ` David Woodhouse
2021-11-16 11:50 ` David Woodhouse
2021-11-16 11:50 ` [PATCH 2/7] KVM: Add Makefile.kvm for common files, use it for x86 David Woodhouse
2021-11-16 11:50 ` David Woodhouse
2021-11-16 11:50 ` David Woodhouse
2021-11-16 11:50 ` David Woodhouse
2021-11-16 11:50 ` [PATCH 3/7] KVM: s390: Use Makefile.kvm for common files David Woodhouse
2021-11-16 11:50 ` David Woodhouse
2021-11-16 11:50 ` David Woodhouse
2021-11-16 11:50 ` David Woodhouse
2021-11-17 7:29 ` Christian Borntraeger
2021-11-17 7:29 ` Christian Borntraeger
2021-11-17 7:29 ` Christian Borntraeger
2021-11-17 7:29 ` Christian Borntraeger
2021-11-16 11:50 ` [PATCH 4/7] KVM: mips: " David Woodhouse
2021-11-16 11:50 ` David Woodhouse
2021-11-16 11:50 ` David Woodhouse
2021-11-16 11:50 ` David Woodhouse
2021-11-16 11:50 ` [PATCH 5/7] KVM: RISC-V: " David Woodhouse
2021-11-16 11:50 ` David Woodhouse
2021-11-16 11:50 ` David Woodhouse
2021-11-16 11:50 ` David Woodhouse
2021-11-16 11:50 ` [PATCH 6/7] KVM: powerpc: " David Woodhouse
2021-11-16 11:50 ` David Woodhouse
2021-11-16 11:50 ` David Woodhouse
2021-11-16 11:50 ` David Woodhouse
2021-11-16 18:43 ` Sean Christopherson [this message]
2021-11-16 18:43 ` Sean Christopherson
2021-11-16 18:43 ` Sean Christopherson
2021-11-16 18:43 ` Sean Christopherson
2021-11-16 19:13 ` David Woodhouse
2021-11-16 19:13 ` David Woodhouse
2021-11-16 19:13 ` David Woodhouse
2021-11-16 19:13 ` David Woodhouse
2021-11-16 11:50 ` [PATCH 7/7] KVM: arm64: " David Woodhouse
2021-11-16 11:50 ` David Woodhouse
2021-11-16 11:50 ` David Woodhouse
2021-11-16 11:50 ` David Woodhouse
2021-11-15 21:38 ` [RFC PATCH 0/11] Rework gfn_to_pfn_cache David Woodhouse
2021-11-12 19:44 ` [PATCH v3] KVM: x86: Fix recording of guest steal time / preempted status David Woodhouse
2021-11-03 9:47 ` [PATCH v2] " David Woodhouse
2021-11-03 12:35 ` Paolo Bonzini
2021-11-03 12:56 ` David Woodhouse
2021-11-03 13:05 ` Paolo Bonzini
2021-11-03 13:23 ` David Woodhouse
2021-11-03 13:34 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZP76Un0mip17E1K@google.com \
--to=seanjc@google.com \
--cc=aleksandar.qemu.devel@gmail.com \
--cc=alexandru.elisei@arm.com \
--cc=anup.patel@wdc.com \
--cc=benh@kernel.crashing.org \
--cc=boris.ostrovsky@oracle.com \
--cc=borntraeger@de.ibm.com \
--cc=catalin.marinas@arm.com \
--cc=chenhuacai@kernel.org \
--cc=dwmw2@infradead.org \
--cc=james.morse@arm.com \
--cc=jmattson@google.com \
--cc=joao.m.martins@oracle.com \
--cc=joro@8bytes.org \
--cc=karahmed@amazon.com \
--cc=kvm-riscv@lists.infradead.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maz@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=suzuki.poulose@arm.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.