From: Jaegeuk Kim <jaegeuk@kernel.org> To: Eric Biggers <ebiggers@kernel.org> Cc: Chao Yu <chao@kernel.org>, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH 5/6] f2fs: implement iomap operations Date: Thu, 2 Dec 2021 10:57:53 -0800 [thread overview] Message-ID: <YakXMV0UvBV7TVwe@google.com> (raw) In-Reply-To: <YakPrVPz5+qQm3kQ@sol.localdomain> On 12/02, Eric Biggers wrote: > On Thu, Dec 02, 2021 at 10:04:11PM +0800, Chao Yu wrote: > > On 2021/12/2 12:15, Eric Biggers wrote: > > > On Thu, Dec 02, 2021 at 11:10:41AM +0800, Chao Yu wrote: > > > > Why not relocating this check before f2fs_map_blocks()? > > > > Wait, it supports DIO in multi-device image after commit 71f2c8206202 > > ("f2fs: multidevice: support direct IO"), how about > > checking with f2fs_allow_multi_device_dio()? > > > > Thanks, > > > > Okay, that was not the case when I sent this patch originally. We'll need to > update this to support multiple devices. Chao/Eric, does this make sense? --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@ -4070,11 +4070,10 @@ static int f2fs_iomap_begin(struct inode *inode, loff_t offset, loff_t length, } if (WARN_ON_ONCE(!__is_valid_data_blkaddr(map.m_pblk))) return -EINVAL; - iomap->addr = blks_to_bytes(inode, map.m_pblk); - if (WARN_ON_ONCE(f2fs_is_multi_device(F2FS_I_SB(inode)))) - return -EINVAL; - iomap->bdev = inode->i_sb->s_bdev; + iomap->bdev = map->m_multidev_dio ? map.m_bdev : + inode->i_sb->s_bdev; + iomap->addr = blks_to_bytes(inode, map.m_pblk); } else { iomap->length = blks_to_bytes(inode, next_pgofs) - iomap->offset; > > - Eric
WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim <jaegeuk@kernel.org> To: Eric Biggers <ebiggers@kernel.org> Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH 5/6] f2fs: implement iomap operations Date: Thu, 2 Dec 2021 10:57:53 -0800 [thread overview] Message-ID: <YakXMV0UvBV7TVwe@google.com> (raw) In-Reply-To: <YakPrVPz5+qQm3kQ@sol.localdomain> On 12/02, Eric Biggers wrote: > On Thu, Dec 02, 2021 at 10:04:11PM +0800, Chao Yu wrote: > > On 2021/12/2 12:15, Eric Biggers wrote: > > > On Thu, Dec 02, 2021 at 11:10:41AM +0800, Chao Yu wrote: > > > > Why not relocating this check before f2fs_map_blocks()? > > > > Wait, it supports DIO in multi-device image after commit 71f2c8206202 > > ("f2fs: multidevice: support direct IO"), how about > > checking with f2fs_allow_multi_device_dio()? > > > > Thanks, > > > > Okay, that was not the case when I sent this patch originally. We'll need to > update this to support multiple devices. Chao/Eric, does this make sense? --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@ -4070,11 +4070,10 @@ static int f2fs_iomap_begin(struct inode *inode, loff_t offset, loff_t length, } if (WARN_ON_ONCE(!__is_valid_data_blkaddr(map.m_pblk))) return -EINVAL; - iomap->addr = blks_to_bytes(inode, map.m_pblk); - if (WARN_ON_ONCE(f2fs_is_multi_device(F2FS_I_SB(inode)))) - return -EINVAL; - iomap->bdev = inode->i_sb->s_bdev; + iomap->bdev = map->m_multidev_dio ? map.m_bdev : + inode->i_sb->s_bdev; + iomap->addr = blks_to_bytes(inode, map.m_pblk); } else { iomap->length = blks_to_bytes(inode, next_pgofs) - iomap->offset; > > - Eric _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2021-12-02 18:58 UTC|newest] Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-16 21:45 [PATCH 1/6] f2fs: rework write preallocations Jaegeuk Kim 2021-11-16 21:45 ` [f2fs-dev] " Jaegeuk Kim 2021-11-16 21:45 ` [PATCH 2/6] f2fs: do not expose unwritten blocks to user by DIO Jaegeuk Kim 2021-11-16 21:45 ` [f2fs-dev] " Jaegeuk Kim 2021-11-17 15:16 ` Chao Yu 2021-11-17 15:16 ` Chao Yu 2021-11-17 19:32 ` Jaegeuk Kim 2021-11-17 19:32 ` Jaegeuk Kim 2021-11-23 6:59 ` [f2fs] e029ce2460: aim7.jobs-per-min -35.8% regression kernel test robot 2021-11-23 6:59 ` kernel test robot 2021-12-02 2:39 ` [f2fs-dev] [PATCH 2/6] f2fs: do not expose unwritten blocks to user by DIO Chao Yu 2021-12-02 2:39 ` Chao Yu 2021-12-02 18:13 ` Jaegeuk Kim 2021-12-02 18:13 ` Jaegeuk Kim 2021-12-03 6:43 ` Chao Yu 2021-12-03 6:43 ` Chao Yu 2021-12-03 22:53 ` Jaegeuk Kim 2021-12-03 22:53 ` Jaegeuk Kim 2021-12-04 19:01 ` [f2fs-dev] [PATCH 2/6 v2] " Jaegeuk Kim 2021-12-04 19:01 ` Jaegeuk Kim 2021-11-16 21:45 ` [PATCH 3/6] f2fs: reduce indentation in f2fs_file_write_iter() Jaegeuk Kim 2021-11-16 21:45 ` [f2fs-dev] " Jaegeuk Kim 2021-12-02 2:58 ` Chao Yu 2021-12-02 2:58 ` Chao Yu 2021-11-16 21:45 ` [PATCH 4/6] f2fs: fix the f2fs_file_write_iter tracepoint Jaegeuk Kim 2021-11-16 21:45 ` [f2fs-dev] " Jaegeuk Kim 2021-12-02 2:59 ` Chao Yu 2021-12-02 2:59 ` Chao Yu 2021-11-16 21:45 ` [PATCH 5/6] f2fs: implement iomap operations Jaegeuk Kim 2021-11-16 21:45 ` [f2fs-dev] " Jaegeuk Kim 2021-12-02 3:10 ` Chao Yu 2021-12-02 3:10 ` Chao Yu 2021-12-02 4:15 ` Eric Biggers 2021-12-02 4:15 ` Eric Biggers 2021-12-02 14:04 ` Chao Yu 2021-12-02 14:04 ` Chao Yu 2021-12-02 18:25 ` Eric Biggers 2021-12-02 18:25 ` Eric Biggers 2021-12-02 18:57 ` Jaegeuk Kim [this message] 2021-12-02 18:57 ` Jaegeuk Kim 2021-12-02 19:00 ` Jaegeuk Kim 2021-12-02 19:00 ` Jaegeuk Kim 2021-12-02 20:57 ` Eric Biggers 2021-12-02 20:57 ` Eric Biggers 2021-12-02 21:19 ` Jaegeuk Kim 2021-12-02 21:19 ` Jaegeuk Kim 2021-12-02 21:28 ` Jaegeuk Kim 2021-12-02 21:28 ` Jaegeuk Kim 2021-12-03 6:51 ` Chao Yu 2021-12-03 6:51 ` Chao Yu 2021-12-30 6:43 ` Chao Yu 2021-12-30 6:43 ` Chao Yu 2022-01-04 21:15 ` Jaegeuk Kim 2022-01-04 21:15 ` Jaegeuk Kim 2021-11-16 21:45 ` [PATCH 6/6] f2fs: use iomap for direct I/O Jaegeuk Kim 2021-11-16 21:45 ` [f2fs-dev] " Jaegeuk Kim 2021-12-10 23:58 ` Jaegeuk Kim 2021-12-10 23:58 ` [f2fs-dev] " Jaegeuk Kim 2021-11-17 13:31 ` [f2fs-dev] [PATCH 1/6] f2fs: rework write preallocations Chao Yu 2021-11-17 13:31 ` Chao Yu 2021-11-17 19:27 ` Jaegeuk Kim 2021-11-17 19:27 ` Jaegeuk Kim 2021-11-18 6:47 ` Chao Yu 2021-11-18 6:47 ` Chao Yu 2022-01-04 21:24 Jaegeuk Kim 2022-01-04 21:24 ` [f2fs-dev] [PATCH 5/6] f2fs: implement iomap operations Jaegeuk Kim 2022-01-05 13:20 ` Chao Yu 2022-01-05 13:20 ` Chao Yu 2022-01-05 18:25 ` Jaegeuk Kim 2022-01-05 18:25 ` Jaegeuk Kim
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YakXMV0UvBV7TVwe@google.com \ --to=jaegeuk@kernel.org \ --cc=chao@kernel.org \ --cc=ebiggers@kernel.org \ --cc=linux-f2fs-devel@lists.sourceforge.net \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.