From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Ulrich Hecht <ulrich.hecht+renesas@gmail.com>,
Koji Matsuoka <koji.matsuoka.xm@renesas.com>,
Arnd Bergmann <arnd@arndb.de>, LUU HOAI <hoai.luu.ub@renesas.com>,
dri-devel@lists.freedesktop.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 3/3] drm: rcar-du: DRM_RCAR_MIPI_DSI should depend on ARCH_RENESAS
Date: Wed, 15 Dec 2021 12:29:18 +0200 [thread overview]
Message-ID: <YbnDfvfoP00XzZT1@pendragon.ideasonboard.com> (raw)
In-Reply-To: <YbnCldnKD7OK/jHi@pendragon.ideasonboard.com>
On Wed, Dec 15, 2021 at 12:25:26PM +0200, Laurent Pinchart wrote:
> Hi Geert,
>
> Thank you for the patch.
>
> On Wed, Dec 15, 2021 at 10:27:47AM +0100, Geert Uytterhoeven wrote:
> > The Renesas R-Car Display Unit embedded MIPI DSI encoder is only present
> > on Renesas R-Car V3U SoCs. Hence add a dependency on ARCH_RENESAS, to
> > prevent asking the user about this driver when configuring a kernel
> > without Renesas SoC support.
> >
> > Fixes: 155358310f013c23 ("drm: rcar-du: Add R-Car DSI driver")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> > drivers/gpu/drm/rcar-du/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/rcar-du/Kconfig b/drivers/gpu/drm/rcar-du/Kconfig
> > index a7aa556e301d1087..2f4f6ac5fd4e66b1 100644
> > --- a/drivers/gpu/drm/rcar-du/Kconfig
> > +++ b/drivers/gpu/drm/rcar-du/Kconfig
> > @@ -48,6 +48,7 @@ config DRM_RCAR_LVDS
> > config DRM_RCAR_MIPI_DSI
> > tristate "R-Car DU MIPI DSI Encoder Support"
> > depends on DRM && DRM_BRIDGE && OF
> > + depends on ARCH_RENESAS || COMPILE_TEST
>
> Same as for 1/3, let's move this entry first. I can handle this when
> applying the patches, I'll take 1/3 and 3/3 in my tree already.
Actually, if we wrap all subdrivers in 'if DRM_RCAR_DU', we won't need
1/3 and 3/3. Let's reach a conclusion on that topic first.
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> > select DRM_MIPI_DSI
> > help
> > Enable support for the R-Car Display Unit embedded MIPI DSI encoders.
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Arnd Bergmann <arnd@arndb.de>, David Airlie <airlied@linux.ie>,
Koji Matsuoka <koji.matsuoka.xm@renesas.com>,
dri-devel@lists.freedesktop.org,
linux-renesas-soc@vger.kernel.org,
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
Ulrich Hecht <ulrich.hecht+renesas@gmail.com>,
LUU HOAI <hoai.luu.ub@renesas.com>
Subject: Re: [PATCH 3/3] drm: rcar-du: DRM_RCAR_MIPI_DSI should depend on ARCH_RENESAS
Date: Wed, 15 Dec 2021 12:29:18 +0200 [thread overview]
Message-ID: <YbnDfvfoP00XzZT1@pendragon.ideasonboard.com> (raw)
In-Reply-To: <YbnCldnKD7OK/jHi@pendragon.ideasonboard.com>
On Wed, Dec 15, 2021 at 12:25:26PM +0200, Laurent Pinchart wrote:
> Hi Geert,
>
> Thank you for the patch.
>
> On Wed, Dec 15, 2021 at 10:27:47AM +0100, Geert Uytterhoeven wrote:
> > The Renesas R-Car Display Unit embedded MIPI DSI encoder is only present
> > on Renesas R-Car V3U SoCs. Hence add a dependency on ARCH_RENESAS, to
> > prevent asking the user about this driver when configuring a kernel
> > without Renesas SoC support.
> >
> > Fixes: 155358310f013c23 ("drm: rcar-du: Add R-Car DSI driver")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> > drivers/gpu/drm/rcar-du/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/rcar-du/Kconfig b/drivers/gpu/drm/rcar-du/Kconfig
> > index a7aa556e301d1087..2f4f6ac5fd4e66b1 100644
> > --- a/drivers/gpu/drm/rcar-du/Kconfig
> > +++ b/drivers/gpu/drm/rcar-du/Kconfig
> > @@ -48,6 +48,7 @@ config DRM_RCAR_LVDS
> > config DRM_RCAR_MIPI_DSI
> > tristate "R-Car DU MIPI DSI Encoder Support"
> > depends on DRM && DRM_BRIDGE && OF
> > + depends on ARCH_RENESAS || COMPILE_TEST
>
> Same as for 1/3, let's move this entry first. I can handle this when
> applying the patches, I'll take 1/3 and 3/3 in my tree already.
Actually, if we wrap all subdrivers in 'if DRM_RCAR_DU', we won't need
1/3 and 3/3. Let's reach a conclusion on that topic first.
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> > select DRM_MIPI_DSI
> > help
> > Enable support for the R-Car Display Unit embedded MIPI DSI encoders.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2021-12-15 10:29 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 9:27 [PATCH 0/3] drm: rcar-du: Add missing dependencies Geert Uytterhoeven
2021-12-15 9:27 ` Geert Uytterhoeven
2021-12-15 9:27 ` [PATCH 1/3] drm: rcar-du: DRM_RCAR_DW_HDMI should depend on ARCH_RENESAS Geert Uytterhoeven
2021-12-15 9:27 ` Geert Uytterhoeven
2021-12-15 10:24 ` Laurent Pinchart
2021-12-15 10:24 ` Laurent Pinchart
2021-12-15 10:48 ` Geert Uytterhoeven
2021-12-15 10:48 ` Geert Uytterhoeven
2021-12-15 9:27 ` [PATCH 2/3] drm: rcar-du: DRM_RCAR_USE_LVDS should depend on DRM_RCAR_DU Geert Uytterhoeven
2021-12-15 9:27 ` Geert Uytterhoeven
2021-12-15 10:12 ` Laurent Pinchart
2021-12-15 10:12 ` Laurent Pinchart
2021-12-15 10:17 ` Geert Uytterhoeven
2021-12-15 10:17 ` Geert Uytterhoeven
2021-12-15 10:23 ` Laurent Pinchart
2021-12-15 10:23 ` Laurent Pinchart
2021-12-15 10:30 ` Laurent Pinchart
2021-12-15 10:30 ` Laurent Pinchart
2021-12-15 10:47 ` Geert Uytterhoeven
2021-12-15 10:47 ` Geert Uytterhoeven
2021-12-15 11:02 ` Laurent Pinchart
2021-12-15 11:02 ` Laurent Pinchart
2021-12-15 13:34 ` Geert Uytterhoeven
2021-12-15 13:34 ` Geert Uytterhoeven
2021-12-15 9:27 ` [PATCH 3/3] drm: rcar-du: DRM_RCAR_MIPI_DSI should depend on ARCH_RENESAS Geert Uytterhoeven
2021-12-15 9:27 ` Geert Uytterhoeven
2021-12-15 10:25 ` Laurent Pinchart
2021-12-15 10:25 ` Laurent Pinchart
2021-12-15 10:29 ` Laurent Pinchart [this message]
2021-12-15 10:29 ` Laurent Pinchart
2021-12-15 9:42 ` [PATCH 0/3] drm: rcar-du: Add missing dependencies Laurent Pinchart
2021-12-15 9:42 ` Laurent Pinchart
2021-12-15 10:12 ` Geert Uytterhoeven
2021-12-15 10:12 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbnDfvfoP00XzZT1@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=airlied@linux.ie \
--cc=arnd@arndb.de \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert+renesas@glider.be \
--cc=hoai.luu.ub@renesas.com \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=koji.matsuoka.xm@renesas.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=ulrich.hecht+renesas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.