From: Mark Brown <broonie@kernel.org>
To: Shengjiu Wang <shengjiu.wang@nxp.com>
Cc: timur@kernel.org, nicoleotsuka@gmail.com, Xiubo.Lee@gmail.com,
festevam@gmail.com, perex@perex.cz, tiwai@suse.com,
alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] ASoC: imx-card: Need special setting for ak4497 on i.MX8MQ
Date: Tue, 4 Jan 2022 18:06:54 +0000 [thread overview]
Message-ID: <YdSMvtXHsYWl7E0U@sirena.org.uk> (raw)
In-Reply-To: <1641292835-19085-2-git-send-email-shengjiu.wang@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 568 bytes --]
On Tue, Jan 04, 2022 at 06:40:33PM +0800, Shengjiu Wang wrote:
> /* sai may support mclk/bclk = 1 */
> - if (of_find_property(np, "fsl,mclk-equal-bclk", NULL))
> + if (of_find_property(np, "fsl,mclk-equal-bclk", NULL)) {
> link_data->one2one_ratio = true;
> + } else {
> + int i;
> +
> + /*
> + * i.MX8MQ don't support one2one ratio, then
> + * with ak4497 only 16bit case is supported.
> + */
> + for (i = 0; i < ARRAY_SIZE(ak4497_fs_mul); i++) {
Shouldn't this be keyed off checking that we are actually running with
an ak4497?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Shengjiu Wang <shengjiu.wang@nxp.com>
Cc: alsa-devel@alsa-project.org, timur@kernel.org,
Xiubo.Lee@gmail.com, linuxppc-dev@lists.ozlabs.org,
tiwai@suse.com, nicoleotsuka@gmail.com, festevam@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] ASoC: imx-card: Need special setting for ak4497 on i.MX8MQ
Date: Tue, 4 Jan 2022 18:06:54 +0000 [thread overview]
Message-ID: <YdSMvtXHsYWl7E0U@sirena.org.uk> (raw)
In-Reply-To: <1641292835-19085-2-git-send-email-shengjiu.wang@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 568 bytes --]
On Tue, Jan 04, 2022 at 06:40:33PM +0800, Shengjiu Wang wrote:
> /* sai may support mclk/bclk = 1 */
> - if (of_find_property(np, "fsl,mclk-equal-bclk", NULL))
> + if (of_find_property(np, "fsl,mclk-equal-bclk", NULL)) {
> link_data->one2one_ratio = true;
> + } else {
> + int i;
> +
> + /*
> + * i.MX8MQ don't support one2one ratio, then
> + * with ak4497 only 16bit case is supported.
> + */
> + for (i = 0; i < ARRAY_SIZE(ak4497_fs_mul); i++) {
Shouldn't this be keyed off checking that we are actually running with
an ak4497?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Shengjiu Wang <shengjiu.wang@nxp.com>
Cc: alsa-devel@alsa-project.org, timur@kernel.org,
Xiubo.Lee@gmail.com, linuxppc-dev@lists.ozlabs.org,
tiwai@suse.com, perex@perex.cz, nicoleotsuka@gmail.com,
festevam@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] ASoC: imx-card: Need special setting for ak4497 on i.MX8MQ
Date: Tue, 4 Jan 2022 18:06:54 +0000 [thread overview]
Message-ID: <YdSMvtXHsYWl7E0U@sirena.org.uk> (raw)
In-Reply-To: <1641292835-19085-2-git-send-email-shengjiu.wang@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 568 bytes --]
On Tue, Jan 04, 2022 at 06:40:33PM +0800, Shengjiu Wang wrote:
> /* sai may support mclk/bclk = 1 */
> - if (of_find_property(np, "fsl,mclk-equal-bclk", NULL))
> + if (of_find_property(np, "fsl,mclk-equal-bclk", NULL)) {
> link_data->one2one_ratio = true;
> + } else {
> + int i;
> +
> + /*
> + * i.MX8MQ don't support one2one ratio, then
> + * with ak4497 only 16bit case is supported.
> + */
> + for (i = 0; i < ARRAY_SIZE(ak4497_fs_mul); i++) {
Shouldn't this be keyed off checking that we are actually running with
an ak4497?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-01-04 18:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-04 10:40 [PATCH 0/3] ASoC: imx-card: several improvement and fixes Shengjiu Wang
2022-01-04 10:40 ` [PATCH 1/3] ASoC: imx-card: Need special setting for ak4497 on i.MX8MQ Shengjiu Wang
2022-01-04 18:06 ` Mark Brown [this message]
2022-01-04 18:06 ` Mark Brown
2022-01-04 18:06 ` Mark Brown
2022-01-04 10:40 ` [PATCH 2/3] ASoC: imx-card: Fix mclk calculation issue for akcodec Shengjiu Wang
2022-01-04 10:40 ` [PATCH 3/3] ASoC: imx-card: improve the sound quality for low rate Shengjiu Wang
2022-01-06 20:28 ` [PATCH 0/3] ASoC: imx-card: several improvement and fixes Mark Brown
2022-01-06 20:28 ` Mark Brown
2022-01-05 9:02 [PATCH 1/3] ASoC: imx-card: Need special setting for ak4497 on i.MX8MQ S.J. Wang
2022-01-05 9:02 ` S.J. Wang
2022-01-05 9:02 ` S.J. Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdSMvtXHsYWl7E0U@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=festevam@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=perex@perex.cz \
--cc=shengjiu.wang@nxp.com \
--cc=timur@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.