From: "Theodore Ts'o" <tytso@mit.edu>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: John Hubbard <jhubbard@nvidia.com>,
Lee Jones <lee.jones@linaro.org>,
linux-ext4@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Dave Chinner <dchinner@redhat.com>,
Goldwyn Rodrigues <rgoldwyn@suse.com>,
"Darrick J . Wong" <darrick.wong@oracle.com>,
Bob Peterson <rpeterso@redhat.com>,
Damien Le Moal <damien.lemoal@wdc.com>,
Andreas Gruenbacher <agruenba@redhat.com>,
Ritesh Harjani <riteshh@linux.ibm.com>,
Johannes Thumshirn <jth@kernel.org>,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
cluster-devel@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [REPORT] kernel BUG at fs/ext4/inode.c:2620 - page_buffers()
Date: Wed, 23 Feb 2022 18:35:54 -0500 [thread overview]
Message-ID: <YhbE2nocBMtLc27C@mit.edu> (raw)
In-Reply-To: <Yg9QGm2Rygrv+lMj@kroah.com>
On Fri, Feb 18, 2022 at 08:51:54AM +0100, Greg Kroah-Hartman wrote:
> > The challenge is that fixing this "the right away" is probably not
> > something we can backport into an LTS kernel, whether it's 5.15 or
> > 5.10... or 4.19.
>
> Don't worry about stable backports to start with. Do it the "right way"
> first and then we can consider if it needs to be backported or not.
Fair enough; on the other hand, we could also view this as making ext4
more robust against buggy code in other subsystems, and while other
file systems may be losing user data if they are actually trying to do
remote memory access to file-backed memory, apparently other file
systems aren't noticing and so they're not crashing. Issuing a
warning and then not crashing is arguably a better way for ext4 to
react, especially if there are other parts of the kernel that are
randomly calling set_page_dirty() on file-backed memory without
properly first informing the file system in a context where it can
block and potentially do I/O to do things like allocate blocks.
- Ted
WARNING: multiple messages have this Message-ID (diff)
From: Theodore Ts'o <tytso@mit.edu>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [REPORT] kernel BUG at fs/ext4/inode.c:2620 - page_buffers()
Date: Wed, 23 Feb 2022 18:35:54 -0500 [thread overview]
Message-ID: <YhbE2nocBMtLc27C@mit.edu> (raw)
In-Reply-To: <Yg9QGm2Rygrv+lMj@kroah.com>
On Fri, Feb 18, 2022 at 08:51:54AM +0100, Greg Kroah-Hartman wrote:
> > The challenge is that fixing this "the right away" is probably not
> > something we can backport into an LTS kernel, whether it's 5.15 or
> > 5.10... or 4.19.
>
> Don't worry about stable backports to start with. Do it the "right way"
> first and then we can consider if it needs to be backported or not.
Fair enough; on the other hand, we could also view this as making ext4
more robust against buggy code in other subsystems, and while other
file systems may be losing user data if they are actually trying to do
remote memory access to file-backed memory, apparently other file
systems aren't noticing and so they're not crashing. Issuing a
warning and then not crashing is arguably a better way for ext4 to
react, especially if there are other parts of the kernel that are
randomly calling set_page_dirty() on file-backed memory without
properly first informing the file system in a context where it can
block and potentially do I/O to do things like allocate blocks.
- Ted
next prev parent reply other threads:[~2022-02-23 23:38 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 16:31 [REPORT] kernel BUG at fs/ext4/inode.c:2620 - page_buffers() Lee Jones
2022-02-16 16:31 ` [Cluster-devel] " Lee Jones
2022-02-18 1:06 ` John Hubbard
2022-02-18 1:06 ` [Cluster-devel] " John Hubbard
2022-02-18 4:08 ` Theodore Ts'o
2022-02-18 4:08 ` [Cluster-devel] " Theodore Ts'o
2022-02-18 6:33 ` John Hubbard
2022-02-18 6:33 ` [Cluster-devel] " John Hubbard
2022-02-23 23:31 ` Theodore Ts'o
2022-02-23 23:31 ` [Cluster-devel] " Theodore Ts'o
2022-02-24 0:44 ` John Hubbard
2022-02-24 0:44 ` [Cluster-devel] " John Hubbard
2022-02-24 4:04 ` Theodore Ts'o
2022-02-24 4:04 ` [Cluster-devel] " Theodore Ts'o
2022-02-18 7:51 ` Greg Kroah-Hartman
2022-02-18 7:51 ` [Cluster-devel] " Greg Kroah-Hartman
2022-02-23 23:35 ` Theodore Ts'o [this message]
2022-02-23 23:35 ` Theodore Ts'o
2022-02-24 1:48 ` Dave Chinner
2022-02-24 1:48 ` [Cluster-devel] " Dave Chinner
2022-02-24 3:50 ` Theodore Ts'o
2022-02-24 3:50 ` [Cluster-devel] " Theodore Ts'o
2022-02-24 10:29 ` Dave Chinner
2022-02-24 10:29 ` [Cluster-devel] " Dave Chinner
2022-02-18 2:54 ` Theodore Ts'o
2022-02-18 2:54 ` [Cluster-devel] " Theodore Ts'o
2022-02-18 4:24 ` Matthew Wilcox
2022-02-18 4:24 ` [Cluster-devel] " Matthew Wilcox
2022-02-18 6:03 ` Theodore Ts'o
2022-02-18 6:03 ` [Cluster-devel] " Theodore Ts'o
2022-02-25 19:24 ` [PATCH -v2] ext4: don't BUG if kernel subsystems dirty pages without asking ext4 first Theodore Ts'o
2022-02-25 19:24 ` [Cluster-devel] " Theodore Ts'o
2022-02-25 20:51 ` Eric Biggers
2022-02-25 20:51 ` [Cluster-devel] " Eric Biggers
2022-02-25 21:08 ` Theodore Ts'o
2022-02-25 21:08 ` [Cluster-devel] " Theodore Ts'o
2022-02-25 21:23 ` [PATCH -v3] " Theodore Ts'o
2022-02-25 21:23 ` [Cluster-devel] " Theodore Ts'o
2022-02-25 21:33 ` John Hubbard
2022-02-25 21:33 ` [Cluster-devel] " John Hubbard
2022-02-25 23:21 ` Theodore Ts'o
2022-02-25 23:21 ` [Cluster-devel] " Theodore Ts'o
2022-02-26 0:18 ` Hillf Danton
2022-02-26 0:41 ` John Hubbard
2022-02-26 0:41 ` [Cluster-devel] " John Hubbard
2022-02-26 1:40 ` Theodore Ts'o
2022-02-26 1:40 ` [Cluster-devel] " Theodore Ts'o
2022-02-26 2:00 ` Theodore Ts'o
2022-02-26 2:00 ` [Cluster-devel] " Theodore Ts'o
2022-02-26 2:55 ` John Hubbard
2022-02-26 2:55 ` [Cluster-devel] " John Hubbard
2022-03-03 4:26 ` [PATCH -v4] " Theodore Ts'o
2022-03-03 4:26 ` [Cluster-devel] " Theodore Ts'o
2022-03-03 8:21 ` Christoph Hellwig
2022-03-03 8:21 ` [Cluster-devel] " Christoph Hellwig
2022-03-03 9:21 ` Lee Jones
2022-03-03 9:21 ` [Cluster-devel] " Lee Jones
2022-03-03 14:38 ` [PATCH -v5] ext4: don't BUG if someone " Theodore Ts'o
2022-03-03 14:38 ` [Cluster-devel] " Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhbE2nocBMtLc27C@mit.edu \
--to=tytso@mit.edu \
--cc=agruenba@redhat.com \
--cc=cluster-devel@redhat.com \
--cc=damien.lemoal@wdc.com \
--cc=darrick.wong@oracle.com \
--cc=dchinner@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=jhubbard@nvidia.com \
--cc=jth@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=rgoldwyn@suse.com \
--cc=riteshh@linux.ibm.com \
--cc=rpeterso@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.