Re: [PATCH v2 01/22] drm/komeda: plane: switch to plane reset helper

From: Liviu Dudau <liviu.dudau@arm.com>
To: Maxime Ripard <maxime@cerno.tech>
Cc: Dom Cobley <dom@raspberrypi.com>,
	Tim Gover <tim.gover@raspberrypi.com>,
	Dave Stevenson <dave.stevenson@raspberrypi.com>,
	David Airlie <airlied@linux.ie>,
	dri-devel@lists.freedesktop.org,
	"James \(Qian\) Wang" <james.qian.wang@arm.com>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Daniel Vetter <daniel.vetter@intel.com>,
	Mihail Atanassov <mihail.atanassov@arm.com>,
	Phil Elwell <phil@raspberrypi.com>
Subject: Re: [PATCH v2 01/22] drm/komeda: plane: switch to plane reset helper
Date: Fri, 25 Feb 2022 13:59:04 +0000	[thread overview]
Message-ID: <YhjgqO9LRR5g6T76@e110455-lin.cambridge.arm.com> (raw)
In-Reply-To: <20220221095918.18763-2-maxime@cerno.tech>

On Mon, Feb 21, 2022 at 10:58:57AM +0100, Maxime Ripard wrote:
> komeda_plane_reset() does the state initialisation by copying a lot of
> the code found in the __drm_atomic_helper_plane_reset(). Let's switch to
> that helper and reduce the boilerplate.
> 
> Cc: Brian Starkey <brian.starkey@arm.com>
> Cc: "James (Qian) Wang" <james.qian.wang@arm.com>
> Cc: Liviu Dudau <liviu.dudau@arm.com>
> Cc: Mihail Atanassov <mihail.atanassov@arm.com>
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>

Acked-by: Liviu Dudau <liviu.dudau@arm.com>

Best regards,
Liviu

> ---
>  drivers/gpu/drm/arm/display/komeda/komeda_plane.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
> index d63d83800a8a..1778f6e1ea56 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
> @@ -145,14 +145,10 @@ static void komeda_plane_reset(struct drm_plane *plane)
>  
>  	state = kzalloc(sizeof(*state), GFP_KERNEL);
>  	if (state) {
> -		state->base.rotation = DRM_MODE_ROTATE_0;
> -		state->base.pixel_blend_mode = DRM_MODE_BLEND_PREMULTI;
> -		state->base.alpha = DRM_BLEND_ALPHA_OPAQUE;
> +		__drm_atomic_helper_plane_reset(plane, &state->base);
>  		state->base.zpos = kplane->layer->base.id;
>  		state->base.color_encoding = DRM_COLOR_YCBCR_BT601;
>  		state->base.color_range = DRM_COLOR_YCBCR_LIMITED_RANGE;
> -		plane->state = &state->base;
> -		plane->state->plane = plane;
>  	}
>  }
>  
> -- 
> 2.35.1
> 

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯