From: Maxime Ripard <maxime@cerno.tech>
To: Daniel Vetter <daniel.vetter@intel.com>, David Airlie <airlied@linux.ie>
Cc: Dom Cobley <dom@raspberrypi.com>,
Tim Gover <tim.gover@raspberrypi.com>,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
dri-devel@lists.freedesktop.org,
Jonathan Hunter <jonathanh@nvidia.com>,
Thierry Reding <thierry.reding@gmail.com>,
Maxime Ripard <maxime@cerno.tech>,
Thomas Zimmermann <tzimmermann@suse.de>,
linux-tegra@vger.kernel.org, Phil Elwell <phil@raspberrypi.com>
Subject: [PATCH v2 03/22] drm/tegra: hub: Fix zpos initial value mismatch
Date: Mon, 21 Feb 2022 10:58:59 +0100 [thread overview]
Message-ID: <20220221095918.18763-4-maxime@cerno.tech> (raw)
In-Reply-To: <20220221095918.18763-1-maxime@cerno.tech>
While the tegra_shared_plane_create() function calls
drm_plane_create_zpos_property() with an initial value of 0,
tegra_plane_reset() will force it to the plane index.
Fix the discrepancy by setting the initial zpos value to the plane index
in the function call.
Cc: linux-tegra@vger.kernel.org
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: Thierry Reding <thierry.reding@gmail.com>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
drivers/gpu/drm/tegra/hub.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tegra/hub.c b/drivers/gpu/drm/tegra/hub.c
index b910155f80c4..7f68a142d922 100644
--- a/drivers/gpu/drm/tegra/hub.c
+++ b/drivers/gpu/drm/tegra/hub.c
@@ -788,7 +788,7 @@ struct drm_plane *tegra_shared_plane_create(struct drm_device *drm,
}
drm_plane_helper_add(p, &tegra_shared_plane_helper_funcs);
- drm_plane_create_zpos_property(p, 0, 0, 255);
+ drm_plane_create_zpos_property(p, index, 0, 255);
return p;
}
--
2.35.1
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime@cerno.tech>
To: Daniel Vetter <daniel.vetter@intel.com>, David Airlie <airlied@linux.ie>
Cc: Dave Stevenson <dave.stevenson@raspberrypi.com>,
Phil Elwell <phil@raspberrypi.com>,
Tim Gover <tim.gover@raspberrypi.com>,
Dom Cobley <dom@raspberrypi.com>,
dri-devel@lists.freedesktop.org,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Maxime Ripard <maxime@cerno.tech>,
linux-tegra@vger.kernel.org,
Jonathan Hunter <jonathanh@nvidia.com>,
Thierry Reding <thierry.reding@gmail.com>
Subject: [PATCH v2 03/22] drm/tegra: hub: Fix zpos initial value mismatch
Date: Mon, 21 Feb 2022 10:58:59 +0100 [thread overview]
Message-ID: <20220221095918.18763-4-maxime@cerno.tech> (raw)
In-Reply-To: <20220221095918.18763-1-maxime@cerno.tech>
While the tegra_shared_plane_create() function calls
drm_plane_create_zpos_property() with an initial value of 0,
tegra_plane_reset() will force it to the plane index.
Fix the discrepancy by setting the initial zpos value to the plane index
in the function call.
Cc: linux-tegra@vger.kernel.org
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: Thierry Reding <thierry.reding@gmail.com>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
drivers/gpu/drm/tegra/hub.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tegra/hub.c b/drivers/gpu/drm/tegra/hub.c
index b910155f80c4..7f68a142d922 100644
--- a/drivers/gpu/drm/tegra/hub.c
+++ b/drivers/gpu/drm/tegra/hub.c
@@ -788,7 +788,7 @@ struct drm_plane *tegra_shared_plane_create(struct drm_device *drm,
}
drm_plane_helper_add(p, &tegra_shared_plane_helper_funcs);
- drm_plane_create_zpos_property(p, 0, 0, 255);
+ drm_plane_create_zpos_property(p, index, 0, 255);
return p;
}
--
2.35.1
next prev parent reply other threads:[~2022-02-21 9:59 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-21 9:58 [PATCH v2 00/22] drm: Fill in default values for plane properties Maxime Ripard
2022-02-21 9:58 ` [PATCH v2 01/22] drm/komeda: plane: switch to plane reset helper Maxime Ripard
2022-02-25 13:59 ` Liviu Dudau
2022-03-08 11:04 ` (subset) " Maxime Ripard
2022-02-21 9:58 ` [PATCH v2 02/22] drm/tegra: " Maxime Ripard
2022-02-21 9:58 ` Maxime Ripard
2022-02-21 9:58 ` Maxime Ripard [this message]
2022-02-21 9:58 ` [PATCH v2 03/22] drm/tegra: hub: Fix zpos initial value mismatch Maxime Ripard
2022-02-21 9:59 ` [PATCH v2 04/22] drm/omap: plane: " Maxime Ripard
2022-02-25 17:14 ` (subset) " Maxime Ripard
2022-02-21 9:59 ` [PATCH v2 05/22] drm/amd/display: Fix color encoding mismatch Maxime Ripard
2022-02-21 9:59 ` Maxime Ripard
2022-02-21 9:59 ` [PATCH v2 06/22] drm/object: Add drm_object_property_get_default_value() function Maxime Ripard
2022-02-25 17:14 ` (subset) " Maxime Ripard
2022-02-21 9:59 ` [PATCH v2 07/22] drm/object: Add default zpos value at reset Maxime Ripard
2022-02-25 17:14 ` (subset) " Maxime Ripard
2022-02-21 9:59 ` [PATCH v2 08/22] drm/tegra: plane: Remove redundant zpos initialisation Maxime Ripard
2022-02-21 9:59 ` Maxime Ripard
2022-02-21 9:59 ` [PATCH v2 09/22] drm/komeda: " Maxime Ripard
2022-02-25 13:59 ` Liviu Dudau
2022-03-08 11:04 ` (subset) " Maxime Ripard
2022-02-21 9:59 ` [PATCH v2 10/22] drm/exynos: " Maxime Ripard
2022-02-21 9:59 ` Maxime Ripard
2022-02-21 9:59 ` Maxime Ripard
2022-02-21 9:59 ` [PATCH v2 11/22] drm/imx: ipuv3-plane: " Maxime Ripard
2022-02-21 9:59 ` Maxime Ripard
2022-02-21 9:59 ` [PATCH v2 12/22] drm/msm/mdp5: " Maxime Ripard
2022-02-21 9:59 ` Maxime Ripard
2022-02-25 17:14 ` (subset) " Maxime Ripard
2022-02-25 17:14 ` Maxime Ripard
2022-02-21 9:59 ` [PATCH v2 13/22] drm/nouveau/kms: " Maxime Ripard
2022-02-21 9:59 ` [Nouveau] " Maxime Ripard
2022-02-21 16:42 ` Karol Herbst
2022-02-21 16:42 ` Karol Herbst
2022-02-22 14:02 ` Maxime Ripard
2022-02-22 14:02 ` [Nouveau] " Maxime Ripard
2022-02-22 21:35 ` Karol Herbst
2022-02-22 21:35 ` Karol Herbst
2022-02-22 20:36 ` [Nouveau] " Lyude Paul
2022-02-22 20:36 ` Lyude Paul
2022-02-25 17:14 ` (subset) [Nouveau] " Maxime Ripard
2022-02-25 17:14 ` [Nouveau] (subset) " Maxime Ripard
2022-02-21 9:59 ` [PATCH v2 14/22] drm/omap: plane: " Maxime Ripard
2022-02-25 17:14 ` (subset) " Maxime Ripard
2022-02-21 9:59 ` [PATCH v2 15/22] drm/rcar: " Maxime Ripard
2022-02-21 9:59 ` Maxime Ripard
2022-02-25 17:14 ` (subset) " Maxime Ripard
2022-02-25 17:14 ` Maxime Ripard
2022-02-21 9:59 ` [PATCH v2 16/22] drm/sti: " Maxime Ripard
2022-02-25 17:14 ` (subset) " Maxime Ripard
2022-02-21 9:59 ` [PATCH v2 17/22] drm/sun4i: layer: " Maxime Ripard
2022-02-21 9:59 ` Maxime Ripard
2022-02-21 9:59 ` Maxime Ripard
2022-02-25 17:14 ` (subset) " Maxime Ripard
2022-02-25 17:14 ` Maxime Ripard
2022-02-25 17:14 ` Maxime Ripard
2022-02-21 9:59 ` [PATCH v2 18/22] drm/object: Add default color encoding and range value at reset Maxime Ripard
2022-02-25 17:14 ` (subset) " Maxime Ripard
2022-02-21 9:59 ` [PATCH v2 19/22] drm/komeda: plane: Remove redundant color encoding and range initialisation Maxime Ripard
2022-02-25 14:01 ` Liviu Dudau
2022-03-08 11:04 ` (subset) " Maxime Ripard
2022-02-21 9:59 ` [PATCH v2 20/22] drm/armada: overlay: " Maxime Ripard
2022-02-21 9:59 ` [PATCH v2 21/22] drm/imx: ipuv3-plane: " Maxime Ripard
2022-02-21 9:59 ` Maxime Ripard
2022-02-21 9:59 ` [PATCH v2 22/22] drm/omap: plane: " Maxime Ripard
2022-02-25 17:14 ` (subset) " Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220221095918.18763-4-maxime@cerno.tech \
--to=maxime@cerno.tech \
--cc=airlied@linux.ie \
--cc=daniel.vetter@intel.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=dom@raspberrypi.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jonathanh@nvidia.com \
--cc=linux-tegra@vger.kernel.org \
--cc=phil@raspberrypi.com \
--cc=thierry.reding@gmail.com \
--cc=tim.gover@raspberrypi.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.