From: Vinod Koul <vkoul@kernel.org> To: Marijn Suijten <marijn.suijten@somainline.org> Cc: Rob Clark <robdclark@gmail.com>, linux-arm-msm@vger.kernel.org, Bjorn Andersson <bjorn.andersson@linaro.org>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Jonathan Marek <jonathan@marek.ca>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, Abhinav Kumar <abhinavk@codeaurora.org>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org Subject: Re: [REPOST PATCH v4 07/13] drm/msm/disp/dpu1: Add support for DSC in encoder Date: Thu, 24 Mar 2022 21:11:50 +0530 [thread overview] Message-ID: <YjyRPhdoiLw4gOtD@matsya> (raw) In-Reply-To: <YjsxaJrvxgtO5ecC@matsya> On 23-03-22, 20:10, Vinod Koul wrote: > On 17-02-22, 23:32, Marijn Suijten wrote: > > On 2022-02-10 16:04:17, Vinod Koul wrote: > > > + > > > + slice_count = dsc->drm->slice_count; > > > + slice_per_intf = DIV_ROUND_UP(width, dsc->drm->slice_width); > > > + > > > + /* > > > + * If slice_count is greater than slice_per_intf then default to 1. > > > + * This can happen during partial update. > > > + */ > > > + if (slice_count > slice_per_intf) > > > + slice_count = 1; > > > + > > > + bytes_in_slice = DIV_ROUND_UP(dsc->drm->slice_width * > > > + dsc->drm->bits_per_pixel, 8); > > > + total_bytes_per_intf = bytes_in_slice * slice_per_intf; > > > + > > > + dsc->eol_byte_num = total_bytes_per_intf % 3; > > > + dsc->pclk_per_line = DIV_ROUND_UP(total_bytes_per_intf, 3); > > > + dsc->bytes_in_slice = bytes_in_slice; > > > + dsc->bytes_per_pkt = bytes_in_slice * slice_count; > > > + dsc->pkt_per_line = slice_per_intf / slice_count; > > > +} > > > > I've seen the same calculations duplicated twice in dsi code. Since the > > msm_display_dsc_config struct is available in a header, perhaps a single > > - easily reviewable and maintainable - calculation function should be > > available there too? > > Let me try check if we can make it common.. I rechecked and we can actually remove this as we do this caln in timing and update the dsc structure there. So this fn is dropped now -- ~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org> To: Marijn Suijten <marijn.suijten@somainline.org> Cc: Jonathan Marek <jonathan@marek.ca>, David Airlie <airlied@linux.ie>, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Abhinav Kumar <abhinavk@codeaurora.org>, Bjorn Andersson <bjorn.andersson@linaro.org>, dri-devel@lists.freedesktop.org, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, freedreno@lists.freedesktop.org Subject: Re: [REPOST PATCH v4 07/13] drm/msm/disp/dpu1: Add support for DSC in encoder Date: Thu, 24 Mar 2022 21:11:50 +0530 [thread overview] Message-ID: <YjyRPhdoiLw4gOtD@matsya> (raw) In-Reply-To: <YjsxaJrvxgtO5ecC@matsya> On 23-03-22, 20:10, Vinod Koul wrote: > On 17-02-22, 23:32, Marijn Suijten wrote: > > On 2022-02-10 16:04:17, Vinod Koul wrote: > > > + > > > + slice_count = dsc->drm->slice_count; > > > + slice_per_intf = DIV_ROUND_UP(width, dsc->drm->slice_width); > > > + > > > + /* > > > + * If slice_count is greater than slice_per_intf then default to 1. > > > + * This can happen during partial update. > > > + */ > > > + if (slice_count > slice_per_intf) > > > + slice_count = 1; > > > + > > > + bytes_in_slice = DIV_ROUND_UP(dsc->drm->slice_width * > > > + dsc->drm->bits_per_pixel, 8); > > > + total_bytes_per_intf = bytes_in_slice * slice_per_intf; > > > + > > > + dsc->eol_byte_num = total_bytes_per_intf % 3; > > > + dsc->pclk_per_line = DIV_ROUND_UP(total_bytes_per_intf, 3); > > > + dsc->bytes_in_slice = bytes_in_slice; > > > + dsc->bytes_per_pkt = bytes_in_slice * slice_count; > > > + dsc->pkt_per_line = slice_per_intf / slice_count; > > > +} > > > > I've seen the same calculations duplicated twice in dsi code. Since the > > msm_display_dsc_config struct is available in a header, perhaps a single > > - easily reviewable and maintainable - calculation function should be > > available there too? > > Let me try check if we can make it common.. I rechecked and we can actually remove this as we do this caln in timing and update the dsc structure there. So this fn is dropped now -- ~Vinod
next prev parent reply other threads:[~2022-03-24 15:41 UTC|newest] Thread overview: 127+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-02-10 10:34 [REPOST PATCH v4 00/13] drm/msm: Add Display Stream Compression Support Vinod Koul 2022-02-10 10:34 ` Vinod Koul 2022-02-10 10:34 ` [REPOST PATCH v4 01/13] drm/msm/dsi: add support for dsc data Vinod Koul 2022-02-10 10:34 ` Vinod Koul 2022-02-10 11:07 ` Dmitry Baryshkov 2022-02-10 11:07 ` Dmitry Baryshkov 2022-02-17 20:06 ` Abhinav Kumar 2022-02-17 20:06 ` Abhinav Kumar 2022-02-21 2:17 ` Dmitry Baryshkov 2022-02-21 2:17 ` Dmitry Baryshkov 2022-02-10 10:34 ` [REPOST PATCH v4 02/13] drm/msm/dsi: Pass DSC params to drm_panel Vinod Koul 2022-02-10 10:34 ` Vinod Koul 2022-02-10 10:43 ` Dmitry Baryshkov 2022-02-10 10:43 ` Dmitry Baryshkov 2022-02-17 0:27 ` Abhinav Kumar 2022-02-17 0:27 ` Abhinav Kumar 2022-02-21 12:37 ` Dmitry Baryshkov 2022-02-21 12:37 ` Dmitry Baryshkov 2022-03-03 19:08 ` Abhinav Kumar 2022-03-03 19:08 ` Abhinav Kumar 2022-02-10 10:34 ` [REPOST PATCH v4 03/13] drm/msm/disp/dpu1: Add support for DSC Vinod Koul 2022-02-10 10:34 ` Vinod Koul 2022-02-16 18:57 ` Abhinav Kumar 2022-02-16 18:57 ` Abhinav Kumar 2022-02-16 19:46 ` Dmitry Baryshkov 2022-02-17 4:20 ` Vinod Koul 2022-02-17 4:20 ` Vinod Koul 2022-02-10 10:34 ` [REPOST PATCH v4 04/13] drm/msm/disp/dpu1: Add support for DSC in pingpong block Vinod Koul 2022-02-10 10:34 ` Vinod Koul 2022-02-16 19:49 ` Abhinav Kumar 2022-02-16 19:49 ` Abhinav Kumar 2022-02-17 4:21 ` Vinod Koul 2022-02-17 4:21 ` Vinod Koul 2022-02-10 10:34 ` [REPOST PATCH v4 05/13] drm/msm/disp/dpu1: Add DSC for SDM845 to hw_catalog Vinod Koul 2022-02-10 10:34 ` Vinod Koul 2022-02-16 19:42 ` [Freedreno] " Abhinav Kumar 2022-02-16 19:42 ` Abhinav Kumar 2022-02-10 10:34 ` [REPOST PATCH v4 06/13] drm/msm/disp/dpu1: Add DSC support in hw_ctl Vinod Koul 2022-02-10 10:34 ` Vinod Koul 2022-02-16 19:52 ` [Freedreno] " Abhinav Kumar 2022-02-16 19:52 ` Abhinav Kumar 2022-02-17 22:20 ` Marijn Suijten 2022-02-17 22:20 ` Marijn Suijten 2022-03-24 16:24 ` Vinod Koul 2022-03-24 16:24 ` Vinod Koul 2022-02-10 10:34 ` [REPOST PATCH v4 07/13] drm/msm/disp/dpu1: Add support for DSC in encoder Vinod Koul 2022-02-10 10:34 ` Vinod Koul 2022-02-10 11:13 ` Dmitry Baryshkov 2022-02-10 11:13 ` Dmitry Baryshkov 2022-02-16 19:54 ` [Freedreno] " Abhinav Kumar 2022-02-16 19:54 ` Abhinav Kumar 2022-02-17 6:08 ` Vinod Koul 2022-02-17 6:08 ` Vinod Koul 2022-02-17 22:32 ` Marijn Suijten 2022-02-17 22:32 ` Marijn Suijten 2022-03-23 14:40 ` Vinod Koul 2022-03-23 14:40 ` Vinod Koul 2022-03-24 15:41 ` Vinod Koul [this message] 2022-03-24 15:41 ` Vinod Koul 2022-02-21 1:41 ` Dmitry Baryshkov 2022-02-21 1:41 ` Dmitry Baryshkov 2022-02-10 10:34 ` [REPOST PATCH v4 08/13] drm/msm/disp/dpu1: Don't use DSC with mode_3d Vinod Koul 2022-02-10 10:34 ` Vinod Koul 2022-02-10 10:55 ` Dmitry Baryshkov 2022-02-10 10:55 ` Dmitry Baryshkov 2022-02-17 3:11 ` Abhinav Kumar 2022-02-17 3:11 ` Abhinav Kumar 2022-02-17 6:10 ` Vinod Koul 2022-02-17 6:10 ` Vinod Koul 2022-02-17 6:33 ` Abhinav Kumar 2022-02-17 6:33 ` Abhinav Kumar 2022-02-17 7:12 ` Dmitry Baryshkov 2022-02-17 7:12 ` Dmitry Baryshkov 2022-02-18 20:46 ` Abhinav Kumar 2022-02-18 20:46 ` Abhinav Kumar 2022-02-18 21:21 ` Dmitry Baryshkov 2022-02-18 21:21 ` Dmitry Baryshkov 2022-02-18 21:29 ` [Freedreno] " Abhinav Kumar 2022-02-18 21:29 ` Abhinav Kumar 2022-02-18 21:36 ` Dmitry Baryshkov 2022-02-18 21:36 ` Dmitry Baryshkov 2022-02-10 10:34 ` [REPOST PATCH v4 09/13] drm/msm: Add missing structure documentation Vinod Koul 2022-02-10 10:34 ` Vinod Koul 2022-02-10 10:39 ` Dmitry Baryshkov 2022-02-10 10:39 ` Dmitry Baryshkov 2022-02-17 3:12 ` Abhinav Kumar 2022-02-17 3:12 ` Abhinav Kumar 2022-02-17 22:34 ` Marijn Suijten 2022-02-17 22:34 ` Marijn Suijten 2022-02-10 10:34 ` [REPOST PATCH v4 10/13] drm/msm/disp/dpu1: Add support for DSC in topology Vinod Koul 2022-02-10 10:34 ` Vinod Koul 2022-02-10 10:47 ` Dmitry Baryshkov 2022-02-10 10:47 ` Dmitry Baryshkov 2022-02-17 21:44 ` Marijn Suijten 2022-02-17 21:44 ` Marijn Suijten 2022-03-23 11:38 ` [Freedreno] " Vinod Koul 2022-03-23 11:38 ` Vinod Koul 2022-02-17 22:37 ` Marijn Suijten 2022-02-17 22:37 ` Marijn Suijten 2022-03-23 11:39 ` Vinod Koul 2022-03-23 11:39 ` Vinod Koul 2022-02-10 10:34 ` [REPOST PATCH v4 11/13] drm/msm/disp/dpu1: Add DSC support in RM Vinod Koul 2022-02-10 10:34 ` Vinod Koul 2022-02-17 3:14 ` Abhinav Kumar 2022-02-17 3:14 ` Abhinav Kumar 2022-02-17 3:21 ` Abhinav Kumar 2022-02-17 3:21 ` Abhinav Kumar 2022-02-10 10:34 ` [REPOST PATCH v4 12/13] drm/msm/dsi: add mode valid callback for dsi_mgr Vinod Koul 2022-02-10 10:34 ` Vinod Koul 2022-02-17 3:17 ` Abhinav Kumar 2022-02-17 3:17 ` Abhinav Kumar 2022-02-10 10:34 ` [REPOST PATCH v4 13/13] drm/msm/dsi: Add support for DSC configuration Vinod Koul 2022-02-10 10:34 ` Vinod Koul 2022-02-17 3:44 ` [Freedreno] " Abhinav Kumar 2022-02-17 3:44 ` Abhinav Kumar 2022-02-17 6:19 ` Vinod Koul 2022-02-17 6:19 ` Vinod Koul 2022-02-17 9:27 ` Marijn Suijten 2022-02-17 9:27 ` Marijn Suijten 2022-02-17 10:51 ` [Freedreno] " Vinod Koul 2022-02-17 10:51 ` Vinod Koul 2022-02-17 14:38 ` Marijn Suijten 2022-02-17 14:38 ` Marijn Suijten 2022-02-21 2:11 ` Dmitry Baryshkov 2022-02-21 2:11 ` Dmitry Baryshkov 2022-03-24 15:45 ` Vinod Koul 2022-03-24 15:45 ` Vinod Koul
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YjyRPhdoiLw4gOtD@matsya \ --to=vkoul@kernel.org \ --cc=abhinavk@codeaurora.org \ --cc=airlied@linux.ie \ --cc=bjorn.andersson@linaro.org \ --cc=daniel@ffwll.ch \ --cc=dmitry.baryshkov@linaro.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=jonathan@marek.ca \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=marijn.suijten@somainline.org \ --cc=robdclark@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.