From: Catalin Marinas <catalin.marinas@arm.com>
To: Baoquan He <bhe@redhat.com>
Cc: Zhen Lei <thunder.leizhen@huawei.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org, Dave Young <dyoung@redhat.com>,
Vivek Goyal <vgoyal@redhat.com>,
Eric Biederman <ebiederm@xmission.com>,
kexec@lists.infradead.org, Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
devicetree@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org, Randy Dunlap <rdunlap@infradead.org>,
Feng Zhou <zhoufeng.zf@bytedance.com>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
Chen Zhou <dingguo.cz@antgroup.com>,
John Donnelly <John.p.donnelly@oracle.com>,
Dave Kleikamp <dave.kleikamp@oracle.com>
Subject: Re: [PATCH v24 3/6] arm64: kdump: Reimplement crashkernel=X
Date: Sat, 7 May 2022 19:50:21 +0100 [thread overview]
Message-ID: <Yna/bc2nDb7PT40r@arm.com> (raw)
In-Reply-To: <20220506231032.GA122876@MiWiFi-R3L-srv>
On Sat, May 07, 2022 at 07:10:32AM +0800, Baoquan He wrote:
> On 05/06/22 at 07:43pm, Zhen Lei wrote:
> ......
> > @@ -118,8 +162,7 @@ static void __init reserve_crashkernel(void)
> > if (crash_base)
> > crash_max = crash_base + crash_size;
> >
> > - /* Current arm64 boot protocol requires 2MB alignment */
> > - crash_base = memblock_phys_alloc_range(crash_size, SZ_2M,
> > + crash_base = memblock_phys_alloc_range(crash_size, CRASH_ALIGN,
> > crash_base, crash_max);
> > if (!crash_base) {
> > pr_warn("cannot allocate crashkernel (size:0x%llx)\n",
> > @@ -127,6 +170,11 @@ static void __init reserve_crashkernel(void)
> > return;
> > }
> >
>
> There's corner case missed, e.g
> 1) ,high and ,low are specified, CONFIG_ZONE_DMA|DMA32 is not enabled;
> 2) ,high and ,low are specified, the whole system memory is under 4G.
My view of ,low is that it should only used to override the default
ZONE_DMA allocation if that one is not suitable. If no ZONE_DMA exists
or everything is ZONE_DMA, ignore it altogether. That's a specialist
case for people that know more about the memory layout, otherwise
crashkernel=X works in most case with crashkernel=X,high as an
alternative to allow high allocation.
> I would suggest merging this series, Lei can add this corner case
> handling on top. Since this is a newly added support, we don't have
> to make it one step. Doing step by step can make reviewing easier.
I agree.
--
Catalin
WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Baoquan He <bhe@redhat.com>
Cc: Zhen Lei <thunder.leizhen@huawei.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org, Dave Young <dyoung@redhat.com>,
Vivek Goyal <vgoyal@redhat.com>,
Eric Biederman <ebiederm@xmission.com>,
kexec@lists.infradead.org, Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
devicetree@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org, Randy Dunlap <rdunlap@infradead.org>,
Feng Zhou <zhoufeng.zf@bytedance.com>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
Chen Zhou <dingguo.cz@antgroup.com>,
John Donnelly <John.p.donnelly@oracle.com>,
Dave Kleikamp <dave.kleikamp@oracle.com>
Subject: Re: [PATCH v24 3/6] arm64: kdump: Reimplement crashkernel=X
Date: Sat, 7 May 2022 19:50:21 +0100 [thread overview]
Message-ID: <Yna/bc2nDb7PT40r@arm.com> (raw)
In-Reply-To: <20220506231032.GA122876@MiWiFi-R3L-srv>
On Sat, May 07, 2022 at 07:10:32AM +0800, Baoquan He wrote:
> On 05/06/22 at 07:43pm, Zhen Lei wrote:
> ......
> > @@ -118,8 +162,7 @@ static void __init reserve_crashkernel(void)
> > if (crash_base)
> > crash_max = crash_base + crash_size;
> >
> > - /* Current arm64 boot protocol requires 2MB alignment */
> > - crash_base = memblock_phys_alloc_range(crash_size, SZ_2M,
> > + crash_base = memblock_phys_alloc_range(crash_size, CRASH_ALIGN,
> > crash_base, crash_max);
> > if (!crash_base) {
> > pr_warn("cannot allocate crashkernel (size:0x%llx)\n",
> > @@ -127,6 +170,11 @@ static void __init reserve_crashkernel(void)
> > return;
> > }
> >
>
> There's corner case missed, e.g
> 1) ,high and ,low are specified, CONFIG_ZONE_DMA|DMA32 is not enabled;
> 2) ,high and ,low are specified, the whole system memory is under 4G.
My view of ,low is that it should only used to override the default
ZONE_DMA allocation if that one is not suitable. If no ZONE_DMA exists
or everything is ZONE_DMA, ignore it altogether. That's a specialist
case for people that know more about the memory layout, otherwise
crashkernel=X works in most case with crashkernel=X,high as an
alternative to allow high allocation.
> I would suggest merging this series, Lei can add this corner case
> handling on top. Since this is a newly added support, we don't have
> to make it one step. Doing step by step can make reviewing easier.
I agree.
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: kexec@lists.infradead.org
Subject: [PATCH v24 3/6] arm64: kdump: Reimplement crashkernel=X
Date: Sat, 7 May 2022 19:50:21 +0100 [thread overview]
Message-ID: <Yna/bc2nDb7PT40r@arm.com> (raw)
In-Reply-To: <20220506231032.GA122876@MiWiFi-R3L-srv>
On Sat, May 07, 2022 at 07:10:32AM +0800, Baoquan He wrote:
> On 05/06/22 at 07:43pm, Zhen Lei wrote:
> ......
> > @@ -118,8 +162,7 @@ static void __init reserve_crashkernel(void)
> > if (crash_base)
> > crash_max = crash_base + crash_size;
> >
> > - /* Current arm64 boot protocol requires 2MB alignment */
> > - crash_base = memblock_phys_alloc_range(crash_size, SZ_2M,
> > + crash_base = memblock_phys_alloc_range(crash_size, CRASH_ALIGN,
> > crash_base, crash_max);
> > if (!crash_base) {
> > pr_warn("cannot allocate crashkernel (size:0x%llx)\n",
> > @@ -127,6 +170,11 @@ static void __init reserve_crashkernel(void)
> > return;
> > }
> >
>
> There's corner case missed, e.g
> 1) ,high and ,low are specified, CONFIG_ZONE_DMA|DMA32 is not enabled;
> 2) ,high and ,low are specified, the whole system memory is under 4G.
My view of ,low is that it should only used to override the default
ZONE_DMA allocation if that one is not suitable. If no ZONE_DMA exists
or everything is ZONE_DMA, ignore it altogether. That's a specialist
case for people that know more about the memory layout, otherwise
crashkernel=X works in most case with crashkernel=X,high as an
alternative to allow high allocation.
> I would suggest merging this series, Lei can add this corner case
> handling on top. Since this is a newly added support, we don't have
> to make it one step. Doing step by step can make reviewing easier.
I agree.
--
Catalin
next prev parent reply other threads:[~2022-05-07 18:50 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-06 11:43 [PATCH v24 0/6] support reserving crashkernel above 4G on arm64 kdump Zhen Lei
2022-05-06 11:43 ` Zhen Lei
2022-05-06 11:43 ` Zhen Lei
2022-05-06 11:43 ` [PATCH v24 1/6] kdump: return -ENOENT if required cmdline option does not exist Zhen Lei
2022-05-06 11:43 ` Zhen Lei
2022-05-06 11:43 ` Zhen Lei
2022-05-06 11:43 ` [PATCH v24 2/6] arm64: Use insert_resource() to simplify code Zhen Lei
2022-05-06 11:43 ` Zhen Lei
2022-05-06 11:43 ` Zhen Lei
2022-05-06 11:43 ` [PATCH v24 3/6] arm64: kdump: Reimplement crashkernel=X Zhen Lei
2022-05-06 11:43 ` Zhen Lei
2022-05-06 11:43 ` Zhen Lei
2022-05-06 23:10 ` Baoquan He
2022-05-06 23:10 ` Baoquan He
2022-05-06 23:10 ` Baoquan He
2022-05-07 1:34 ` Leizhen (ThunderTown)
2022-05-07 1:34 ` Leizhen
2022-05-07 1:34 ` Leizhen (ThunderTown)
2022-05-07 2:07 ` Baoquan He
2022-05-07 2:07 ` Baoquan He
2022-05-07 2:07 ` Baoquan He
2022-05-07 3:37 ` Leizhen (ThunderTown)
2022-05-07 3:37 ` Leizhen
2022-05-07 3:37 ` Leizhen (ThunderTown)
2022-05-07 9:35 ` Leizhen (ThunderTown)
2022-05-07 9:35 ` Leizhen
2022-05-07 9:35 ` Leizhen (ThunderTown)
2022-05-07 11:49 ` Leizhen (ThunderTown)
2022-05-07 11:49 ` Leizhen
2022-05-07 11:49 ` Leizhen (ThunderTown)
2022-05-07 12:20 ` Leizhen (ThunderTown)
2022-05-07 12:20 ` Leizhen
2022-05-07 12:20 ` Leizhen (ThunderTown)
2022-05-07 13:22 ` Baoquan He
2022-05-07 13:22 ` Baoquan He
2022-05-07 13:22 ` Baoquan He
2022-05-07 17:30 ` John Donnelly
2022-05-07 17:30 ` John Donnelly
2022-05-07 17:30 ` John Donnelly
2022-05-07 18:50 ` Catalin Marinas [this message]
2022-05-07 18:50 ` Catalin Marinas
2022-05-07 18:50 ` Catalin Marinas
2022-05-09 4:04 ` Baoquan He
2022-05-09 4:04 ` Baoquan He
2022-05-09 4:04 ` Baoquan He
2022-05-06 11:44 ` [PATCH v24 4/6] of: fdt: Add memory for devices by DT property "linux,usable-memory-range" Zhen Lei
2022-05-06 11:44 ` [PATCH v24 4/6] of: fdt: Add memory for devices by DT property "linux, usable-memory-range" Zhen Lei
2022-05-06 11:44 ` Zhen Lei
2022-05-06 23:15 ` [PATCH v24 4/6] of: fdt: Add memory for devices by DT property "linux,usable-memory-range" Baoquan He
2022-05-06 23:15 ` Baoquan He
2022-05-06 23:15 ` Baoquan He
2022-05-06 11:44 ` [PATCH v24 5/6] of: Support more than one crash kernel regions for kexec -s Zhen Lei
2022-05-06 11:44 ` Zhen Lei
2022-05-06 11:44 ` Zhen Lei
2022-05-06 23:17 ` Baoquan He
2022-05-06 23:17 ` Baoquan He
2022-05-06 23:17 ` Baoquan He
2022-05-07 1:42 ` Leizhen (ThunderTown)
2022-05-07 1:42 ` Leizhen
2022-05-07 1:42 ` Leizhen (ThunderTown)
2022-05-07 2:36 ` Baoquan He
2022-05-07 2:36 ` Baoquan He
2022-05-07 2:36 ` Baoquan He
2022-05-06 11:44 ` [PATCH v24 6/6] docs: kdump: Update the crashkernel description for arm64 Zhen Lei
2022-05-06 11:44 ` Zhen Lei
2022-05-06 11:44 ` Zhen Lei
2022-05-06 23:14 ` Baoquan He
2022-05-06 23:14 ` Baoquan He
2022-05-06 23:14 ` Baoquan He
2022-05-07 1:41 ` Leizhen (ThunderTown)
2022-05-07 1:41 ` Leizhen
2022-05-07 1:41 ` Leizhen (ThunderTown)
2022-05-07 3:23 ` Leizhen (ThunderTown)
2022-05-07 3:23 ` Leizhen
2022-05-07 3:23 ` Leizhen (ThunderTown)
2022-05-07 3:30 ` Baoquan He
2022-05-07 3:30 ` Baoquan He
2022-05-07 3:30 ` Baoquan He
2022-05-07 18:22 ` Catalin Marinas
2022-05-07 18:22 ` Catalin Marinas
2022-05-07 18:22 ` Catalin Marinas
2022-05-09 4:05 ` Baoquan He
2022-05-09 4:05 ` Baoquan He
2022-05-09 4:05 ` Baoquan He
2022-05-07 19:12 ` [PATCH v24 0/6] support reserving crashkernel above 4G on arm64 kdump Catalin Marinas
2022-05-07 19:12 ` Catalin Marinas
2022-05-07 19:12 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yna/bc2nDb7PT40r@arm.com \
--to=catalin.marinas@arm.com \
--cc=John.p.donnelly@oracle.com \
--cc=bhe@redhat.com \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=dave.kleikamp@oracle.com \
--cc=devicetree@vger.kernel.org \
--cc=dingguo.cz@antgroup.com \
--cc=dyoung@redhat.com \
--cc=ebiederm@xmission.com \
--cc=frowand.list@gmail.com \
--cc=hpa@zytor.com \
--cc=kexec@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=thunder.leizhen@huawei.com \
--cc=vgoyal@redhat.com \
--cc=wangkefeng.wang@huawei.com \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=zhoufeng.zf@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.