From: Mark Brown <broonie@kernel.org>
To: Pratyush Yadav <p.yadav@ti.com>
Cc: linux-spi@vger.kernel.org, linux-mtd@lists.infradead.org,
clg@kaod.org, andrew@aj.id.au, robh+dt@kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
richard@nod.at, joel@jms.id.au, tudor.ambarus@microchip.com,
miquel.raynal@bootlin.com, chin-ting_kuo@aspeedtech.com,
linux-aspeed@lists.ozlabs.org, vigneshr@ti.com,
linux-kernel@vger.kernel.org
Subject: Re: (subset) [PATCH v7 00/11] spi: spi-mem: Convert Aspeed SMC driver to spi-mem
Date: Tue, 17 May 2022 13:10:44 +0100 [thread overview]
Message-ID: <YoOQxJV2xNfkkwQS@sirena.org.uk> (raw)
In-Reply-To: <20220517110509.2e6xbwot63yl6a3c@ti.com>
[-- Attachment #1: Type: text/plain, Size: 857 bytes --]
On Tue, May 17, 2022 at 04:35:09PM +0530, Pratyush Yadav wrote:
> On 16/05/22 07:39PM, Mark Brown wrote:
> > On Mon, 9 May 2022 19:56:05 +0200, Cédric Le Goater wrote:
> > [08/11] spi: aspeed: Calibrate read timings
> > commit: eeaec1ea05c0e0f08e04c6844f20cc24a2fcc0f4
> I have repeatedly objected to this patch [0][1][2] and you have
> repeatedly decided to not address my objections. I won't spend any more
> time fighting it. But I will say that you should not expect any
> guarantees that SPI NOR or SPI NAND will not break your calibration in
> the future if they decide to move the dirmap_create() call around.
You == Cedric here. Sorry, I thought that had been addressed as there
hadn't been anything I'd noticed on the thread for a few versions. It
does look like there was agreement that there was a problem too :/
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Pratyush Yadav <p.yadav@ti.com>
Cc: linux-spi@vger.kernel.org, linux-mtd@lists.infradead.org,
clg@kaod.org, andrew@aj.id.au, robh+dt@kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
richard@nod.at, joel@jms.id.au, tudor.ambarus@microchip.com,
miquel.raynal@bootlin.com, chin-ting_kuo@aspeedtech.com,
linux-aspeed@lists.ozlabs.org, vigneshr@ti.com,
linux-kernel@vger.kernel.org
Subject: Re: (subset) [PATCH v7 00/11] spi: spi-mem: Convert Aspeed SMC driver to spi-mem
Date: Tue, 17 May 2022 13:10:44 +0100 [thread overview]
Message-ID: <YoOQxJV2xNfkkwQS@sirena.org.uk> (raw)
In-Reply-To: <20220517110509.2e6xbwot63yl6a3c@ti.com>
[-- Attachment #1.1: Type: text/plain, Size: 857 bytes --]
On Tue, May 17, 2022 at 04:35:09PM +0530, Pratyush Yadav wrote:
> On 16/05/22 07:39PM, Mark Brown wrote:
> > On Mon, 9 May 2022 19:56:05 +0200, Cédric Le Goater wrote:
> > [08/11] spi: aspeed: Calibrate read timings
> > commit: eeaec1ea05c0e0f08e04c6844f20cc24a2fcc0f4
> I have repeatedly objected to this patch [0][1][2] and you have
> repeatedly decided to not address my objections. I won't spend any more
> time fighting it. But I will say that you should not expect any
> guarantees that SPI NOR or SPI NAND will not break your calibration in
> the future if they decide to move the dirmap_create() call around.
You == Cedric here. Sorry, I thought that had been addressed as there
hadn't been anything I'd noticed on the thread for a few versions. It
does look like there was agreement that there was a problem too :/
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 144 bytes --]
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Pratyush Yadav <p.yadav@ti.com>
Cc: linux-spi@vger.kernel.org, linux-mtd@lists.infradead.org,
clg@kaod.org, andrew@aj.id.au, robh+dt@kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
richard@nod.at, joel@jms.id.au, tudor.ambarus@microchip.com,
miquel.raynal@bootlin.com, chin-ting_kuo@aspeedtech.com,
linux-aspeed@lists.ozlabs.org, vigneshr@ti.com,
linux-kernel@vger.kernel.org
Subject: Re: (subset) [PATCH v7 00/11] spi: spi-mem: Convert Aspeed SMC driver to spi-mem
Date: Tue, 17 May 2022 13:10:44 +0100 [thread overview]
Message-ID: <YoOQxJV2xNfkkwQS@sirena.org.uk> (raw)
In-Reply-To: <20220517110509.2e6xbwot63yl6a3c@ti.com>
[-- Attachment #1.1: Type: text/plain, Size: 857 bytes --]
On Tue, May 17, 2022 at 04:35:09PM +0530, Pratyush Yadav wrote:
> On 16/05/22 07:39PM, Mark Brown wrote:
> > On Mon, 9 May 2022 19:56:05 +0200, Cédric Le Goater wrote:
> > [08/11] spi: aspeed: Calibrate read timings
> > commit: eeaec1ea05c0e0f08e04c6844f20cc24a2fcc0f4
> I have repeatedly objected to this patch [0][1][2] and you have
> repeatedly decided to not address my objections. I won't spend any more
> time fighting it. But I will say that you should not expect any
> guarantees that SPI NOR or SPI NAND will not break your calibration in
> the future if they decide to move the dirmap_create() call around.
You == Cedric here. Sorry, I thought that had been addressed as there
hadn't been anything I'd noticed on the thread for a few versions. It
does look like there was agreement that there was a problem too :/
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-17 12:11 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-09 17:56 [PATCH v7 00/11] spi: spi-mem: Convert Aspeed SMC driver to spi-mem Cédric Le Goater
2022-05-09 17:56 ` Cédric Le Goater
2022-05-09 17:56 ` Cédric Le Goater
2022-05-09 17:56 ` [PATCH v7 01/11] ARM: dts: aspeed: Adjust "reg" property of FMC/SPI controllers Cédric Le Goater
2022-05-09 17:56 ` Cédric Le Goater
2022-05-09 17:56 ` Cédric Le Goater
2022-05-09 17:56 ` [PATCH v7 02/11] dt-bindings: spi: Convert the Aspeed SMC controllers device tree binding Cédric Le Goater
2022-05-09 17:56 ` Cédric Le Goater
2022-05-09 17:56 ` Cédric Le Goater
2022-05-09 17:56 ` [PATCH v7 03/11] spi: spi-mem: Convert Aspeed SMC driver to spi-mem Cédric Le Goater
2022-05-09 17:56 ` Cédric Le Goater
2022-05-09 17:56 ` Cédric Le Goater
2022-05-09 17:56 ` [PATCH v7 04/11] spi: aspeed: Add support for direct mapping Cédric Le Goater
2022-05-09 17:56 ` Cédric Le Goater
2022-05-09 17:56 ` Cédric Le Goater
2022-05-09 17:56 ` [PATCH v7 05/11] spi: aspeed: Adjust direct mapping to device size Cédric Le Goater
2022-05-09 17:56 ` Cédric Le Goater
2022-05-09 17:56 ` Cédric Le Goater
2022-05-09 17:56 ` [PATCH v7 06/11] spi: aspeed: Workaround AST2500 limitations Cédric Le Goater
2022-05-09 17:56 ` Cédric Le Goater
2022-05-09 17:56 ` Cédric Le Goater
2022-05-09 17:56 ` [PATCH v7 07/11] spi: aspeed: Add support for the AST2400 SPI controller Cédric Le Goater
2022-05-09 17:56 ` Cédric Le Goater
2022-05-09 17:56 ` Cédric Le Goater
2022-05-09 17:56 ` [PATCH v7 08/11] spi: aspeed: Calibrate read timings Cédric Le Goater
2022-05-09 17:56 ` Cédric Le Goater
2022-05-09 17:56 ` Cédric Le Goater
2022-05-09 17:56 ` [PATCH v7 09/11] ARM: dts: aspeed: Enable Dual SPI RX transfers Cédric Le Goater
2022-05-09 17:56 ` Cédric Le Goater
2022-05-09 17:56 ` Cédric Le Goater
2022-05-09 17:56 ` [PATCH v7 10/11] ARM: dts: aspeed-g4: Set spi-max-frequency for all flashes Cédric Le Goater
2022-05-09 17:56 ` Cédric Le Goater
2022-05-09 17:56 ` Cédric Le Goater
2022-05-09 17:56 ` [PATCH v7 11/11] mtd: spi-nor: aspeed: set the decoding size to at least 2MB for AST2600 Cédric Le Goater
2022-05-09 17:56 ` Cédric Le Goater
2022-05-09 17:56 ` Cédric Le Goater
2022-05-16 18:39 ` (subset) [PATCH v7 00/11] spi: spi-mem: Convert Aspeed SMC driver to spi-mem Mark Brown
2022-05-16 18:39 ` Mark Brown
2022-05-16 18:39 ` Mark Brown
2022-05-17 11:05 ` Pratyush Yadav
2022-05-17 11:05 ` Pratyush Yadav
2022-05-17 11:05 ` Pratyush Yadav
2022-05-17 12:03 ` Cédric Le Goater
2022-05-17 12:03 ` Cédric Le Goater
2022-05-17 12:03 ` Cédric Le Goater
2022-05-17 12:33 ` Pratyush Yadav
2022-05-17 12:33 ` Pratyush Yadav
2022-05-17 12:33 ` Pratyush Yadav
2022-05-17 12:37 ` Miquel Raynal
2022-05-17 12:37 ` Miquel Raynal
2022-05-17 12:37 ` Miquel Raynal
2022-05-17 13:41 ` Cédric Le Goater
2022-05-17 13:41 ` Cédric Le Goater
2022-05-17 13:41 ` Cédric Le Goater
2022-05-17 12:10 ` Mark Brown [this message]
2022-05-17 12:10 ` Mark Brown
2022-05-17 12:10 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoOQxJV2xNfkkwQS@sirena.org.uk \
--to=broonie@kernel.org \
--cc=andrew@aj.id.au \
--cc=chin-ting_kuo@aspeedtech.com \
--cc=clg@kaod.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=p.yadav@ti.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.