From: Cristian Marussi <cristian.marussi@arm.com>
To: Michael Riesch <michael.riesch@wolfvision.net>
Cc: linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Heiko Stuebner <heiko@sntech.de>, Liang Chen <cl@rock-chips.com>,
Kever Yang <kever.yang@rock-chips.com>,
Jeffy Chen <jeffy.chen@rock-chips.com>,
Peter Geis <pgwipeout@gmail.com>,
Nicolas Frattaroli <frattaroli.nicolas@gmail.com>,
Etienne Carriere <etienne.carriere@linaro.org>,
Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH] firmware: arm_scmi: Relax BASE protocol sanity checks on protocol list
Date: Mon, 6 Jun 2022 14:31:48 +0100 [thread overview]
Message-ID: <Yp4Br5d0jMnlF5yy@e120937-lin> (raw)
In-Reply-To: <45bf11a8-47eb-e088-ba99-30c8788c7143@wolfvision.net>
On Mon, Jun 06, 2022 at 02:59:10PM +0200, Michael Riesch wrote:
> Hi Cristian,
>
Hi Michael,
> On 5/23/22 19:15, Cristian Marussi wrote:
> > Even though malformed replies from firmware must be treated carefully to
> > avoid memory corruption Kernel side, some out-of-spec SCMI replies can
> > be tolerated to avoid breaking existing deployed system, as long as they
> > won't cause memory issues.
> >
> > Reported-by: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
> > Cc: Etienne Carriere <etienne.carriere@linaro.org>
> > Cc: Sudeep Holla <sudeep.holla@arm.com>
> > Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
>
> Thanks a lot, without this fix the Mali G52 GPU won't probe on my RK3568
> EVB1 in vanilla v5.19-rc1.
>
Yes, the break was reported on -next and today it appeared in 5.19-rc1.
A proper FW fix is also up for review by Etienne but in the meantime
this tries to limit damages relaxing a bit the checks.
> I guess this patch should have a Fixes: tag, right?
>
It has not a Fixes tag because the issue was introduced in 5.19-rc1 and the
fix will go in with the next round of v5.19 fixes by Sudeep (AFAIU) so it
will be solved within the v5.19 cycle and I thought the Fixes tag was
not needed in this case (I could be wrong...)
> Would be great to have this in v5.19. AFAIC:
>
> Acked-by: Michael Riesch <michael.riesch@wolfvision.net>
Thanks for testing it.
Cristian
WARNING: multiple messages have this Message-ID (diff)
From: Cristian Marussi <cristian.marussi@arm.com>
To: Michael Riesch <michael.riesch@wolfvision.net>
Cc: linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Heiko Stuebner <heiko@sntech.de>, Liang Chen <cl@rock-chips.com>,
Kever Yang <kever.yang@rock-chips.com>,
Jeffy Chen <jeffy.chen@rock-chips.com>,
Peter Geis <pgwipeout@gmail.com>,
Nicolas Frattaroli <frattaroli.nicolas@gmail.com>,
Etienne Carriere <etienne.carriere@linaro.org>,
Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH] firmware: arm_scmi: Relax BASE protocol sanity checks on protocol list
Date: Mon, 6 Jun 2022 14:31:48 +0100 [thread overview]
Message-ID: <Yp4Br5d0jMnlF5yy@e120937-lin> (raw)
In-Reply-To: <45bf11a8-47eb-e088-ba99-30c8788c7143@wolfvision.net>
On Mon, Jun 06, 2022 at 02:59:10PM +0200, Michael Riesch wrote:
> Hi Cristian,
>
Hi Michael,
> On 5/23/22 19:15, Cristian Marussi wrote:
> > Even though malformed replies from firmware must be treated carefully to
> > avoid memory corruption Kernel side, some out-of-spec SCMI replies can
> > be tolerated to avoid breaking existing deployed system, as long as they
> > won't cause memory issues.
> >
> > Reported-by: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
> > Cc: Etienne Carriere <etienne.carriere@linaro.org>
> > Cc: Sudeep Holla <sudeep.holla@arm.com>
> > Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
>
> Thanks a lot, without this fix the Mali G52 GPU won't probe on my RK3568
> EVB1 in vanilla v5.19-rc1.
>
Yes, the break was reported on -next and today it appeared in 5.19-rc1.
A proper FW fix is also up for review by Etienne but in the meantime
this tries to limit damages relaxing a bit the checks.
> I guess this patch should have a Fixes: tag, right?
>
It has not a Fixes tag because the issue was introduced in 5.19-rc1 and the
fix will go in with the next round of v5.19 fixes by Sudeep (AFAIU) so it
will be solved within the v5.19 cycle and I thought the Fixes tag was
not needed in this case (I could be wrong...)
> Would be great to have this in v5.19. AFAIC:
>
> Acked-by: Michael Riesch <michael.riesch@wolfvision.net>
Thanks for testing it.
Cristian
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Cristian Marussi <cristian.marussi@arm.com>
To: Michael Riesch <michael.riesch@wolfvision.net>
Cc: linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Heiko Stuebner <heiko@sntech.de>, Liang Chen <cl@rock-chips.com>,
Kever Yang <kever.yang@rock-chips.com>,
Jeffy Chen <jeffy.chen@rock-chips.com>,
Peter Geis <pgwipeout@gmail.com>,
Nicolas Frattaroli <frattaroli.nicolas@gmail.com>,
Etienne Carriere <etienne.carriere@linaro.org>,
Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH] firmware: arm_scmi: Relax BASE protocol sanity checks on protocol list
Date: Mon, 6 Jun 2022 14:31:48 +0100 [thread overview]
Message-ID: <Yp4Br5d0jMnlF5yy@e120937-lin> (raw)
In-Reply-To: <45bf11a8-47eb-e088-ba99-30c8788c7143@wolfvision.net>
On Mon, Jun 06, 2022 at 02:59:10PM +0200, Michael Riesch wrote:
> Hi Cristian,
>
Hi Michael,
> On 5/23/22 19:15, Cristian Marussi wrote:
> > Even though malformed replies from firmware must be treated carefully to
> > avoid memory corruption Kernel side, some out-of-spec SCMI replies can
> > be tolerated to avoid breaking existing deployed system, as long as they
> > won't cause memory issues.
> >
> > Reported-by: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
> > Cc: Etienne Carriere <etienne.carriere@linaro.org>
> > Cc: Sudeep Holla <sudeep.holla@arm.com>
> > Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
>
> Thanks a lot, without this fix the Mali G52 GPU won't probe on my RK3568
> EVB1 in vanilla v5.19-rc1.
>
Yes, the break was reported on -next and today it appeared in 5.19-rc1.
A proper FW fix is also up for review by Etienne but in the meantime
this tries to limit damages relaxing a bit the checks.
> I guess this patch should have a Fixes: tag, right?
>
It has not a Fixes tag because the issue was introduced in 5.19-rc1 and the
fix will go in with the next round of v5.19 fixes by Sudeep (AFAIU) so it
will be solved within the v5.19 cycle and I thought the Fixes tag was
not needed in this case (I could be wrong...)
> Would be great to have this in v5.19. AFAIC:
>
> Acked-by: Michael Riesch <michael.riesch@wolfvision.net>
Thanks for testing it.
Cristian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-06 13:32 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-23 17:15 [PATCH] firmware: arm_scmi: Relax BASE protocol sanity checks on protocol list Cristian Marussi
2022-05-23 17:15 ` Cristian Marussi
2022-05-23 17:15 ` Cristian Marussi
2022-05-31 14:59 ` Etienne Carriere
2022-05-31 14:59 ` Etienne Carriere
2022-05-31 14:59 ` Etienne Carriere
2022-06-06 12:59 ` Michael Riesch
2022-06-06 12:59 ` Michael Riesch
2022-06-06 12:59 ` Michael Riesch
2022-06-06 13:31 ` Cristian Marussi [this message]
2022-06-06 13:31 ` Cristian Marussi
2022-06-06 13:31 ` Cristian Marussi
2022-06-06 14:43 ` Sudeep Holla
2022-06-06 14:43 ` Sudeep Holla
2022-06-06 14:43 ` Sudeep Holla
2022-06-06 14:55 ` Heiko Stübner
2022-06-06 14:55 ` Heiko Stübner
2022-06-06 14:55 ` Heiko Stübner
2022-06-06 15:10 ` Sudeep Holla
2022-06-06 15:10 ` Sudeep Holla
2022-06-06 15:10 ` Sudeep Holla
2022-06-06 14:03 ` Aw: " Frank Wunderlich
2022-06-06 14:03 ` Frank Wunderlich
2022-06-06 14:03 ` Frank Wunderlich
2022-06-06 14:51 ` Sudeep Holla
2022-06-06 14:51 ` Sudeep Holla
2022-06-06 14:51 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yp4Br5d0jMnlF5yy@e120937-lin \
--to=cristian.marussi@arm.com \
--cc=cl@rock-chips.com \
--cc=etienne.carriere@linaro.org \
--cc=frattaroli.nicolas@gmail.com \
--cc=heiko@sntech.de \
--cc=jeffy.chen@rock-chips.com \
--cc=kever.yang@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=michael.riesch@wolfvision.net \
--cc=pgwipeout@gmail.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.