From: Sam Ravnborg <sam@ravnborg.org>
To: Hsin-Yi Wang <hsinyi@chromium.org>
Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Hans de Goede <hdegoede@redhat.com>,
Thierry Reding <thierry.reding@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Philipp Zabel <p.zabel@pengutronix.de>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Matthias Brugger <matthias.bgg@gmail.com>,
dri-devel@lists.freedesktop.org,
linux-mediatek@lists.infradead.org,
Rob Clark <robdclark@chromium.org>,
Stephen Boyd <swboyd@chromium.org>,
Douglas Anderson <dianders@chromium.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/8] Add a panel API to return panel orientation
Date: Mon, 6 Jun 2022 21:28:40 +0200 [thread overview]
Message-ID: <Yp5VaBd8slSSnQAs@ravnborg.org> (raw)
In-Reply-To: <20220606152431.1889185-1-hsinyi@chromium.org>
Hi Hsin-Yi,
thanks for this nice series.
On Mon, Jun 06, 2022 at 11:24:23PM +0800, Hsin-Yi Wang wrote:
> Panels usually call drm_connector_set_panel_orientation(), which is
> later than drm/kms driver calling drm_dev_register(). This leads to a
> WARN()[1].
>
> The orientation property is known earlier. For example, some panels
> parse the property through device tree during probe.
>
> The series add a panel API drm_panel_get_orientation() for drm/kms
> drivers. The drivers can use the API to get panel's orientation, so they
> can call drm_connector_set_panel_orientation() before drm_dev_register().
>
> Panel needs to implement .get_orientation callback to return the property.
The following comment appears in every panel driver:
+ /*
+ * drm drivers are expected to call drm_panel_get_orientation() to get
+ * panel's orientation then drm_connector_set_panel_orientation() to
+ * set the property before drm_dev_register(). Otherwise there will be
+ * a WARN_ON if orientation is set after drm is registered.
+ */
Please move it to the drm_panel c or h file, it is noise to add it to
all panel drivers.
Sam
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Hsin-Yi Wang <hsinyi@chromium.org>
Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Hans de Goede <hdegoede@redhat.com>,
Thierry Reding <thierry.reding@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Philipp Zabel <p.zabel@pengutronix.de>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Matthias Brugger <matthias.bgg@gmail.com>,
dri-devel@lists.freedesktop.org,
linux-mediatek@lists.infradead.org,
Rob Clark <robdclark@chromium.org>,
Stephen Boyd <swboyd@chromium.org>,
Douglas Anderson <dianders@chromium.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/8] Add a panel API to return panel orientation
Date: Mon, 6 Jun 2022 21:28:40 +0200 [thread overview]
Message-ID: <Yp5VaBd8slSSnQAs@ravnborg.org> (raw)
In-Reply-To: <20220606152431.1889185-1-hsinyi@chromium.org>
Hi Hsin-Yi,
thanks for this nice series.
On Mon, Jun 06, 2022 at 11:24:23PM +0800, Hsin-Yi Wang wrote:
> Panels usually call drm_connector_set_panel_orientation(), which is
> later than drm/kms driver calling drm_dev_register(). This leads to a
> WARN()[1].
>
> The orientation property is known earlier. For example, some panels
> parse the property through device tree during probe.
>
> The series add a panel API drm_panel_get_orientation() for drm/kms
> drivers. The drivers can use the API to get panel's orientation, so they
> can call drm_connector_set_panel_orientation() before drm_dev_register().
>
> Panel needs to implement .get_orientation callback to return the property.
The following comment appears in every panel driver:
+ /*
+ * drm drivers are expected to call drm_panel_get_orientation() to get
+ * panel's orientation then drm_connector_set_panel_orientation() to
+ * set the property before drm_dev_register(). Otherwise there will be
+ * a WARN_ON if orientation is set after drm is registered.
+ */
Please move it to the drm_panel c or h file, it is noise to add it to
all panel drivers.
Sam
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Hsin-Yi Wang <hsinyi@chromium.org>
Cc: Rob Clark <robdclark@chromium.org>,
Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Rob Herring <robh+dt@kernel.org>, David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org,
Douglas Anderson <dianders@chromium.org>,
Stephen Boyd <swboyd@chromium.org>,
Hans de Goede <hdegoede@redhat.com>,
Thierry Reding <thierry.reding@gmail.com>,
linux-mediatek@lists.infradead.org,
dri-devel@lists.freedesktop.org,
Thomas Zimmermann <tzimmermann@suse.de>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 0/8] Add a panel API to return panel orientation
Date: Mon, 6 Jun 2022 21:28:40 +0200 [thread overview]
Message-ID: <Yp5VaBd8slSSnQAs@ravnborg.org> (raw)
In-Reply-To: <20220606152431.1889185-1-hsinyi@chromium.org>
Hi Hsin-Yi,
thanks for this nice series.
On Mon, Jun 06, 2022 at 11:24:23PM +0800, Hsin-Yi Wang wrote:
> Panels usually call drm_connector_set_panel_orientation(), which is
> later than drm/kms driver calling drm_dev_register(). This leads to a
> WARN()[1].
>
> The orientation property is known earlier. For example, some panels
> parse the property through device tree during probe.
>
> The series add a panel API drm_panel_get_orientation() for drm/kms
> drivers. The drivers can use the API to get panel's orientation, so they
> can call drm_connector_set_panel_orientation() before drm_dev_register().
>
> Panel needs to implement .get_orientation callback to return the property.
The following comment appears in every panel driver:
+ /*
+ * drm drivers are expected to call drm_panel_get_orientation() to get
+ * panel's orientation then drm_connector_set_panel_orientation() to
+ * set the property before drm_dev_register(). Otherwise there will be
+ * a WARN_ON if orientation is set after drm is registered.
+ */
Please move it to the drm_panel c or h file, it is noise to add it to
all panel drivers.
Sam
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Hsin-Yi Wang <hsinyi@chromium.org>
Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Hans de Goede <hdegoede@redhat.com>,
Thierry Reding <thierry.reding@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Philipp Zabel <p.zabel@pengutronix.de>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Matthias Brugger <matthias.bgg@gmail.com>,
dri-devel@lists.freedesktop.org,
linux-mediatek@lists.infradead.org,
Rob Clark <robdclark@chromium.org>,
Stephen Boyd <swboyd@chromium.org>,
Douglas Anderson <dianders@chromium.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/8] Add a panel API to return panel orientation
Date: Mon, 6 Jun 2022 21:28:40 +0200 [thread overview]
Message-ID: <Yp5VaBd8slSSnQAs@ravnborg.org> (raw)
In-Reply-To: <20220606152431.1889185-1-hsinyi@chromium.org>
Hi Hsin-Yi,
thanks for this nice series.
On Mon, Jun 06, 2022 at 11:24:23PM +0800, Hsin-Yi Wang wrote:
> Panels usually call drm_connector_set_panel_orientation(), which is
> later than drm/kms driver calling drm_dev_register(). This leads to a
> WARN()[1].
>
> The orientation property is known earlier. For example, some panels
> parse the property through device tree during probe.
>
> The series add a panel API drm_panel_get_orientation() for drm/kms
> drivers. The drivers can use the API to get panel's orientation, so they
> can call drm_connector_set_panel_orientation() before drm_dev_register().
>
> Panel needs to implement .get_orientation callback to return the property.
The following comment appears in every panel driver:
+ /*
+ * drm drivers are expected to call drm_panel_get_orientation() to get
+ * panel's orientation then drm_connector_set_panel_orientation() to
+ * set the property before drm_dev_register(). Otherwise there will be
+ * a WARN_ON if orientation is set after drm is registered.
+ */
Please move it to the drm_panel c or h file, it is noise to add it to
all panel drivers.
Sam
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-06 19:28 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-06 15:24 [PATCH v4 0/8] Add a panel API to return panel orientation Hsin-Yi Wang
2022-06-06 15:24 ` Hsin-Yi Wang
2022-06-06 15:24 ` Hsin-Yi Wang
2022-06-06 15:24 ` Hsin-Yi Wang
2022-06-06 15:24 ` [PATCH v4 1/8] drm/panel: Add an API drm_panel_get_orientation() " Hsin-Yi Wang
2022-06-06 15:24 ` Hsin-Yi Wang
2022-06-06 15:24 ` Hsin-Yi Wang
2022-06-06 15:24 ` Hsin-Yi Wang
2022-06-06 19:06 ` Stephen Boyd
2022-06-06 19:06 ` Stephen Boyd
2022-06-06 19:06 ` Stephen Boyd
2022-06-06 19:06 ` Stephen Boyd
2022-06-07 7:53 ` Hsin-Yi Wang
2022-06-07 7:53 ` Hsin-Yi Wang
2022-06-07 7:53 ` Hsin-Yi Wang
2022-06-07 7:53 ` Hsin-Yi Wang
2022-06-06 19:20 ` Sam Ravnborg
2022-06-06 19:20 ` Sam Ravnborg
2022-06-06 19:20 ` Sam Ravnborg
2022-06-06 19:20 ` Sam Ravnborg
2022-06-06 20:15 ` Hans de Goede
2022-06-06 20:15 ` Hans de Goede
2022-06-06 20:15 ` Hans de Goede
2022-06-06 20:15 ` Hans de Goede
2022-06-06 20:50 ` Sam Ravnborg
2022-06-06 20:50 ` Sam Ravnborg
2022-06-06 20:50 ` Sam Ravnborg
2022-06-06 20:50 ` Sam Ravnborg
2022-06-06 15:24 ` [PATCH v4 2/8] drm/panel: boe-tv101wum-nl6: Implement .get_orientation callback Hsin-Yi Wang
2022-06-06 15:24 ` Hsin-Yi Wang
2022-06-06 15:24 ` Hsin-Yi Wang
2022-06-06 15:24 ` Hsin-Yi Wang
2022-06-06 15:24 ` [PATCH v4 3/8] drm/panel: panel-edp: " Hsin-Yi Wang
2022-06-06 15:24 ` Hsin-Yi Wang
2022-06-06 15:24 ` Hsin-Yi Wang
2022-06-06 15:24 ` Hsin-Yi Wang
2022-06-06 15:24 ` [PATCH v4 4/8] drm/panel: lvds: " Hsin-Yi Wang
2022-06-06 15:24 ` Hsin-Yi Wang
2022-06-06 15:24 ` Hsin-Yi Wang
2022-06-06 15:24 ` Hsin-Yi Wang
2022-06-06 19:08 ` Stephen Boyd
2022-06-06 19:08 ` Stephen Boyd
2022-06-06 19:08 ` Stephen Boyd
2022-06-06 19:08 ` Stephen Boyd
2022-06-06 15:24 ` [PATCH v4 5/8] drm/panel: panel-simple: " Hsin-Yi Wang
2022-06-06 15:24 ` Hsin-Yi Wang
2022-06-06 15:24 ` Hsin-Yi Wang
2022-06-06 15:24 ` Hsin-Yi Wang
2022-06-06 19:25 ` Sam Ravnborg
2022-06-06 19:25 ` Sam Ravnborg
2022-06-06 19:25 ` Sam Ravnborg
2022-06-06 19:25 ` Sam Ravnborg
2022-06-07 3:54 ` Hsin-Yi Wang
2022-06-07 3:54 ` Hsin-Yi Wang
2022-06-07 3:54 ` Hsin-Yi Wang
2022-06-07 3:54 ` Hsin-Yi Wang
2022-06-06 15:24 ` [PATCH v4 6/8] drm/panel: ili9881c: " Hsin-Yi Wang
2022-06-06 15:24 ` Hsin-Yi Wang
2022-06-06 15:24 ` Hsin-Yi Wang
2022-06-06 15:24 ` Hsin-Yi Wang
2022-06-06 15:24 ` [PATCH v4 7/8] drm/panel: elida-kd35t133: " Hsin-Yi Wang
2022-06-06 15:24 ` Hsin-Yi Wang
2022-06-06 15:24 ` Hsin-Yi Wang
2022-06-06 15:24 ` Hsin-Yi Wang
2022-06-06 15:24 ` [PATCH v4 8/8] drm/mediatek: Config orientation property if panel provides it Hsin-Yi Wang
2022-06-06 15:24 ` Hsin-Yi Wang
2022-06-06 15:24 ` Hsin-Yi Wang
2022-06-06 15:24 ` Hsin-Yi Wang
2022-06-06 19:16 ` Stephen Boyd
2022-06-06 19:16 ` Stephen Boyd
2022-06-06 19:16 ` Stephen Boyd
2022-06-06 19:16 ` Stephen Boyd
2022-06-07 3:46 ` Hsin-Yi Wang
2022-06-07 3:46 ` Hsin-Yi Wang
2022-06-07 3:46 ` Hsin-Yi Wang
2022-06-07 3:46 ` Hsin-Yi Wang
2022-06-06 19:31 ` Sam Ravnborg
2022-06-06 19:31 ` Sam Ravnborg
2022-06-06 19:31 ` Sam Ravnborg
2022-06-06 19:31 ` Sam Ravnborg
2022-06-07 3:53 ` Hsin-Yi Wang
2022-06-07 3:53 ` Hsin-Yi Wang
2022-06-07 3:53 ` Hsin-Yi Wang
2022-06-07 3:53 ` Hsin-Yi Wang
2022-06-06 19:28 ` Sam Ravnborg [this message]
2022-06-06 19:28 ` [PATCH v4 0/8] Add a panel API to return panel orientation Sam Ravnborg
2022-06-06 19:28 ` Sam Ravnborg
2022-06-06 19:28 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yp5VaBd8slSSnQAs@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=chunkuang.hu@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=hsinyi@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=matthias.bgg@gmail.com \
--cc=mripard@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robdclark@chromium.org \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
--cc=thierry.reding@gmail.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.