Re: [PATCH 1/4] certs/blacklist_hashes.c: fix const confusion in certs blacklist

From: Jarkko Sakkinen <jarkko@kernel.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org,
	"David Howells" <dhowells@redhat.com>,
	"Micka���l Sala���n" <mic@linux.microsoft.com>,
	"David Woodhouse" <dwmw2@infradead.org>,
	keyrings@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] certs/blacklist_hashes.c: fix const confusion in certs blacklist
Date: Wed, 15 Jun 2022 21:46:07 +0300	[thread overview]
Message-ID: <Yqoo7xyJHhfC8RbV@iki.fi> (raw)
In-Reply-To: <20220611172233.1494073-1-masahiroy@kernel.org>

On Sun, Jun 12, 2022 at 02:22:30AM +0900, Masahiro Yamada wrote:
> This file fails to compile as follows:
> 
>   CC      certs/blacklist_hashes.o
> certs/blacklist_hashes.c:4:1: error: ignoring attribute ‘section (".init.data")’ because it conflicts with previous ‘section (".init.rodata")’ [-Werror=attributes]
>     4 | const char __initdata *const blacklist_hashes[] = {
>       | ^~~~~
> In file included from certs/blacklist_hashes.c:2:
> certs/blacklist.h:5:38: note: previous declaration here
>     5 | extern const char __initconst *const blacklist_hashes[];
>       |                                      ^~~~~~~~~~~~~~~~
> 
> Apply the same fix as commit 2be04df5668d ("certs/blacklist_nohashes.c:
> fix const confusion in certs blacklist").
> 
> Fixes: 734114f8782f ("KEYS: Add a system blacklist keyring")
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
> 
>  certs/blacklist_hashes.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/certs/blacklist_hashes.c b/certs/blacklist_hashes.c
> index 344892337be0..d5961aa3d338 100644
> --- a/certs/blacklist_hashes.c
> +++ b/certs/blacklist_hashes.c
> @@ -1,7 +1,7 @@
>  // SPDX-License-Identifier: GPL-2.0
>  #include "blacklist.h"
>  
> -const char __initdata *const blacklist_hashes[] = {
> +const char __initconst *const blacklist_hashes[] = {
>  #include CONFIG_SYSTEM_BLACKLIST_HASH_LIST
>  	, NULL
>  };
> -- 
> 2.32.0
> 

Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>

BR, Jarkko