Re: [PATCH 1/4] certs/blacklist_hashes.c: fix const confusion in certs blacklist

From: "Mickaël Salaün" <mic@digikod.net>
To: Masahiro Yamada <masahiroy@kernel.org>, linux-kbuild@vger.kernel.org
Cc: David Howells <dhowells@redhat.com>,
	Jarkko Sakkinen <jarkko@kernel.org>,
	David Woodhouse <dwmw2@infradead.org>,
	keyrings@vger.kernel.org, linux-kernel@vger.kernel.org,
	Eric Snowberg <eric.snowberg@oracle.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Tyler Hicks <tyhicks@linux.microsoft.com>
Subject: Re: [PATCH 1/4] certs/blacklist_hashes.c: fix const confusion in certs blacklist
Date: Mon, 13 Jun 2022 14:20:00 +0200	[thread overview]
Message-ID: <ff05d732-3202-7c9c-0d4c-d95101ed6ba3@digikod.net> (raw)
In-Reply-To: <20220611172233.1494073-1-masahiroy@kernel.org>


On 11/06/2022 19:22, Masahiro Yamada wrote:
> This file fails to compile as follows:
> 
>    CC      certs/blacklist_hashes.o
> certs/blacklist_hashes.c:4:1: error: ignoring attribute ‘section (".init.data")’ because it conflicts with previous ‘section (".init.rodata")’ [-Werror=attributes]
>      4 | const char __initdata *const blacklist_hashes[] = {
>        | ^~~~~
> In file included from certs/blacklist_hashes.c:2:
> certs/blacklist.h:5:38: note: previous declaration here
>      5 | extern const char __initconst *const blacklist_hashes[];
>        |                                      ^~~~~~~~~~~~~~~~
> 
> Apply the same fix as commit 2be04df5668d ("certs/blacklist_nohashes.c:
> fix const confusion in certs blacklist").
> 
> Fixes: 734114f8782f ("KEYS: Add a system blacklist keyring")
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

Reviewed-by: Mickaël Salaün <mic@linux.microsoft.com>

> ---
> 
>   certs/blacklist_hashes.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/certs/blacklist_hashes.c b/certs/blacklist_hashes.c
> index 344892337be0..d5961aa3d338 100644
> --- a/certs/blacklist_hashes.c
> +++ b/certs/blacklist_hashes.c
> @@ -1,7 +1,7 @@
>   // SPDX-License-Identifier: GPL-2.0
>   #include "blacklist.h"
>   
> -const char __initdata *const blacklist_hashes[] = {
> +const char __initconst *const blacklist_hashes[] = {
>   #include CONFIG_SYSTEM_BLACKLIST_HASH_LIST
>   	, NULL
>   };