From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Alexander Lobakin <alexandr.lobakin@intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Yury Norov <yury.norov@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
Matt Turner <mattst88@gmail.com>, Brian Cain <bcain@quicinc.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
"David S. Miller" <davem@davemloft.net>,
Kees Cook <keescook@chromium.org>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Marco Elver <elver@google.com>, Borislav Petkov <bp@suse.de>,
Tony Luck <tony.luck@intel.com>,
Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-alpha@vger.kernel.org, linux-hexagon@vger.kernel.org,
linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
linux-sh@vger.kernel.org, sparclinux@vger.kernel.org,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/8] bitops: let optimize out non-atomic bitops on compile-time constants
Date: Wed, 22 Jun 2022 17:22:38 +0300 [thread overview]
Message-ID: <YrMlrjbue7twWLk1@smile.fi.intel.com> (raw)
In-Reply-To: <20220622122440.87087-1-alexandr.lobakin@intel.com>
On Wed, Jun 22, 2022 at 02:24:40PM +0200, Alexander Lobakin wrote:
> From: Alexander Lobakin <alexandr.lobakin@intel.com>
> Date: Tue, 21 Jun 2022 21:15:45 +0200
>
> > While I was working on converting some structure fields from a fixed
> > type to a bitmap, I started observing code size increase not only in
> > places where the code works with the converted structure fields, but
> > also where the converted vars were on the stack. That said, the
> > following code:
>
> [...]
>
> Oh gosh, now s390 failed and 7/8 revealed one existing code flaw in
> the ice driver.
> I'll fix those, then will try to test more platforms (to not spam
> series again) and send v5 soon (mentioning this as bots CCs only
> myself).
One mail per person? Because I also got a report.
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Alexander Lobakin <alexandr.lobakin@intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Yury Norov <yury.norov@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
Matt Turner <mattst88@gmail.com>, Brian Cain <bcain@quicinc.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
"David S. Miller" <davem@davemloft.net>,
Kees Cook <keescook@chromium.org>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Marco Elver <elver@google.com>, Borislav Petkov <bp@suse.de>,
Tony Luck <tony.luck@intel.com>,
Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-alpha@vger.kernel.org, linux-hexagon@vger.kernel.org,
linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
linux-sh@vger.kernel.org, sparclinux@vger.kernel.org,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/8] bitops: let optimize out non-atomic bitops on compile-time constants
Date: Wed, 22 Jun 2022 14:22:38 +0000 [thread overview]
Message-ID: <YrMlrjbue7twWLk1@smile.fi.intel.com> (raw)
In-Reply-To: <20220622122440.87087-1-alexandr.lobakin@intel.com>
On Wed, Jun 22, 2022 at 02:24:40PM +0200, Alexander Lobakin wrote:
> From: Alexander Lobakin <alexandr.lobakin@intel.com>
> Date: Tue, 21 Jun 2022 21:15:45 +0200
>
> > While I was working on converting some structure fields from a fixed
> > type to a bitmap, I started observing code size increase not only in
> > places where the code works with the converted structure fields, but
> > also where the converted vars were on the stack. That said, the
> > following code:
>
> [...]
>
> Oh gosh, now s390 failed and 7/8 revealed one existing code flaw in
> the ice driver.
> I'll fix those, then will try to test more platforms (to not spam
> series again) and send v5 soon (mentioning this as bots CCs only
> myself).
One mail per person? Because I also got a report.
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Alexander Lobakin <alexandr.lobakin@intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Yury Norov <yury.norov@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
Matt Turner <mattst88@gmail.com>, Brian Cain <bcain@quicinc.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
"David S. Miller" <davem@davemloft.net>,
Kees Cook <keescook@chromium.org>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Marco Elver <elver@google.com>, Borislav Petkov <bp@suse.de>,
Tony Luck <tony.luck@intel.com>,
Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-alpha@vger.kernel.org, linux-hexagon@vger.kernel.org,
linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m6
Subject: Re: [PATCH v4 0/8] bitops: let optimize out non-atomic bitops on compile-time constants
Date: Wed, 22 Jun 2022 17:22:38 +0300 [thread overview]
Message-ID: <YrMlrjbue7twWLk1@smile.fi.intel.com> (raw)
In-Reply-To: <20220622122440.87087-1-alexandr.lobakin@intel.com>
On Wed, Jun 22, 2022 at 02:24:40PM +0200, Alexander Lobakin wrote:
> From: Alexander Lobakin <alexandr.lobakin@intel.com>
> Date: Tue, 21 Jun 2022 21:15:45 +0200
>
> > While I was working on converting some structure fields from a fixed
> > type to a bitmap, I started observing code size increase not only in
> > places where the code works with the converted structure fields, but
> > also where the converted vars were on the stack. That said, the
> > following code:
>
> [...]
>
> Oh gosh, now s390 failed and 7/8 revealed one existing code flaw in
> the ice driver.
> I'll fix those, then will try to test more platforms (to not spam
> series again) and send v5 soon (mentioning this as bots CCs only
> myself).
One mail per person? Because I also got a report.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-06-22 14:22 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 19:15 [PATCH v4 0/8] bitops: let optimize out non-atomic bitops on compile-time constants Alexander Lobakin
2022-06-21 19:15 ` Alexander Lobakin
2022-06-21 19:15 ` Alexander Lobakin
2022-06-21 19:15 ` [PATCH v4 1/8] ia64, processor: fix -Wincompatible-pointer-types in ia64_get_irr() Alexander Lobakin
2022-06-21 19:15 ` Alexander Lobakin
2022-06-21 19:15 ` Alexander Lobakin
2022-06-21 19:15 ` [PATCH v4 2/8] bitops: always define asm-generic non-atomic bitops Alexander Lobakin
2022-06-21 19:15 ` Alexander Lobakin
2022-06-21 19:15 ` Alexander Lobakin
2022-06-21 19:15 ` [PATCH v4 3/8] bitops: unify non-atomic bitops prototypes across architectures Alexander Lobakin
2022-06-21 19:15 ` Alexander Lobakin
2022-06-21 19:15 ` Alexander Lobakin
2022-06-21 19:15 ` [PATCH v4 4/8] bitops: define const_*() versions of the non-atomics Alexander Lobakin
2022-06-21 19:15 ` Alexander Lobakin
2022-06-21 19:15 ` Alexander Lobakin
2022-06-21 19:15 ` [PATCH v4 5/8] bitops: wrap non-atomic bitops with a transparent macro Alexander Lobakin
2022-06-21 19:15 ` Alexander Lobakin
2022-06-21 19:15 ` Alexander Lobakin
2022-06-21 19:15 ` [PATCH v4 6/8] bitops: let optimize out non-atomic bitops on compile-time constants Alexander Lobakin
2022-06-21 19:15 ` Alexander Lobakin
2022-06-21 19:15 ` Alexander Lobakin
2022-06-21 19:15 ` [PATCH v4 7/8] bitmap: don't assume compiler evaluates small mem*() builtins calls Alexander Lobakin
2022-06-21 19:15 ` Alexander Lobakin
2022-06-21 19:15 ` Alexander Lobakin
2022-06-21 19:15 ` [PATCH v4 8/8] lib: test_bitmap: add compile-time optimization/evaluations assertions Alexander Lobakin
2022-06-21 19:15 ` Alexander Lobakin
2022-06-21 19:15 ` Alexander Lobakin
2022-06-22 16:04 ` Alexander Lobakin
2022-06-22 16:04 ` Alexander Lobakin
2022-06-22 16:04 ` Alexander Lobakin
2022-06-22 12:24 ` [PATCH v4 0/8] bitops: let optimize out non-atomic bitops on compile-time constants Alexander Lobakin
2022-06-22 12:24 ` Alexander Lobakin
2022-06-22 12:24 ` Alexander Lobakin
2022-06-22 14:22 ` Andy Shevchenko [this message]
2022-06-22 14:22 ` Andy Shevchenko
2022-06-22 14:22 ` Andy Shevchenko
2022-06-22 14:37 ` Alexander Lobakin
2022-06-22 14:37 ` Alexander Lobakin
2022-06-22 14:37 ` Alexander Lobakin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrMlrjbue7twWLk1@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alexandr.lobakin@intel.com \
--cc=arnd@arndb.de \
--cc=bcain@quicinc.com \
--cc=bp@suse.de \
--cc=dalias@libc.org \
--cc=davem@davemloft.net \
--cc=elver@google.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=jesse.brandeburg@intel.com \
--cc=keescook@chromium.org \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-sh@vger.kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=mark.rutland@arm.com \
--cc=mattst88@gmail.com \
--cc=peterz@infradead.org \
--cc=sparclinux@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=ysato@users.sourceforge.jp \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.