Re: [PATCH -next] drm: Remove unnecessary print function dev_err()

From: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: airlied@linux.ie, daniel@ffwll.ch,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] drm: Remove unnecessary print function dev_err()
Date: Fri, 24 Jun 2022 17:26:21 +0200	[thread overview]
Message-ID: <YrXXnfFLrYFXInvJ@aptenodytes> (raw)
In-Reply-To: <YrXRplhnlUZ2KV3V@aptenodytes>

[-- Attachment #1: Type: text/plain, Size: 1511 bytes --]

Hi,

On Fri 24 Jun 22, 17:00, Paul Kocialkowski wrote:
> Hi Yang,
> 
> On Mon 13 Jun 22, 09:26, Yang Li wrote:
> > The print function dev_err() is redundant because platform_get_irq()
> > already prints an error.
> > 
> > Eliminate the follow coccicheck warning:
> > ./drivers/gpu/drm/logicvc/logicvc_drm.c:352:2-9: line 352 is redundant
> > because platform_get_irq() already prints an error
> > 
> > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> 
> Thanks for the patch!
> 
> Acked-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>

Pushed to drm-misc-next, thanks!

Paul

> > ---
> >  drivers/gpu/drm/logicvc/logicvc_drm.c | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/logicvc/logicvc_drm.c b/drivers/gpu/drm/logicvc/logicvc_drm.c
> > index df1805cf0f95..437b3011ae1e 100644
> > --- a/drivers/gpu/drm/logicvc/logicvc_drm.c
> > +++ b/drivers/gpu/drm/logicvc/logicvc_drm.c
> > @@ -349,7 +349,6 @@ static int logicvc_drm_probe(struct platform_device *pdev)
> >  
> >  	irq = platform_get_irq(pdev, 0);
> >  	if (irq < 0) {
> > -		dev_err(dev, "Failed to get IRQ\n");
> >  		ret = -ENODEV;
> >  		goto error_reserved_mem;
> >  	}
> > -- 
> > 2.20.1.7.g153144c
> > 
> 
> -- 
> Paul Kocialkowski, Bootlin
> Embedded Linux and kernel engineering
> https://bootlin.com

-- 
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 484 bytes --]