From: Ionela Voinescu <ionela.voinescu@arm.com>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: linux-kernel@vger.kernel.org,
Greg KH <gregkh@linuxfoundation.org>,
Atish Patra <atishp@atishpatra.org>,
Atish Patra <atishp@rivosinc.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Qing Wang <wangqing@vivo.com>, Rob Herring <robh+dt@kernel.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Pierre Gondois <pierre.gondois@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH v4 15/20] arch_topology: Don't set cluster identifier as physical package identifier
Date: Mon, 27 Jun 2022 14:43:47 +0100 [thread overview]
Message-ID: <Yrm0E3mFHvJ5Nkgt@arm.com> (raw)
In-Reply-To: <20220621192034.3332546-16-sudeep.holla@arm.com>
On Tuesday 21 Jun 2022 at 20:20:29 (+0100), Sudeep Holla wrote:
> Currently as we parse the CPU topology from /cpu-map node from the
> device tree, we assign generated cluster count as the physical package
> identifier for each CPU which is wrong.
>
> The device tree bindings for CPU topology supports sockets to infer
> the socket or physical package identifier for a given CPU. Since it is
> fairly new and not support on most of the old and existing systems, we
^^^^^^^
Nit: supported
> can assume all such systems have single socket/physical package.
>
> Fix the physical package identifier to 0 by removing the assignment of
> cluster identifier to the same.
>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Reviewed-by: Ionela Voinescu <ionela.voinescu@arm.com>
Thanks,
Ionela.
> ---
> drivers/base/arch_topology.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c
> index 7a569aefe313..46fa1b70b02b 100644
> --- a/drivers/base/arch_topology.c
> +++ b/drivers/base/arch_topology.c
> @@ -549,7 +549,6 @@ static int __init parse_cluster(struct device_node *cluster, int depth)
> bool leaf = true;
> bool has_cores = false;
> struct device_node *c;
> - static int package_id __initdata;
> int core_id = 0;
> int i, ret;
>
> @@ -588,7 +587,7 @@ static int __init parse_cluster(struct device_node *cluster, int depth)
> }
>
> if (leaf) {
> - ret = parse_core(c, package_id, core_id++);
> + ret = parse_core(c, 0, core_id++);
> } else {
> pr_err("%pOF: Non-leaf cluster with core %s\n",
> cluster, name);
> @@ -605,9 +604,6 @@ static int __init parse_cluster(struct device_node *cluster, int depth)
> if (leaf && !has_cores)
> pr_warn("%pOF: empty cluster\n", cluster);
>
> - if (leaf)
> - package_id++;
> -
> return 0;
> }
>
> --
> 2.36.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Ionela Voinescu <ionela.voinescu@arm.com>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: linux-kernel@vger.kernel.org,
Greg KH <gregkh@linuxfoundation.org>,
Atish Patra <atishp@atishpatra.org>,
Atish Patra <atishp@rivosinc.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Qing Wang <wangqing@vivo.com>, Rob Herring <robh+dt@kernel.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Pierre Gondois <pierre.gondois@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH v4 15/20] arch_topology: Don't set cluster identifier as physical package identifier
Date: Mon, 27 Jun 2022 14:43:47 +0100 [thread overview]
Message-ID: <Yrm0E3mFHvJ5Nkgt@arm.com> (raw)
In-Reply-To: <20220621192034.3332546-16-sudeep.holla@arm.com>
On Tuesday 21 Jun 2022 at 20:20:29 (+0100), Sudeep Holla wrote:
> Currently as we parse the CPU topology from /cpu-map node from the
> device tree, we assign generated cluster count as the physical package
> identifier for each CPU which is wrong.
>
> The device tree bindings for CPU topology supports sockets to infer
> the socket or physical package identifier for a given CPU. Since it is
> fairly new and not support on most of the old and existing systems, we
^^^^^^^
Nit: supported
> can assume all such systems have single socket/physical package.
>
> Fix the physical package identifier to 0 by removing the assignment of
> cluster identifier to the same.
>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Reviewed-by: Ionela Voinescu <ionela.voinescu@arm.com>
Thanks,
Ionela.
> ---
> drivers/base/arch_topology.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c
> index 7a569aefe313..46fa1b70b02b 100644
> --- a/drivers/base/arch_topology.c
> +++ b/drivers/base/arch_topology.c
> @@ -549,7 +549,6 @@ static int __init parse_cluster(struct device_node *cluster, int depth)
> bool leaf = true;
> bool has_cores = false;
> struct device_node *c;
> - static int package_id __initdata;
> int core_id = 0;
> int i, ret;
>
> @@ -588,7 +587,7 @@ static int __init parse_cluster(struct device_node *cluster, int depth)
> }
>
> if (leaf) {
> - ret = parse_core(c, package_id, core_id++);
> + ret = parse_core(c, 0, core_id++);
> } else {
> pr_err("%pOF: Non-leaf cluster with core %s\n",
> cluster, name);
> @@ -605,9 +604,6 @@ static int __init parse_cluster(struct device_node *cluster, int depth)
> if (leaf && !has_cores)
> pr_warn("%pOF: empty cluster\n", cluster);
>
> - if (leaf)
> - package_id++;
> -
> return 0;
> }
>
> --
> 2.36.1
>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Ionela Voinescu <ionela.voinescu@arm.com>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: linux-kernel@vger.kernel.org,
Greg KH <gregkh@linuxfoundation.org>,
Atish Patra <atishp@atishpatra.org>,
Atish Patra <atishp@rivosinc.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Qing Wang <wangqing@vivo.com>, Rob Herring <robh+dt@kernel.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Pierre Gondois <pierre.gondois@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH v4 15/20] arch_topology: Don't set cluster identifier as physical package identifier
Date: Mon, 27 Jun 2022 14:43:47 +0100 [thread overview]
Message-ID: <Yrm0E3mFHvJ5Nkgt@arm.com> (raw)
In-Reply-To: <20220621192034.3332546-16-sudeep.holla@arm.com>
On Tuesday 21 Jun 2022 at 20:20:29 (+0100), Sudeep Holla wrote:
> Currently as we parse the CPU topology from /cpu-map node from the
> device tree, we assign generated cluster count as the physical package
> identifier for each CPU which is wrong.
>
> The device tree bindings for CPU topology supports sockets to infer
> the socket or physical package identifier for a given CPU. Since it is
> fairly new and not support on most of the old and existing systems, we
^^^^^^^
Nit: supported
> can assume all such systems have single socket/physical package.
>
> Fix the physical package identifier to 0 by removing the assignment of
> cluster identifier to the same.
>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Reviewed-by: Ionela Voinescu <ionela.voinescu@arm.com>
Thanks,
Ionela.
> ---
> drivers/base/arch_topology.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c
> index 7a569aefe313..46fa1b70b02b 100644
> --- a/drivers/base/arch_topology.c
> +++ b/drivers/base/arch_topology.c
> @@ -549,7 +549,6 @@ static int __init parse_cluster(struct device_node *cluster, int depth)
> bool leaf = true;
> bool has_cores = false;
> struct device_node *c;
> - static int package_id __initdata;
> int core_id = 0;
> int i, ret;
>
> @@ -588,7 +587,7 @@ static int __init parse_cluster(struct device_node *cluster, int depth)
> }
>
> if (leaf) {
> - ret = parse_core(c, package_id, core_id++);
> + ret = parse_core(c, 0, core_id++);
> } else {
> pr_err("%pOF: Non-leaf cluster with core %s\n",
> cluster, name);
> @@ -605,9 +604,6 @@ static int __init parse_cluster(struct device_node *cluster, int depth)
> if (leaf && !has_cores)
> pr_warn("%pOF: empty cluster\n", cluster);
>
> - if (leaf)
> - package_id++;
> -
> return 0;
> }
>
> --
> 2.36.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-27 13:43 UTC|newest]
Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 19:20 [PATCH v4 00/20] arch_topology: Updates to add socket support and fix cluster ids Sudeep Holla
2022-06-21 19:20 ` Sudeep Holla
2022-06-21 19:20 ` Sudeep Holla
2022-06-21 19:20 ` [PATCH v4 01/20] ACPI: PPTT: Use table offset as fw_token instead of virtual address Sudeep Holla
2022-06-21 19:20 ` Sudeep Holla
2022-06-21 19:20 ` Sudeep Holla
2022-06-22 11:47 ` Rafael J. Wysocki
2022-06-22 11:47 ` Rafael J. Wysocki
2022-06-22 11:47 ` Rafael J. Wysocki
2022-06-27 13:41 ` Ionela Voinescu
2022-06-27 13:41 ` Ionela Voinescu
2022-06-27 13:41 ` Ionela Voinescu
2022-06-21 19:20 ` [PATCH v4 02/20] cacheinfo: Use of_cpu_device_node_get instead cpu_dev->of_node Sudeep Holla
2022-06-21 19:20 ` Sudeep Holla
2022-06-21 19:20 ` Sudeep Holla
2022-06-21 19:20 ` [PATCH v4 03/20] cacheinfo: Add helper to access any cache index for a given CPU Sudeep Holla
2022-06-21 19:20 ` Sudeep Holla
2022-06-21 19:20 ` Sudeep Holla
2022-06-21 19:20 ` [PATCH v4 04/20] cacheinfo: Move cache_leaves_are_shared out of CONFIG_OF Sudeep Holla
2022-06-21 19:20 ` Sudeep Holla
2022-06-21 19:20 ` Sudeep Holla
2022-06-21 19:20 ` [PATCH v4 05/20] cacheinfo: Add support to check if last level cache(LLC) is valid or shared Sudeep Holla
2022-06-21 19:20 ` Sudeep Holla
2022-06-21 19:20 ` Sudeep Holla
2022-06-21 19:20 ` [PATCH v4 06/20] cacheinfo: Allow early detection and population of cache attributes Sudeep Holla
2022-06-21 19:20 ` Sudeep Holla
2022-06-21 19:20 ` Sudeep Holla
2022-06-21 19:20 ` [PATCH v4 07/20] cacheinfo: Use cache identifiers to check if the caches are shared if available Sudeep Holla
2022-06-21 19:20 ` Sudeep Holla
2022-06-21 19:20 ` Sudeep Holla
2022-06-21 19:20 ` [PATCH v4 08/20] arch_topology: Add support to parse and detect cache attributes Sudeep Holla
2022-06-21 19:20 ` Sudeep Holla
2022-06-21 19:20 ` Sudeep Holla
2022-06-21 19:20 ` [PATCH v4 09/20] arch_topology: Use the last level cache information from the cacheinfo Sudeep Holla
2022-06-21 19:20 ` Sudeep Holla
2022-06-21 19:20 ` Sudeep Holla
2022-06-21 19:20 ` [PATCH v4 10/20] arm64: topology: Remove redundant setting of llc_id in CPU topology Sudeep Holla
2022-06-21 19:20 ` Sudeep Holla
2022-06-21 19:20 ` Sudeep Holla
2022-06-23 15:55 ` Catalin Marinas
2022-06-23 15:55 ` Catalin Marinas
2022-06-23 15:55 ` Catalin Marinas
2022-06-21 19:20 ` [PATCH v4 11/20] arch_topology: Drop LLC identifier stash from the " Sudeep Holla
2022-06-21 19:20 ` Sudeep Holla
2022-06-21 19:20 ` Sudeep Holla
2022-06-21 19:20 ` [PATCH v4 12/20] arch_topology: Set thread sibling cpumask only within the cluster Sudeep Holla
2022-06-21 19:20 ` Sudeep Holla
2022-06-21 19:20 ` Sudeep Holla
2022-06-27 13:42 ` Ionela Voinescu
2022-06-27 13:42 ` Ionela Voinescu
2022-06-27 13:42 ` Ionela Voinescu
2022-06-21 19:20 ` [PATCH v4 13/20] arch_topology: Check for non-negative value rather than -1 for IDs validity Sudeep Holla
2022-06-21 19:20 ` Sudeep Holla
2022-06-21 19:20 ` Sudeep Holla
2022-06-21 19:20 ` [PATCH v4 14/20] arch_topology: Avoid parsing through all the CPUs once a outlier CPU is found Sudeep Holla
2022-06-21 19:20 ` Sudeep Holla
2022-06-21 19:20 ` Sudeep Holla
2022-06-21 19:20 ` [PATCH v4 15/20] arch_topology: Don't set cluster identifier as physical package identifier Sudeep Holla
2022-06-21 19:20 ` Sudeep Holla
2022-06-21 19:20 ` Sudeep Holla
2022-06-27 13:43 ` Ionela Voinescu [this message]
2022-06-27 13:43 ` Ionela Voinescu
2022-06-27 13:43 ` Ionela Voinescu
2022-06-21 19:20 ` [PATCH v4 16/20] arch_topology: Drop unnecessary check for uninitialised package_id Sudeep Holla
2022-06-21 19:20 ` Sudeep Holla
2022-06-21 19:20 ` Sudeep Holla
2022-06-27 13:12 ` Ionela Voinescu
2022-06-27 13:12 ` Ionela Voinescu
2022-06-27 13:12 ` Ionela Voinescu
2022-06-27 16:30 ` Sudeep Holla
2022-06-27 16:30 ` Sudeep Holla
2022-06-27 16:30 ` Sudeep Holla
2022-06-21 19:20 ` [PATCH v4 17/20] arch_topology: Limit span of cpu_clustergroup_mask() Sudeep Holla
2022-06-21 19:20 ` Sudeep Holla
2022-06-21 19:20 ` Sudeep Holla
2022-06-21 19:20 ` [PATCH v4 18/20] arch_topology: Set cluster identifier in each core/thread from /cpu-map Sudeep Holla
2022-06-21 19:20 ` Sudeep Holla
2022-06-21 19:20 ` Sudeep Holla
2022-06-27 13:47 ` Ionela Voinescu
2022-06-27 13:47 ` Ionela Voinescu
2022-06-27 13:47 ` Ionela Voinescu
2022-06-21 19:20 ` [PATCH v4 19/20] arch_topology: Add support for parsing sockets in /cpu-map Sudeep Holla
2022-06-21 19:20 ` Sudeep Holla
2022-06-21 19:20 ` Sudeep Holla
2022-06-27 13:47 ` Ionela Voinescu
2022-06-27 13:47 ` Ionela Voinescu
2022-06-27 13:47 ` Ionela Voinescu
2022-06-21 19:20 ` [PATCH v4 20/20] arch_topology: Warn that topology for nested clusters is not supported Sudeep Holla
2022-06-21 19:20 ` Sudeep Holla
2022-06-21 19:20 ` Sudeep Holla
2022-06-22 15:06 ` Ionela Voinescu
2022-06-22 15:06 ` Ionela Voinescu
2022-06-22 15:06 ` Ionela Voinescu
2022-06-22 15:46 ` Sudeep Holla
2022-06-22 15:46 ` Sudeep Holla
2022-06-22 15:46 ` Sudeep Holla
2022-06-27 13:54 ` [PATCH v4 00/20] arch_topology: Updates to add socket support and fix cluster ids Ionela Voinescu
2022-06-27 13:54 ` Ionela Voinescu
2022-06-27 13:54 ` Ionela Voinescu
2022-06-27 16:22 ` Sudeep Holla
2022-06-27 16:22 ` Sudeep Holla
2022-06-27 16:22 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yrm0E3mFHvJ5Nkgt@arm.com \
--to=ionela.voinescu@arm.com \
--cc=atishp@atishpatra.org \
--cc=atishp@rivosinc.com \
--cc=dietmar.eggemann@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=pierre.gondois@arm.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=wangqing@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.