From: Yury Norov <yury.norov@gmail.com> To: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>, David Howells <dhowells@redhat.com>, Geert Uytterhoeven <geert@linux-m68k.org>, Jonathan Corbet <corbet@lwn.net>, "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>, Matthew Wilcox <willy@infradead.org>, NeilBrown <neilb@suse.de>, Rasmus Villemoes <linux@rasmusvillemoes.dk>, Russell King <linux@armlinux.org.uk>, Vlastimil Babka <vbabka@suse.cz>, William Kucharski <william.kucharski@oracle.com>, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH 5/8] lib/cpumask: change return types to unsigned where appropriate Date: Sat, 2 Jul 2022 14:59:37 -0700 [thread overview] Message-ID: <YsC/yRH1HLHvDlIS@yury-laptop> (raw) In-Reply-To: <YsAzU3g2QpgmIGre@smile.fi.intel.com> On Sat, Jul 02, 2022 at 03:00:19PM +0300, Andy Shevchenko wrote: > On Fri, Jul 01, 2022 at 05:54:27AM -0700, Yury Norov wrote: > > Switch return types to unsigned int where return values cannot be negative. > > ... > > > -int cpumask_any_and_distribute(const struct cpumask *src1p, > > +unsigned int cpumask_any_and_distribute(const struct cpumask *src1p, > > const struct cpumask *src2p); > > It breaks indentation of the second line. I'd prefer to keep 2nd line untouched to not trash history for nothing. > > ... > > > -int cpumask_next_and(int n, const struct cpumask *src1p, > > +unsigned int cpumask_next_and(int n, const struct cpumask *src1p, > > const struct cpumask *src2p) > > Ditto. > > And seems a lot of cases in the series like this. > > -- > With Best Regards, > Andy Shevchenko >
WARNING: multiple messages have this Message-ID (diff)
From: Yury Norov <yury.norov@gmail.com> To: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>, David Howells <dhowells@redhat.com>, Geert Uytterhoeven <geert@linux-m68k.org>, Jonathan Corbet <corbet@lwn.net>, "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>, Matthew Wilcox <willy@infradead.org>, NeilBrown <neilb@suse.de>, Rasmus Villemoes <linux@rasmusvillemoes.dk>, Russell King <linux@armlinux.org.uk>, Vlastimil Babka <vbabka@suse.cz>, William Kucharski <william.kucharski@oracle.com>, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH 5/8] lib/cpumask: change return types to unsigned where appropriate Date: Sat, 2 Jul 2022 14:59:37 -0700 [thread overview] Message-ID: <YsC/yRH1HLHvDlIS@yury-laptop> (raw) In-Reply-To: <YsAzU3g2QpgmIGre@smile.fi.intel.com> On Sat, Jul 02, 2022 at 03:00:19PM +0300, Andy Shevchenko wrote: > On Fri, Jul 01, 2022 at 05:54:27AM -0700, Yury Norov wrote: > > Switch return types to unsigned int where return values cannot be negative. > > ... > > > -int cpumask_any_and_distribute(const struct cpumask *src1p, > > +unsigned int cpumask_any_and_distribute(const struct cpumask *src1p, > > const struct cpumask *src2p); > > It breaks indentation of the second line. I'd prefer to keep 2nd line untouched to not trash history for nothing. > > ... > > > -int cpumask_next_and(int n, const struct cpumask *src1p, > > +unsigned int cpumask_next_and(int n, const struct cpumask *src1p, > > const struct cpumask *src2p) > > Ditto. > > And seems a lot of cases in the series like this. > > -- > With Best Regards, > Andy Shevchenko > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-02 21:59 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-07-01 12:54 [PATCH 0/8] lib: cleanup bitmap-related headers Yury Norov 2022-07-01 12:54 ` Yury Norov 2022-07-01 12:54 ` [PATCH 1/8] arm: align find_bit declarations with generic kernel Yury Norov 2022-07-01 12:54 ` Yury Norov 2022-07-02 11:55 ` Andy Shevchenko 2022-07-02 11:55 ` Andy Shevchenko 2022-07-01 12:54 ` [PATCH 2/8] lib/bitmap: change return types to bool where appropriate Yury Norov 2022-07-01 12:54 ` Yury Norov 2022-07-01 12:54 ` [PATCH 3/8] lib/bitmap: change type of bitmap_weight to unsigned int Yury Norov 2022-07-01 12:54 ` Yury Norov 2022-07-02 11:57 ` Andy Shevchenko 2022-07-02 11:57 ` Andy Shevchenko 2022-07-01 12:54 ` [PATCH 4/8] cpumask: change return types to bool where appropriate Yury Norov 2022-07-01 12:54 ` Yury Norov 2022-07-01 12:54 ` [PATCH 5/8] lib/cpumask: change return types to unsigned " Yury Norov 2022-07-01 12:54 ` Yury Norov 2022-07-02 12:00 ` Andy Shevchenko 2022-07-02 12:00 ` Andy Shevchenko 2022-07-02 21:59 ` Yury Norov [this message] 2022-07-02 21:59 ` Yury Norov 2022-07-01 12:54 ` [PATCH 6/8] lib/cpumask: move trivial wrappers around find_bit to the header Yury Norov 2022-07-01 12:54 ` Yury Norov 2022-07-01 12:54 ` [PATCH 7/8] mm: split include/linux/gfp.h Yury Norov 2022-07-01 12:54 ` Yury Norov 2022-07-02 12:05 ` Andy Shevchenko 2022-07-02 12:05 ` Andy Shevchenko 2022-07-02 12:09 ` Andy Shevchenko 2022-07-02 12:09 ` Andy Shevchenko 2022-07-02 22:06 ` Yury Norov 2022-07-02 22:06 ` Yury Norov 2022-07-01 12:54 ` [PATCH 8/8] lib/cpumask: move some one-line wrappers to header file Yury Norov 2022-07-01 12:54 ` Yury Norov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YsC/yRH1HLHvDlIS@yury-laptop \ --to=yury.norov@gmail.com \ --cc=akpm@linux-foundation.org \ --cc=andriy.shevchenko@linux.intel.com \ --cc=corbet@lwn.net \ --cc=dhowells@redhat.com \ --cc=geert@linux-m68k.org \ --cc=kirill.shutemov@linux.intel.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linux@armlinux.org.uk \ --cc=linux@rasmusvillemoes.dk \ --cc=neilb@suse.de \ --cc=vbabka@suse.cz \ --cc=william.kucharski@oracle.com \ --cc=willy@infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.