From: Nathan Chancellor <nathan@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Claudiu Beznea <claudiu.beznea@microchip.com>,
alsa-devel@alsa-project.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Nicolas Ferre <nicolas.ferre@microchip.com>,
llvm@lists.linux.dev,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Nick Desaulniers <ndesaulniers@google.com>,
Tom Rix <trix@redhat.com>
Subject: Re: [PATCH] ASoC: mchp-spdiftx: Fix clang -Wbitfield-constant-conversion
Date: Tue, 23 Aug 2022 08:39:13 -0700 [thread overview]
Message-ID: <YwT0oUjo/lzBDRdH@dev-arch.thelio-3990X> (raw)
In-Reply-To: <166058059542.769843.4941839393289864947.b4-ty@kernel.org>
Hi Mark,
On Mon, Aug 15, 2022 at 05:23:15PM +0100, Mark Brown wrote:
> On Tue, 9 Aug 2022 18:08:09 -0700, Nathan Chancellor wrote:
> > A recent change in clang strengthened its -Wbitfield-constant-conversion
> > to warn when 1 is assigned to a 1-bit signed integer bitfield, as it can
> > only be 0 or -1, not 1:
> >
> > sound/soc/atmel/mchp-spdiftx.c:505:20: error: implicit truncation from 'int' to bit-field changes value from 1 to -1 [-Werror,-Wbitfield-constant-conversion]
> > dev->gclk_enabled = 1;
> > ^ ~
> > 1 error generated.
> >
> > [...]
>
> Applied to
>
> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
>
> Thanks!
>
> [1/1] ASoC: mchp-spdiftx: Fix clang -Wbitfield-constant-conversion
> commit: eab9100d9898cbd37882b04415b12156f8942f18
I noticed that this was applied to for-6.1. I know you do not rebase or
change your trees so this request might be rejected based on that alone
but would it be possible to cherry-pick this to for-6.0 so that it can
be applied to Linus's tree quicker? We have had to apply this change to
our CI to keep our builds green in mainline, -tip, and 5.19/5.15 stable
with clang-16 due to -Werror. If not, no worries, I should have made it
clearer that is what I was looking for with the subject prefix.
Cheers,
Nathan
WARNING: multiple messages have this Message-ID (diff)
From: Nathan Chancellor <nathan@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, llvm@lists.linux.dev,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Tom Rix <trix@redhat.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Nick Desaulniers <ndesaulniers@google.com>,
linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Codrin Ciubotariu <codrin.ciubotariu@microchip.com>,
Claudiu Beznea <claudiu.beznea@microchip.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ASoC: mchp-spdiftx: Fix clang -Wbitfield-constant-conversion
Date: Tue, 23 Aug 2022 08:39:13 -0700 [thread overview]
Message-ID: <YwT0oUjo/lzBDRdH@dev-arch.thelio-3990X> (raw)
In-Reply-To: <166058059542.769843.4941839393289864947.b4-ty@kernel.org>
Hi Mark,
On Mon, Aug 15, 2022 at 05:23:15PM +0100, Mark Brown wrote:
> On Tue, 9 Aug 2022 18:08:09 -0700, Nathan Chancellor wrote:
> > A recent change in clang strengthened its -Wbitfield-constant-conversion
> > to warn when 1 is assigned to a 1-bit signed integer bitfield, as it can
> > only be 0 or -1, not 1:
> >
> > sound/soc/atmel/mchp-spdiftx.c:505:20: error: implicit truncation from 'int' to bit-field changes value from 1 to -1 [-Werror,-Wbitfield-constant-conversion]
> > dev->gclk_enabled = 1;
> > ^ ~
> > 1 error generated.
> >
> > [...]
>
> Applied to
>
> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
>
> Thanks!
>
> [1/1] ASoC: mchp-spdiftx: Fix clang -Wbitfield-constant-conversion
> commit: eab9100d9898cbd37882b04415b12156f8942f18
I noticed that this was applied to for-6.1. I know you do not rebase or
change your trees so this request might be rejected based on that alone
but would it be possible to cherry-pick this to for-6.0 so that it can
be applied to Linus's tree quicker? We have had to apply this change to
our CI to keep our builds green in mainline, -tip, and 5.19/5.15 stable
with clang-16 due to -Werror. If not, no worries, I should have made it
clearer that is what I was looking for with the subject prefix.
Cheers,
Nathan
WARNING: multiple messages have this Message-ID (diff)
From: Nathan Chancellor <nathan@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, llvm@lists.linux.dev,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Tom Rix <trix@redhat.com>,
Nick Desaulniers <ndesaulniers@google.com>,
linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Codrin Ciubotariu <codrin.ciubotariu@microchip.com>,
Claudiu Beznea <claudiu.beznea@microchip.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ASoC: mchp-spdiftx: Fix clang -Wbitfield-constant-conversion
Date: Tue, 23 Aug 2022 08:39:13 -0700 [thread overview]
Message-ID: <YwT0oUjo/lzBDRdH@dev-arch.thelio-3990X> (raw)
In-Reply-To: <166058059542.769843.4941839393289864947.b4-ty@kernel.org>
Hi Mark,
On Mon, Aug 15, 2022 at 05:23:15PM +0100, Mark Brown wrote:
> On Tue, 9 Aug 2022 18:08:09 -0700, Nathan Chancellor wrote:
> > A recent change in clang strengthened its -Wbitfield-constant-conversion
> > to warn when 1 is assigned to a 1-bit signed integer bitfield, as it can
> > only be 0 or -1, not 1:
> >
> > sound/soc/atmel/mchp-spdiftx.c:505:20: error: implicit truncation from 'int' to bit-field changes value from 1 to -1 [-Werror,-Wbitfield-constant-conversion]
> > dev->gclk_enabled = 1;
> > ^ ~
> > 1 error generated.
> >
> > [...]
>
> Applied to
>
> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
>
> Thanks!
>
> [1/1] ASoC: mchp-spdiftx: Fix clang -Wbitfield-constant-conversion
> commit: eab9100d9898cbd37882b04415b12156f8942f18
I noticed that this was applied to for-6.1. I know you do not rebase or
change your trees so this request might be rejected based on that alone
but would it be possible to cherry-pick this to for-6.0 so that it can
be applied to Linus's tree quicker? We have had to apply this change to
our CI to keep our builds green in mainline, -tip, and 5.19/5.15 stable
with clang-16 due to -Werror. If not, no worries, I should have made it
clearer that is what I was looking for with the subject prefix.
Cheers,
Nathan
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-08-23 15:39 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 1:08 [PATCH] ASoC: mchp-spdiftx: Fix clang -Wbitfield-constant-conversion Nathan Chancellor
2022-08-10 1:08 ` Nathan Chancellor
2022-08-10 1:08 ` Nathan Chancellor
2022-08-10 21:14 ` Nick Desaulniers
2022-08-10 21:14 ` Nick Desaulniers
2022-08-10 21:14 ` Nick Desaulniers
2022-08-15 9:55 ` David Laight
2022-08-15 9:55 ` David Laight
2022-08-15 9:55 ` David Laight
2022-08-15 16:23 ` Mark Brown
2022-08-15 16:23 ` Mark Brown
2022-08-15 16:23 ` Mark Brown
2022-08-23 15:39 ` Nathan Chancellor [this message]
2022-08-23 15:39 ` Nathan Chancellor
2022-08-23 15:39 ` Nathan Chancellor
2022-08-23 16:03 ` Mark Brown
2022-08-23 16:03 ` Mark Brown
2022-08-23 16:03 ` Mark Brown
2022-08-23 16:11 ` Nathan Chancellor
2022-08-23 16:11 ` Nathan Chancellor
2022-08-23 16:11 ` Nathan Chancellor
2022-08-23 18:37 ` Mark Brown
2022-08-23 18:37 ` Mark Brown
2022-08-23 18:37 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwT0oUjo/lzBDRdH@dev-arch.thelio-3990X \
--to=nathan@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=claudiu.beznea@microchip.com \
--cc=codrin.ciubotariu@microchip.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=ndesaulniers@google.com \
--cc=nicolas.ferre@microchip.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.