From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, jiri@resnulli.us, johannes@sipsolutions.net,
linux-block@vger.kernel.org, osmocom-net-gprs@lists.osmocom.org,
linux-wpan@vger.kernel.org, wireguard@lists.zx2c4.com,
linux-wireless@vger.kernel.org, linux-scsi@vger.kernel.org,
target-devel@vger.kernel.org, linux-pm@vger.kernel.org,
virtualization@lists.linux-foundation.org,
linux-cifs@vger.kernel.org, cluster-devel@redhat.com,
mptcp@lists.linux.dev, lvs-devel@vger.kernel.org,
netfilter-devel@vger.kernel.org,
linux-security-module@vger.kernel.org, dev@openvswitch.org,
linux-s390@vger.kernel.org,
tipc-discussion@lists.sourceforge.net
Subject: Re: [PATCH net-next] genetlink: start to validate reserved header bytes
Date: Mon, 29 Aug 2022 12:32:54 -0400 [thread overview]
Message-ID: <YwzqNgj/bJoawrwh@zx2c4.com> (raw)
In-Reply-To: <20220825001830.1911524-1-kuba@kernel.org>
Hi Jakub,
On Wed, Aug 24, 2022 at 05:18:30PM -0700, Jakub Kicinski wrote:
> diff --git a/drivers/net/wireguard/netlink.c b/drivers/net/wireguard/netlink.c
> index d0f3b6d7f408..0c0644e762e5 100644
> --- a/drivers/net/wireguard/netlink.c
> +++ b/drivers/net/wireguard/netlink.c
> @@ -621,6 +621,7 @@ static const struct genl_ops genl_ops[] = {
> static struct genl_family genl_family __ro_after_init = {
> .ops = genl_ops,
> .n_ops = ARRAY_SIZE(genl_ops),
> + .resv_start_op = WG_CMD_SET_DEVICE + 1,
> .name = WG_GENL_NAME,
> .version = WG_GENL_VERSION,
> .maxattr = WGDEVICE_A_MAX,
FWIW, I wouldn't object to just leaving this at zero. I don't know of
any wireguard userspaces doing anything with the reserved header field.
Jason
WARNING: multiple messages have this Message-ID (diff)
From: Jason A. Donenfeld <Jason@zx2c4.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH net-next] genetlink: start to validate reserved header bytes
Date: Mon, 29 Aug 2022 12:32:54 -0400 [thread overview]
Message-ID: <YwzqNgj/bJoawrwh@zx2c4.com> (raw)
In-Reply-To: <20220825001830.1911524-1-kuba@kernel.org>
Hi Jakub,
On Wed, Aug 24, 2022 at 05:18:30PM -0700, Jakub Kicinski wrote:
> diff --git a/drivers/net/wireguard/netlink.c b/drivers/net/wireguard/netlink.c
> index d0f3b6d7f408..0c0644e762e5 100644
> --- a/drivers/net/wireguard/netlink.c
> +++ b/drivers/net/wireguard/netlink.c
> @@ -621,6 +621,7 @@ static const struct genl_ops genl_ops[] = {
> static struct genl_family genl_family __ro_after_init = {
> .ops = genl_ops,
> .n_ops = ARRAY_SIZE(genl_ops),
> + .resv_start_op = WG_CMD_SET_DEVICE + 1,
> .name = WG_GENL_NAME,
> .version = WG_GENL_VERSION,
> .maxattr = WGDEVICE_A_MAX,
FWIW, I wouldn't object to just leaving this at zero. I don't know of
any wireguard userspaces doing anything with the reserved header field.
Jason
next prev parent reply other threads:[~2022-08-29 16:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 0:18 [PATCH net-next] genetlink: start to validate reserved header bytes Jakub Kicinski
2022-08-25 0:18 ` [Cluster-devel] " Jakub Kicinski
2022-08-25 1:42 ` genetlink: start to validate reserved header bytes: Tests Results MPTCP CI
2022-08-25 19:21 ` [PATCH net-next] genetlink: start to validate reserved header bytes Paul Moore
2022-08-25 19:21 ` Paul Moore
2022-08-25 19:21 ` [Cluster-devel] " Paul Moore
2022-08-29 12:10 ` patchwork-bot+netdevbpf
2022-08-29 12:10 ` [Cluster-devel] " patchwork-bot+netdevbpf
2022-08-29 16:32 ` Jason A. Donenfeld [this message]
2022-08-29 16:32 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwzqNgj/bJoawrwh@zx2c4.com \
--to=jason@zx2c4.com \
--cc=cluster-devel@redhat.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=lvs-devel@vger.kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=osmocom-net-gprs@lists.osmocom.org \
--cc=pabeni@redhat.com \
--cc=target-devel@vger.kernel.org \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=virtualization@lists.linux-foundation.org \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.