All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Guy Briggs <rgb@redhat.com>
To: Steve Grubb <sgrubb@redhat.com>
Cc: Jan Kara <jack@suse.cz>, Paul Moore <paul@paul-moore.com>,
	Linux-Audit Mailing List <linux-audit@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-fsdevel@vger.kernel.org, Eric Paris <eparis@parisplace.org>,
	Amir Goldstein <amir73il@gmail.com>
Subject: Re: [PATCH v4 3/4] fanotify,audit: Allow audit to use the full permission event response
Date: Fri, 9 Sep 2022 14:50:18 -0400	[thread overview]
Message-ID: <YxuK6qTfeHfmp4B6@madcap2.tricolour.ca> (raw)
In-Reply-To: <13104070.uLZWGnKmhe@x2>

On 2022-09-09 10:55, Steve Grubb wrote:
> On Friday, September 9, 2022 10:38:46 AM EDT Richard Guy Briggs wrote:
> > > Richard,  add subj_trust and obj_trust. These can be 0|1|2 for no, yes,
> > > unknown.
> > 
> > type?  bitfield?  My gut would say that "0" should be "unset"/"unknown",
> > but that is counterintuitive to the values represented.
> >
> > Or "trust" with sub-fields "subj" and "obj"?
> 
> No. just make them separate and u32. subj_trust and obj_trust - no sub fields. 
> If we have sub-fields, that probably means bit mapping and that wasn't wanted.

Ack.

> -Steve

- RGB

--
Richard Guy Briggs <rgb@redhat.com>
Sr. S/W Engineer, Kernel Security, Base Operating Systems
Remote, Ottawa, Red Hat Canada
IRC: rgb, SunRaycer
Voice: +1.647.777.2635, Internal: (81) 32635


WARNING: multiple messages have this Message-ID (diff)
From: Richard Guy Briggs <rgb@redhat.com>
To: Steve Grubb <sgrubb@redhat.com>
Cc: Jan Kara <jack@suse.cz>, Amir Goldstein <amir73il@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Linux-Audit Mailing List <linux-audit@redhat.com>,
	linux-fsdevel@vger.kernel.org, Eric Paris <eparis@parisplace.org>
Subject: Re: [PATCH v4 3/4] fanotify,audit: Allow audit to use the full permission event response
Date: Fri, 9 Sep 2022 14:50:18 -0400	[thread overview]
Message-ID: <YxuK6qTfeHfmp4B6@madcap2.tricolour.ca> (raw)
In-Reply-To: <13104070.uLZWGnKmhe@x2>

On 2022-09-09 10:55, Steve Grubb wrote:
> On Friday, September 9, 2022 10:38:46 AM EDT Richard Guy Briggs wrote:
> > > Richard,  add subj_trust and obj_trust. These can be 0|1|2 for no, yes,
> > > unknown.
> > 
> > type?  bitfield?  My gut would say that "0" should be "unset"/"unknown",
> > but that is counterintuitive to the values represented.
> >
> > Or "trust" with sub-fields "subj" and "obj"?
> 
> No. just make them separate and u32. subj_trust and obj_trust - no sub fields. 
> If we have sub-fields, that probably means bit mapping and that wasn't wanted.

Ack.

> -Steve

- RGB

--
Richard Guy Briggs <rgb@redhat.com>
Sr. S/W Engineer, Kernel Security, Base Operating Systems
Remote, Ottawa, Red Hat Canada
IRC: rgb, SunRaycer
Voice: +1.647.777.2635, Internal: (81) 32635
--
Linux-audit mailing list
Linux-audit@redhat.com
https://listman.redhat.com/mailman/listinfo/linux-audit


  reply	other threads:[~2022-09-09 18:50 UTC|newest]

Thread overview: 91+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-09 17:22 [PATCH v4 0/4] fanotify: Allow user space to pass back additional audit info Richard Guy Briggs
2022-08-09 17:22 ` Richard Guy Briggs
2022-08-09 17:22 ` [PATCH v4 1/4] fanotify: Ensure consistent variable type for response Richard Guy Briggs
2022-08-09 17:22   ` Richard Guy Briggs
2022-08-09 17:22 ` [PATCH v4 2/4] fanotify: define struct members to hold response decision context Richard Guy Briggs
2022-08-09 17:22   ` Richard Guy Briggs
2022-08-10  6:22   ` Amir Goldstein
2022-08-10  6:22     ` Amir Goldstein
2022-08-19 11:24     ` Jan Kara
2022-08-19 11:24       ` Jan Kara
2022-08-10 14:28   ` kernel test robot
2022-08-10 14:28     ` kernel test robot
2022-08-19 16:25     ` Richard Guy Briggs
2022-08-19 16:25       ` Richard Guy Briggs
2022-08-19 16:25       ` Richard Guy Briggs
2022-08-19 17:17       ` Nick Desaulniers
2022-08-19 17:17         ` Nick Desaulniers
2022-08-19 17:17         ` Nick Desaulniers
2022-08-19 21:45         ` Richard Guy Briggs
2022-08-19 21:45           ` Richard Guy Briggs
2022-08-19 21:45           ` Richard Guy Briggs
2022-08-12  0:23   ` Matthew Bobrowski
2022-08-12  0:23     ` Matthew Bobrowski
2022-08-19 11:16     ` Jan Kara
2022-08-19 11:16       ` Jan Kara
2022-08-19 11:13   ` Jan Kara
2022-08-19 11:13     ` Jan Kara
2022-08-09 17:22 ` [PATCH v4 3/4] fanotify,audit: Allow audit to use the full permission event response Richard Guy Briggs
2022-08-09 17:22   ` [PATCH v4 3/4] fanotify, audit: " Richard Guy Briggs
2022-08-10 20:32   ` [PATCH v4 3/4] fanotify,audit: " kernel test robot
2022-08-10 20:32     ` kernel test robot
2022-08-16  0:22   ` Paul Moore
2022-08-16  0:22     ` Paul Moore
2022-08-31 21:07     ` Richard Guy Briggs
2022-08-31 21:07       ` Richard Guy Briggs
2022-08-31 21:25       ` Steve Grubb
2022-08-31 21:25         ` [PATCH v4 3/4] fanotify, audit: " Steve Grubb
2022-08-31 22:19         ` [PATCH v4 3/4] fanotify,audit: " Richard Guy Briggs
2022-08-31 22:19           ` Richard Guy Briggs
2022-08-31 23:55           ` Steve Grubb
2022-08-31 23:55             ` [PATCH v4 3/4] fanotify, audit: " Steve Grubb
2022-09-01  1:47             ` [PATCH v4 3/4] fanotify,audit: " Paul Moore
2022-09-01  1:47               ` Paul Moore
2022-09-01  7:51               ` Jan Kara
2022-09-01  7:51                 ` Jan Kara
2022-09-01 18:31                 ` Paul Moore
2022-09-01 18:31                   ` Paul Moore
2022-09-07 18:43                   ` Richard Guy Briggs
2022-09-07 18:43                     ` Richard Guy Briggs
2022-09-07 20:11                     ` Steve Grubb
2022-09-07 20:11                       ` [PATCH v4 3/4] fanotify, audit: " Steve Grubb
2022-09-07 20:23                       ` [PATCH v4 3/4] fanotify,audit: " Paul Moore
2022-09-07 20:23                         ` Paul Moore
2022-09-08 21:14                         ` Steve Grubb
2022-09-08 21:14                           ` [PATCH v4 3/4] fanotify, audit: " Steve Grubb
2022-09-08 21:22                           ` [PATCH v4 3/4] fanotify,audit: " Paul Moore
2022-09-08 21:22                             ` Paul Moore
2022-09-09  2:20                             ` Steve Grubb
2022-09-09  2:20                               ` [PATCH v4 3/4] fanotify, audit: " Steve Grubb
2022-09-09  2:41                               ` [PATCH v4 3/4] fanotify,audit: " Richard Guy Briggs
2022-09-09  2:41                                 ` Richard Guy Briggs
2022-09-09  3:25                                 ` Paul Moore
2022-09-09  3:25                                   ` Paul Moore
2022-09-09  4:03                                 ` Steve Grubb
2022-09-09  4:03                                   ` [PATCH v4 3/4] fanotify, audit: " Steve Grubb
2022-09-09 11:09                                   ` [PATCH v4 3/4] fanotify,audit: " Jan Kara
2022-09-09 11:09                                     ` Jan Kara
2022-09-09 14:22                                     ` Steve Grubb
2022-09-09 14:22                                       ` [PATCH v4 3/4] fanotify, audit: " Steve Grubb
2022-09-09 14:38                                       ` [PATCH v4 3/4] fanotify,audit: " Richard Guy Briggs
2022-09-09 14:38                                         ` Richard Guy Briggs
2022-09-09 14:55                                         ` Steve Grubb
2022-09-09 14:55                                           ` [PATCH v4 3/4] fanotify, audit: " Steve Grubb
2022-09-09 18:50                                           ` Richard Guy Briggs [this message]
2022-09-09 18:50                                             ` [PATCH v4 3/4] fanotify,audit: " Richard Guy Briggs
2022-08-09 17:22 ` [PATCH v4 4/4] fanotify,audit: deliver fan_info as a hex-encoded string Richard Guy Briggs
2022-08-09 17:22   ` [PATCH v4 4/4] fanotify, audit: " Richard Guy Briggs
2022-08-10 19:15   ` [PATCH v4 4/4] fanotify,audit: " Steve Grubb
2022-08-10 19:15     ` [PATCH v4 4/4] fanotify, audit: " Steve Grubb
2022-08-11  2:23     ` [PATCH v4 4/4] fanotify,audit: " Richard Guy Briggs
2022-08-11  2:23       ` [PATCH v4 4/4] fanotify, audit: " Richard Guy Briggs
2022-08-15 21:15       ` Steve Grubb
2022-08-15 21:15         ` [PATCH v4 4/4] fanotify,audit: " Steve Grubb
2022-08-16  0:31   ` [PATCH v4 4/4] fanotify, audit: " Paul Moore
2022-08-16  0:31     ` [PATCH v4 4/4] fanotify,audit: " Paul Moore
2022-08-16 13:37   ` Steve Grubb
2022-08-16 13:37     ` [PATCH v4 4/4] fanotify, audit: " Steve Grubb
2022-08-19 21:42     ` [PATCH v4 4/4] fanotify,audit: " Richard Guy Briggs
2022-08-19 21:42       ` [PATCH v4 4/4] fanotify, audit: " Richard Guy Briggs
2022-08-10  5:21 ` [PATCH v4 0/4] fanotify: Allow user space to pass back additional audit info Amir Goldstein
2022-08-10  5:21   ` Amir Goldstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YxuK6qTfeHfmp4B6@madcap2.tricolour.ca \
    --to=rgb@redhat.com \
    --cc=amir73il@gmail.com \
    --cc=eparis@parisplace.org \
    --cc=jack@suse.cz \
    --cc=linux-audit@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul@paul-moore.com \
    --cc=sgrubb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.