From: Dan Carpenter <dan.carpenter@oracle.com>
To: eadavis@sina.com
Cc: lkp@intel.com, almaz.alexandrovich@paragon-software.com,
eadvis@sina.com, kbuild-all@lists.01.org,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
nathan@kernel.org, ndesaulniers@google.com,
ntfs3@lists.linux.dev,
syzbot+c4d950787fd5553287b7@syzkaller.appspotmail.com,
syzkaller-bugs@googlegroups.com, trix@redhat.com
Subject: Re: [PATCH] fs/ntfs3: "add a boundary check for EA_FULL" lose right parenthesis
Date: Mon, 19 Sep 2022 13:42:43 +0300 [thread overview]
Message-ID: <YyhHowvgEarPqONR@kadam> (raw)
In-Reply-To: <20220919051943.184810-1-eadavis@sina.com>
On Mon, Sep 19, 2022 at 01:19:43PM +0800, eadavis@sina.com wrote:
> From: Edward Adam Davis <eadavis@sina.com>
>
> I have provided a new patch:
> https://lore.kernel.org/all/20220912065431.3043731-1-eadavis@sina.com
> It is a collection of the current patch and the previous one.
>
> Signed-off-by: Edward Adam Davis <eadavis@sina.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: syzbot+c4d950787fd5553287b7@syzkaller.appspotmail.com
No need to send this email. The correct thing was to send a v2 which
fixes the bug and you already did that. However your v2 patch was
missing a list of changes. "v2: don't break the build".
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
You will want to address the review comments I sent and send a v3 patch.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH] fs/ntfs3: "add a boundary check for EA_FULL" lose right parenthesis
Date: Mon, 19 Sep 2022 13:42:43 +0300 [thread overview]
Message-ID: <YyhHowvgEarPqONR@kadam> (raw)
In-Reply-To: <20220919051943.184810-1-eadavis@sina.com>
[-- Attachment #1: Type: text/plain, Size: 847 bytes --]
On Mon, Sep 19, 2022 at 01:19:43PM +0800, eadavis(a)sina.com wrote:
> From: Edward Adam Davis <eadavis@sina.com>
>
> I have provided a new patch:
> https://lore.kernel.org/all/20220912065431.3043731-1-eadavis(a)sina.com
> It is a collection of the current patch and the previous one.
>
> Signed-off-by: Edward Adam Davis <eadavis@sina.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: syzbot+c4d950787fd5553287b7(a)syzkaller.appspotmail.com
No need to send this email. The correct thing was to send a v2 which
fixes the bug and you already did that. However your v2 patch was
missing a list of changes. "v2: don't break the build".
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
You will want to address the review comments I sent and send a v3 patch.
regards,
dan carpenter
next prev parent reply other threads:[~2022-09-19 10:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 16:55 [syzbot] KASAN: slab-out-of-bounds Read in ntfs_get_ea syzbot
2022-09-12 3:41 ` [PATCH] fs/netfs3: add a boundary check for EA_FULL eadavis
2022-09-12 6:16 ` kernel test robot
2022-09-12 6:16 ` kernel test robot
2022-09-19 5:19 ` [PATCH] fs/ntfs3: "add a boundary check for EA_FULL" lose right parenthesis eadavis
2022-09-19 5:19 ` eadavis
2022-09-19 10:42 ` Dan Carpenter [this message]
2022-09-19 10:42 ` Dan Carpenter
2022-09-19 11:19 ` [PATCH v3] fs/ntfs3: add a boundary check for EA_FULL eadavis
2022-09-19 11:19 ` eadavis
2022-09-19 12:04 ` Dan Carpenter
2022-09-19 12:04 ` Dan Carpenter
2022-09-19 13:21 ` [PATCH v4] fs/ntfs3: Fix buffer overflow and integer overflow eadavis
2022-09-19 13:21 ` eadavis
2022-09-19 13:32 ` eadavis
2022-09-19 13:32 ` eadavis
2022-11-13 5:07 ` [PATCH v5] fs/ntfs3: Validate parameter bytes and valid size eadavis
2022-09-12 6:54 ` [PATCH v2] fs/netfs3: add a boundary check for EA_FULL eadavis
2022-09-14 15:34 ` Dan Carpenter
2023-01-26 8:13 ` [syzbot] KASAN: slab-out-of-bounds Read in ntfs_get_ea syzbot
2023-04-12 13:11 ` Aleksandr Nogikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YyhHowvgEarPqONR@kadam \
--to=dan.carpenter@oracle.com \
--cc=almaz.alexandrovich@paragon-software.com \
--cc=eadavis@sina.com \
--cc=eadvis@sina.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=ntfs3@lists.linux.dev \
--cc=syzbot+c4d950787fd5553287b7@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.