From: Johan Hovold <johan@kernel.org> To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Cc: "Andy Gross" <agross@kernel.org>, "Bjorn Andersson" <andersson@kernel.org>, "Konrad Dybcio" <konrad.dybcio@somainline.org>, "Rob Herring" <robh+dt@kernel.org>, "Jingoo Han" <jingoohan1@gmail.com>, "Gustavo Pimentel" <gustavo.pimentel@synopsys.com>, "Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>, "Krzysztof Wilczyński" <kw@linux.com>, "Bjorn Helgaas" <bhelgaas@google.com>, "Vinod Koul" <vkoul@kernel.org>, "Kishon Vijay Abraham I" <kishon@ti.com>, "Philipp Zabel" <p.zabel@pengutronix.de>, linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, linux-phy@lists.infradead.org Subject: Re: [PATCH v4 2/6] phy: qcom-qmp-pcie: split PHY programming to separate functions Date: Mon, 26 Sep 2022 09:33:31 +0200 [thread overview] Message-ID: <YzFVyxhRidGKPR0p@hovoldconsulting.com> (raw) In-Reply-To: <20220924160302.285875-3-dmitry.baryshkov@linaro.org> On Sat, Sep 24, 2022 at 07:02:58PM +0300, Dmitry Baryshkov wrote: > Split the code using PHY programming tables into separate functions, > which take a single struct qmp_phy_cfg_tables instance. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 80 ++++++++++++++---------- > 1 file changed, 48 insertions(+), 32 deletions(-) > > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c > index 30806816c8b0..6e8c74585670 100644 > --- a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c > +++ b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c > @@ -1877,15 +1877,53 @@ static void qmp_pcie_configure(void __iomem *base, > qmp_pcie_configure_lane(base, regs, tbl, num, 0xff); > } > > -static int qmp_pcie_serdes_init(struct qmp_phy *qphy) > +static void qmp_pcie_serdes_init(struct qmp_phy *qphy, const struct qmp_phy_cfg_tables *tables) > { > const struct qmp_phy_cfg *cfg = qphy->cfg; > void __iomem *serdes = qphy->serdes; > > - qmp_pcie_configure(serdes, cfg->regs, cfg->common.serdes_tbl, cfg->common.serdes_tbl_num); > - qmp_pcie_configure(serdes, cfg->regs, cfg->extra->serdes_tbl, cfg->extra->serdes_tbl_num); > + if (!tables) > + return; > > - return 0; > + qmp_pcie_configure(serdes, cfg->regs, tables->serdes_tbl, tables->serdes_tbl_num); See what I mean about "_tbl" being redundant in "tables->serdes_tbl"? > +} > static int qmp_pcie_init(struct phy *phy) > @@ -1957,15 +1995,13 @@ static int qmp_pcie_power_on(struct phy *phy) > struct qmp_phy *qphy = phy_get_drvdata(phy); > struct qcom_qmp *qmp = qphy->qmp; > const struct qmp_phy_cfg *cfg = qphy->cfg; > - void __iomem *tx = qphy->tx; > - void __iomem *rx = qphy->rx; > void __iomem *pcs = qphy->pcs; > - void __iomem *pcs_misc = qphy->pcs_misc; > void __iomem *status; > unsigned int mask, val, ready; > int ret; > > - qmp_pcie_serdes_init(qphy); > + qmp_pcie_serdes_init(qphy, &cfg->common); > + qmp_pcie_serdes_init(qphy, cfg->extra); And "common" and "extra" doesn't really say what it is you're passing here. > > ret = clk_prepare_enable(qphy->pipe_clk); > if (ret) { Johan
WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <johan@kernel.org> To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Cc: "Andy Gross" <agross@kernel.org>, "Bjorn Andersson" <andersson@kernel.org>, "Konrad Dybcio" <konrad.dybcio@somainline.org>, "Rob Herring" <robh+dt@kernel.org>, "Jingoo Han" <jingoohan1@gmail.com>, "Gustavo Pimentel" <gustavo.pimentel@synopsys.com>, "Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>, "Krzysztof Wilczyński" <kw@linux.com>, "Bjorn Helgaas" <bhelgaas@google.com>, "Vinod Koul" <vkoul@kernel.org>, "Kishon Vijay Abraham I" <kishon@ti.com>, "Philipp Zabel" <p.zabel@pengutronix.de>, linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, linux-phy@lists.infradead.org Subject: Re: [PATCH v4 2/6] phy: qcom-qmp-pcie: split PHY programming to separate functions Date: Mon, 26 Sep 2022 09:33:31 +0200 [thread overview] Message-ID: <YzFVyxhRidGKPR0p@hovoldconsulting.com> (raw) In-Reply-To: <20220924160302.285875-3-dmitry.baryshkov@linaro.org> On Sat, Sep 24, 2022 at 07:02:58PM +0300, Dmitry Baryshkov wrote: > Split the code using PHY programming tables into separate functions, > which take a single struct qmp_phy_cfg_tables instance. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 80 ++++++++++++++---------- > 1 file changed, 48 insertions(+), 32 deletions(-) > > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c > index 30806816c8b0..6e8c74585670 100644 > --- a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c > +++ b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c > @@ -1877,15 +1877,53 @@ static void qmp_pcie_configure(void __iomem *base, > qmp_pcie_configure_lane(base, regs, tbl, num, 0xff); > } > > -static int qmp_pcie_serdes_init(struct qmp_phy *qphy) > +static void qmp_pcie_serdes_init(struct qmp_phy *qphy, const struct qmp_phy_cfg_tables *tables) > { > const struct qmp_phy_cfg *cfg = qphy->cfg; > void __iomem *serdes = qphy->serdes; > > - qmp_pcie_configure(serdes, cfg->regs, cfg->common.serdes_tbl, cfg->common.serdes_tbl_num); > - qmp_pcie_configure(serdes, cfg->regs, cfg->extra->serdes_tbl, cfg->extra->serdes_tbl_num); > + if (!tables) > + return; > > - return 0; > + qmp_pcie_configure(serdes, cfg->regs, tables->serdes_tbl, tables->serdes_tbl_num); See what I mean about "_tbl" being redundant in "tables->serdes_tbl"? > +} > static int qmp_pcie_init(struct phy *phy) > @@ -1957,15 +1995,13 @@ static int qmp_pcie_power_on(struct phy *phy) > struct qmp_phy *qphy = phy_get_drvdata(phy); > struct qcom_qmp *qmp = qphy->qmp; > const struct qmp_phy_cfg *cfg = qphy->cfg; > - void __iomem *tx = qphy->tx; > - void __iomem *rx = qphy->rx; > void __iomem *pcs = qphy->pcs; > - void __iomem *pcs_misc = qphy->pcs_misc; > void __iomem *status; > unsigned int mask, val, ready; > int ret; > > - qmp_pcie_serdes_init(qphy); > + qmp_pcie_serdes_init(qphy, &cfg->common); > + qmp_pcie_serdes_init(qphy, cfg->extra); And "common" and "extra" doesn't really say what it is you're passing here. > > ret = clk_prepare_enable(qphy->pipe_clk); > if (ret) { Johan -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2022-09-26 7:33 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-09-24 16:02 [PATCH v4 0/6] PCI: qcom: Support using the same PHY for both RC and EP Dmitry Baryshkov 2022-09-24 16:02 ` Dmitry Baryshkov 2022-09-24 16:02 ` [PATCH v4 1/6] phy: qcom-qmp-pcie: split register tables into common and extra parts Dmitry Baryshkov 2022-09-24 16:02 ` Dmitry Baryshkov 2022-09-26 6:32 ` Johan Hovold 2022-09-26 6:32 ` Johan Hovold 2022-09-26 10:22 ` Dmitry Baryshkov 2022-09-26 10:22 ` Dmitry Baryshkov 2022-09-26 7:27 ` Johan Hovold 2022-09-26 7:27 ` Johan Hovold 2022-09-26 11:35 ` Dmitry Baryshkov 2022-09-26 11:35 ` Dmitry Baryshkov 2022-09-26 13:24 ` Johan Hovold 2022-09-26 13:24 ` Johan Hovold 2022-09-24 16:02 ` [PATCH v4 2/6] phy: qcom-qmp-pcie: split PHY programming to separate functions Dmitry Baryshkov 2022-09-24 16:02 ` Dmitry Baryshkov 2022-09-26 7:33 ` Johan Hovold [this message] 2022-09-26 7:33 ` Johan Hovold 2022-09-24 16:02 ` [PATCH v4 3/6] phy: qcom-qmp-pcie: support separate tables for EP mode Dmitry Baryshkov 2022-09-24 16:02 ` Dmitry Baryshkov 2022-09-26 6:37 ` Johan Hovold 2022-09-26 6:37 ` Johan Hovold 2022-09-26 7:48 ` Johan Hovold 2022-09-26 7:48 ` Johan Hovold 2022-09-24 16:03 ` [PATCH v4 4/6] phy: qcom-qmp-pcie: Support SM8450 PCIe1 PHY in " Dmitry Baryshkov 2022-09-24 16:03 ` Dmitry Baryshkov 2022-09-24 16:03 ` [PATCH v4 5/6] PCI: qcom: Setup PHY to work in RC mode Dmitry Baryshkov 2022-09-24 16:03 ` Dmitry Baryshkov 2022-09-24 23:54 ` Han Jingoo 2022-09-24 23:54 ` Han Jingoo 2022-09-24 16:03 ` [PATCH v4 6/6] PCI: qcom-ep: Setup PHY to work in EP mode Dmitry Baryshkov 2022-09-24 16:03 ` Dmitry Baryshkov 2022-09-24 23:53 ` Han Jingoo 2022-09-24 23:53 ` Han Jingoo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YzFVyxhRidGKPR0p@hovoldconsulting.com \ --to=johan@kernel.org \ --cc=agross@kernel.org \ --cc=andersson@kernel.org \ --cc=bhelgaas@google.com \ --cc=dmitry.baryshkov@linaro.org \ --cc=gustavo.pimentel@synopsys.com \ --cc=jingoohan1@gmail.com \ --cc=kishon@ti.com \ --cc=konrad.dybcio@somainline.org \ --cc=kw@linux.com \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=linux-phy@lists.infradead.org \ --cc=lorenzo.pieralisi@arm.com \ --cc=p.zabel@pengutronix.de \ --cc=robh+dt@kernel.org \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.