From: Andi Shyti <andi.shyti@linux.intel.com>
To: Badal Nilawar <badal.nilawar@intel.com>
Cc: linux-hwmon@vger.kernel.org, intel-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 3/7] drm/i915/hwmon: Power PL1 limit and TDP setting
Date: Mon, 3 Oct 2022 23:05:14 +0200 [thread overview]
Message-ID: <YztOiqUsMTzfK4q3@ashyti-mobl2.lan> (raw)
In-Reply-To: <20220927055020.3499420-4-badal.nilawar@intel.com>
Hi Badal,
[...]
> hwm_get_preregistration_info(struct drm_i915_private *i915)
> {
> struct i915_hwmon *hwmon = i915->hwmon;
> + struct intel_uncore *uncore = &i915->uncore;
> + intel_wakeref_t wakeref;
> + u32 val_sku_unit;
>
> - if (IS_DG1(i915) || IS_DG2(i915))
> + if (IS_DG1(i915) || IS_DG2(i915)) {
> hwmon->rg.gt_perf_status = GEN12_RPSTAT1;
> - else
> + hwmon->rg.pkg_power_sku_unit = PCU_PACKAGE_POWER_SKU_UNIT;
> + hwmon->rg.pkg_power_sku = PCU_PACKAGE_POWER_SKU;
> + hwmon->rg.pkg_rapl_limit = PCU_PACKAGE_RAPL_LIMIT;
> + } else {
> hwmon->rg.gt_perf_status = INVALID_MMIO_REG;
> + hwmon->rg.pkg_power_sku_unit = INVALID_MMIO_REG;
> + hwmon->rg.pkg_power_sku = INVALID_MMIO_REG;
> + hwmon->rg.pkg_rapl_limit = INVALID_MMIO_REG;
> + }
> +
> + with_intel_runtime_pm(uncore->rpm, wakeref) {
> + /*
> + * The contents of register hwmon->rg.pkg_power_sku_unit do not change,
> + * so read it once and store the shift values.
> + */
> + if (i915_mmio_reg_valid(hwmon->rg.pkg_power_sku_unit)) {
> + val_sku_unit = intel_uncore_read(uncore,
> + hwmon->rg.pkg_power_sku_unit);
> + } else {
> + val_sku_unit = 0;
> + }
please remove the brackets here and, just a small nitpick:
move val_sky_unit inside the "with_intel_runtime_pm()" and
initialize it to '0', you will save the else statement.
Other than that:
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Thanks,
Andi
WARNING: multiple messages have this Message-ID (diff)
From: Andi Shyti <andi.shyti@linux.intel.com>
To: Badal Nilawar <badal.nilawar@intel.com>
Cc: intel-gfx@lists.freedesktop.org, linux-hwmon@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 3/7] drm/i915/hwmon: Power PL1 limit and TDP setting
Date: Mon, 3 Oct 2022 23:05:14 +0200 [thread overview]
Message-ID: <YztOiqUsMTzfK4q3@ashyti-mobl2.lan> (raw)
In-Reply-To: <20220927055020.3499420-4-badal.nilawar@intel.com>
Hi Badal,
[...]
> hwm_get_preregistration_info(struct drm_i915_private *i915)
> {
> struct i915_hwmon *hwmon = i915->hwmon;
> + struct intel_uncore *uncore = &i915->uncore;
> + intel_wakeref_t wakeref;
> + u32 val_sku_unit;
>
> - if (IS_DG1(i915) || IS_DG2(i915))
> + if (IS_DG1(i915) || IS_DG2(i915)) {
> hwmon->rg.gt_perf_status = GEN12_RPSTAT1;
> - else
> + hwmon->rg.pkg_power_sku_unit = PCU_PACKAGE_POWER_SKU_UNIT;
> + hwmon->rg.pkg_power_sku = PCU_PACKAGE_POWER_SKU;
> + hwmon->rg.pkg_rapl_limit = PCU_PACKAGE_RAPL_LIMIT;
> + } else {
> hwmon->rg.gt_perf_status = INVALID_MMIO_REG;
> + hwmon->rg.pkg_power_sku_unit = INVALID_MMIO_REG;
> + hwmon->rg.pkg_power_sku = INVALID_MMIO_REG;
> + hwmon->rg.pkg_rapl_limit = INVALID_MMIO_REG;
> + }
> +
> + with_intel_runtime_pm(uncore->rpm, wakeref) {
> + /*
> + * The contents of register hwmon->rg.pkg_power_sku_unit do not change,
> + * so read it once and store the shift values.
> + */
> + if (i915_mmio_reg_valid(hwmon->rg.pkg_power_sku_unit)) {
> + val_sku_unit = intel_uncore_read(uncore,
> + hwmon->rg.pkg_power_sku_unit);
> + } else {
> + val_sku_unit = 0;
> + }
please remove the brackets here and, just a small nitpick:
move val_sky_unit inside the "with_intel_runtime_pm()" and
initialize it to '0', you will save the else statement.
Other than that:
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Thanks,
Andi
next prev parent reply other threads:[~2022-10-03 21:05 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 5:50 [PATCH 0/7] drm/i915: Add HWMON support Badal Nilawar
2022-09-27 5:50 ` [Intel-gfx] " Badal Nilawar
2022-09-27 5:50 ` Badal Nilawar
2022-09-27 5:50 ` [PATCH 1/7] drm/i915/hwmon: Add HWMON infrastructure Badal Nilawar
2022-09-27 5:50 ` [Intel-gfx] " Badal Nilawar
2022-09-27 5:50 ` Badal Nilawar
2022-10-03 20:50 ` [Intel-gfx] " Andi Shyti
2022-10-03 20:50 ` Andi Shyti
2022-09-27 5:50 ` [PATCH 2/7] drm/i915/hwmon: Add HWMON current voltage support Badal Nilawar
2022-09-27 5:50 ` [Intel-gfx] " Badal Nilawar
2022-09-27 5:50 ` Badal Nilawar
2022-10-03 20:56 ` [Intel-gfx] " Andi Shyti
2022-10-03 20:56 ` Andi Shyti
2022-10-13 15:52 ` Dixit, Ashutosh
2022-10-13 15:52 ` Dixit, Ashutosh
2022-10-13 15:52 ` Dixit, Ashutosh
2022-09-27 5:50 ` [PATCH 3/7] drm/i915/hwmon: Power PL1 limit and TDP setting Badal Nilawar
2022-09-27 5:50 ` [Intel-gfx] " Badal Nilawar
2022-09-27 5:50 ` Badal Nilawar
2022-09-28 7:08 ` Gupta, Anshuman
2022-09-28 7:08 ` Gupta, Anshuman
2022-09-28 7:08 ` [Intel-gfx] " Gupta, Anshuman
2022-10-03 21:05 ` Andi Shyti [this message]
2022-10-03 21:05 ` Andi Shyti
2022-10-13 15:54 ` Dixit, Ashutosh
2022-10-13 15:54 ` Dixit, Ashutosh
2022-10-13 15:54 ` Dixit, Ashutosh
2022-09-27 5:50 ` [PATCH 4/7] drm/i915/hwmon: Show device level energy usage Badal Nilawar
2022-09-27 5:50 ` [Intel-gfx] " Badal Nilawar
2022-09-27 5:50 ` Badal Nilawar
2022-09-30 16:52 ` Rodrigo Vivi
2022-09-30 16:52 ` [Intel-gfx] " Rodrigo Vivi
2022-09-30 16:52 ` Rodrigo Vivi
2022-10-03 21:13 ` [Intel-gfx] " Andi Shyti
2022-10-03 21:13 ` Andi Shyti
2022-10-03 21:13 ` Andi Shyti
2022-10-13 15:54 ` Dixit, Ashutosh
2022-10-13 15:54 ` Dixit, Ashutosh
2022-10-13 15:54 ` Dixit, Ashutosh
2022-10-13 15:54 ` [Intel-gfx] " Dixit, Ashutosh
2022-10-13 15:54 ` Dixit, Ashutosh
2022-09-27 5:50 ` [PATCH 5/7] drm/i915/hwmon: Expose card reactive critical power Badal Nilawar
2022-09-27 5:50 ` [Intel-gfx] " Badal Nilawar
2022-09-27 5:50 ` Badal Nilawar
2022-10-03 21:18 ` [Intel-gfx] " Andi Shyti
2022-10-03 21:18 ` Andi Shyti
2022-09-27 5:50 ` [PATCH 6/7] drm/i915/hwmon: Expose power1_max_interval Badal Nilawar
2022-09-27 5:50 ` [Intel-gfx] " Badal Nilawar
2022-09-27 5:50 ` Badal Nilawar
2022-09-28 7:09 ` Gupta, Anshuman
2022-09-28 7:09 ` Gupta, Anshuman
2022-09-28 7:09 ` [Intel-gfx] " Gupta, Anshuman
2022-10-03 21:32 ` Andi Shyti
2022-10-03 21:32 ` Andi Shyti
2022-10-13 15:55 ` Dixit, Ashutosh
2022-10-13 15:55 ` Dixit, Ashutosh
2022-10-13 15:55 ` Dixit, Ashutosh
2022-09-27 5:50 ` [PATCH 7/7] drm/i915/hwmon: Extend power/energy for XEHPSDV Badal Nilawar
2022-09-27 5:50 ` [Intel-gfx] " Badal Nilawar
2022-09-27 5:50 ` Badal Nilawar
2022-10-03 21:40 ` [Intel-gfx] " Andi Shyti
2022-10-03 21:40 ` Andi Shyti
2022-09-27 7:13 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add HWMON support (rev8) Patchwork
2022-09-27 7:13 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-09-27 7:36 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2022-09-29 6:51 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-09-30 4:19 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2022-10-13 15:45 [PATCH 0/7] drm/i915: Add HWMON support Ashutosh Dixit
2022-10-13 15:45 ` [Intel-gfx] [PATCH 3/7] drm/i915/hwmon: Power PL1 limit and TDP setting Ashutosh Dixit
2022-09-26 17:52 [PATCH 0/7] Add HWMON support Badal Nilawar
2022-09-26 17:52 ` [Intel-gfx] [PATCH 3/7] drm/i915/hwmon: Power PL1 limit and TDP setting Badal Nilawar
2022-09-27 13:51 ` Gupta, Anshuman
2022-09-23 19:56 [PATCH 0/7] drm/i915: Add HWMON support Badal Nilawar
2022-09-23 19:56 ` [Intel-gfx] [PATCH 3/7] drm/i915/hwmon: Power PL1 limit and TDP setting Badal Nilawar
2022-09-16 15:00 [PATCH 0/7] drm/i915: Add HWMON support Badal Nilawar
2022-09-16 15:00 ` [Intel-gfx] [PATCH 3/7] drm/i915/hwmon: Power PL1 limit and TDP setting Badal Nilawar
2022-09-16 18:29 ` kernel test robot
2022-09-21 0:02 ` Dixit, Ashutosh
2022-09-21 11:44 ` Tvrtko Ursulin
2022-09-21 11:45 ` Gupta, Anshuman
2022-09-21 14:53 ` Nilawar, Badal
2022-09-22 7:08 ` Gupta, Anshuman
2022-09-23 2:26 ` Dixit, Ashutosh
2022-08-25 13:21 [PATCH 0/7] drm/i915: Add HWMON support Badal Nilawar
2022-08-25 13:21 ` [Intel-gfx] [PATCH 3/7] drm/i915/hwmon: Power PL1 limit and TDP setting Badal Nilawar
2022-08-30 2:33 ` Dixit, Ashutosh
2022-08-18 19:38 [PATCH 0/7] drm/i915: Add HWMON support Badal Nilawar
2022-08-18 19:38 ` [Intel-gfx] [PATCH 3/7] drm/i915/hwmon: Power PL1 limit and TDP setting Badal Nilawar
2022-08-12 17:37 [PATCH 0/7] drm/i915: Add HWMON support Badal Nilawar
2022-08-12 17:37 ` [Intel-gfx] [PATCH 3/7] drm/i915/hwmon: Power PL1 limit and TDP setting Badal Nilawar
2022-08-12 18:06 ` Guenter Roeck
2023-02-28 21:18 ` Dixit, Ashutosh
2023-03-09 16:33 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YztOiqUsMTzfK4q3@ashyti-mobl2.lan \
--to=andi.shyti@linux.intel.com \
--cc=badal.nilawar@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-hwmon@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.