From: Johan Hovold <johan@kernel.org> To: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Cc: johan+linaro@kernel.org, a.swigon@samsung.com, agross@kernel.org, alim.akhtar@samsung.com, andersson@kernel.org, djakov@kernel.org, festevam@gmail.com, jonathanh@nvidia.com, kernel@pengutronix.de, konrad.dybcio@linaro.org, krzysztof.kozlowski@linaro.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org, s.hauer@pengutronix.de, s.nawrocki@samsung.com, shawnguo@kernel.org, stable@vger.kernel.org, thierry.reding@gmail.com, y.oudjana@protonmail.com Subject: Re: [PATCH 07/23] interconnect: qcom: rpm: fix probe PM domain error handling Date: Mon, 13 Mar 2023 09:18:44 +0100 [thread overview] Message-ID: <ZA7cZBF58yMSjG/+@hovoldconsulting.com> (raw) In-Reply-To: <641d04a3-9236-fe76-a20f-11466a01460e@wanadoo.fr> On Sat, Mar 11, 2023 at 07:17:50PM +0100, Christophe JAILLET wrote: > Le 01/02/2023 à 11:15, Johan Hovold a écrit : > > Make sure to disable clocks also in case attaching the power domain > > fails. > > > > Fixes: 7de109c0abe9 ("interconnect: icc-rpm: Add support for bus power domain") > > Cc: stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org # 5.17 > > Cc: Yassine Oudjana <y.oudjana-g/b1ySJe57IN+BqQ9rBEUg@public.gmane.org> > > Signed-off-by: Johan Hovold <johan+linaro-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> > > --- > > drivers/interconnect/qcom/icc-rpm.c | 9 ++++----- > > 1 file changed, 4 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/interconnect/qcom/icc-rpm.c b/drivers/interconnect/qcom/icc-rpm.c > > index 91778cfcbc65..da595059cafd 100644 > > --- a/drivers/interconnect/qcom/icc-rpm.c > > +++ b/drivers/interconnect/qcom/icc-rpm.c > > @@ -498,8 +498,7 @@ int qnoc_probe(struct platform_device *pdev) > > > > if (desc->has_bus_pd) { > > ret = dev_pm_domain_attach(dev, true); > > - if (ret) > > - return ret; > > + goto err_disable_clks; > > Hi, > this change looks strange because we now skip the rest of the function. > > Is it really intended? No, this was definitely not intentional. Thanks for catching this. I'll send a follow up fix for Georgi to fold in or apply on top. > Also, should dev_pm_domain_detach() be called somewhere in the error > handling path and remove function ? In principle, yes. (I think read the above as being another device managed resource.) It turns out, however, that this code is totally bogus as any power domain would already have been attached by the platform bus code and the above call would always just succeed. The platform code would also handle detach on errors. I'll send a patch to remove this. Johan
WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <johan@kernel.org> To: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Cc: johan+linaro@kernel.org, a.swigon@samsung.com, agross@kernel.org, alim.akhtar@samsung.com, andersson@kernel.org, djakov@kernel.org, festevam@gmail.com, jonathanh@nvidia.com, kernel@pengutronix.de, konrad.dybcio@linaro.org, krzysztof.kozlowski@linaro.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org, s.hauer@pengutronix.de, s.nawrocki@samsung.com, shawnguo@kernel.org, stable@vger.kernel.org, thierry.reding@gmail.com, y.oudjana@protonmail.com Subject: Re: [PATCH 07/23] interconnect: qcom: rpm: fix probe PM domain error handling Date: Mon, 13 Mar 2023 09:18:44 +0100 [thread overview] Message-ID: <ZA7cZBF58yMSjG/+@hovoldconsulting.com> (raw) In-Reply-To: <641d04a3-9236-fe76-a20f-11466a01460e@wanadoo.fr> On Sat, Mar 11, 2023 at 07:17:50PM +0100, Christophe JAILLET wrote: > Le 01/02/2023 à 11:15, Johan Hovold a écrit : > > Make sure to disable clocks also in case attaching the power domain > > fails. > > > > Fixes: 7de109c0abe9 ("interconnect: icc-rpm: Add support for bus power domain") > > Cc: stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org # 5.17 > > Cc: Yassine Oudjana <y.oudjana-g/b1ySJe57IN+BqQ9rBEUg@public.gmane.org> > > Signed-off-by: Johan Hovold <johan+linaro-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> > > --- > > drivers/interconnect/qcom/icc-rpm.c | 9 ++++----- > > 1 file changed, 4 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/interconnect/qcom/icc-rpm.c b/drivers/interconnect/qcom/icc-rpm.c > > index 91778cfcbc65..da595059cafd 100644 > > --- a/drivers/interconnect/qcom/icc-rpm.c > > +++ b/drivers/interconnect/qcom/icc-rpm.c > > @@ -498,8 +498,7 @@ int qnoc_probe(struct platform_device *pdev) > > > > if (desc->has_bus_pd) { > > ret = dev_pm_domain_attach(dev, true); > > - if (ret) > > - return ret; > > + goto err_disable_clks; > > Hi, > this change looks strange because we now skip the rest of the function. > > Is it really intended? No, this was definitely not intentional. Thanks for catching this. I'll send a follow up fix for Georgi to fold in or apply on top. > Also, should dev_pm_domain_detach() be called somewhere in the error > handling path and remove function ? In principle, yes. (I think read the above as being another device managed resource.) It turns out, however, that this code is totally bogus as any power domain would already have been attached by the platform bus code and the above call would always just succeed. The platform code would also handle detach on errors. I'll send a patch to remove this. Johan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-13 8:17 UTC|newest] Thread overview: 118+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-02-01 10:15 [PATCH 00/23] interconnect: fix racy provider registration Johan Hovold 2023-02-01 10:15 ` Johan Hovold 2023-02-01 10:15 ` [PATCH 01/23] interconnect: fix mem leak when freeing nodes Johan Hovold 2023-02-01 10:15 ` Johan Hovold 2023-02-01 11:18 ` Konrad Dybcio 2023-02-01 11:18 ` Konrad Dybcio 2023-02-01 10:15 ` [PATCH 02/23] interconnect: fix icc_provider_del() error handling Johan Hovold 2023-02-01 10:15 ` Johan Hovold 2023-02-01 11:16 ` Konrad Dybcio 2023-02-01 11:16 ` Konrad Dybcio 2023-02-01 10:15 ` [PATCH 03/23] interconnect: fix provider registration API Johan Hovold 2023-02-01 10:15 ` Johan Hovold 2023-02-03 2:48 ` Konrad Dybcio 2023-02-03 2:48 ` Konrad Dybcio 2023-02-01 10:15 ` [PATCH 04/23] interconnect: imx: fix registration race Johan Hovold 2023-02-01 10:15 ` Johan Hovold 2023-02-03 2:49 ` Konrad Dybcio 2023-02-03 2:49 ` Konrad Dybcio 2023-02-03 16:01 ` Luca Ceresoli 2023-02-03 16:01 ` Luca Ceresoli 2023-02-06 8:09 ` Johan Hovold 2023-02-06 8:09 ` Johan Hovold 2023-02-06 20:52 ` Luca Ceresoli 2023-02-06 20:52 ` Luca Ceresoli 2023-02-01 10:15 ` [PATCH 05/23] interconnect: qcom: osm-l3: " Johan Hovold 2023-02-01 10:15 ` Johan Hovold 2023-02-03 2:51 ` Konrad Dybcio 2023-02-03 2:51 ` Konrad Dybcio 2023-02-01 10:15 ` [PATCH 06/23] interconnect: qcom: rpm: fix probe child-node error handling Johan Hovold 2023-02-01 10:15 ` Johan Hovold 2023-02-03 2:52 ` Konrad Dybcio 2023-02-03 2:52 ` Konrad Dybcio 2023-02-01 10:15 ` [PATCH 07/23] interconnect: qcom: rpm: fix probe PM domain " Johan Hovold 2023-02-01 10:15 ` Johan Hovold 2023-02-03 2:53 ` Konrad Dybcio 2023-02-03 2:53 ` Konrad Dybcio 2023-03-11 18:17 ` Christophe JAILLET 2023-03-11 18:17 ` Christophe JAILLET 2023-03-13 8:18 ` Johan Hovold [this message] 2023-03-13 8:18 ` Johan Hovold 2023-02-01 10:15 ` [PATCH 08/23] interconnect: qcom: rpm: fix registration race Johan Hovold 2023-02-01 10:15 ` Johan Hovold 2023-02-03 2:53 ` Konrad Dybcio 2023-02-03 2:53 ` Konrad Dybcio 2023-02-03 4:06 ` Jun Nie 2023-02-03 4:06 ` Jun Nie 2023-02-01 10:15 ` [PATCH 09/23] interconnect: qcom: rpmh: fix probe child-node error handling Johan Hovold 2023-02-01 10:15 ` Johan Hovold 2023-02-03 2:54 ` Konrad Dybcio 2023-02-03 2:54 ` Konrad Dybcio 2023-02-01 10:15 ` [PATCH 10/23] interconnect: qcom: rpmh: fix registration race Johan Hovold 2023-02-01 10:15 ` Johan Hovold 2023-02-03 2:55 ` Konrad Dybcio 2023-02-03 2:55 ` Konrad Dybcio 2023-02-01 10:15 ` [PATCH 11/23] interconnect: qcom: msm8974: " Johan Hovold 2023-02-01 10:15 ` Johan Hovold 2023-02-02 23:13 ` Brian Masney 2023-02-02 23:13 ` Brian Masney 2023-02-03 2:56 ` Konrad Dybcio 2023-02-03 2:56 ` Konrad Dybcio 2023-02-01 10:15 ` [PATCH 12/23] interconnect: qcom: sm8450: " Johan Hovold 2023-02-01 10:15 ` Johan Hovold 2023-02-03 2:56 ` Konrad Dybcio 2023-02-03 2:56 ` Konrad Dybcio 2023-02-06 12:10 ` Vinod Koul 2023-02-06 12:10 ` Vinod Koul 2023-02-01 10:15 ` [PATCH 13/23] interconnect: qcom: sm8550: " Johan Hovold 2023-02-01 10:15 ` Johan Hovold 2023-02-01 10:20 ` Abel Vesa 2023-02-01 10:20 ` Abel Vesa 2023-02-03 2:57 ` Konrad Dybcio 2023-02-03 2:57 ` Konrad Dybcio 2023-02-01 10:15 ` [PATCH 14/23] interconnect: exynos: fix node leak in probe PM QoS error path Johan Hovold 2023-02-01 10:15 ` Johan Hovold 2023-02-02 10:58 ` Krzysztof Kozlowski 2023-02-02 10:58 ` Krzysztof Kozlowski 2023-02-01 10:15 ` [PATCH 15/23] interconnect: exynos: fix registration race Johan Hovold 2023-02-01 10:15 ` Johan Hovold 2023-02-02 11:04 ` Krzysztof Kozlowski 2023-02-02 11:04 ` Krzysztof Kozlowski 2023-02-02 12:17 ` Johan Hovold 2023-02-02 12:17 ` Johan Hovold 2023-02-02 12:20 ` Krzysztof Kozlowski 2023-02-02 12:20 ` Krzysztof Kozlowski 2023-02-01 10:15 ` [PATCH 16/23] interconnect: exynos: drop redundant link destroy Johan Hovold 2023-02-01 10:15 ` Johan Hovold 2023-02-02 11:09 ` Krzysztof Kozlowski 2023-02-02 11:09 ` Krzysztof Kozlowski 2023-02-01 10:15 ` [PATCH 17/23] memory: tegra: fix interconnect registration race Johan Hovold 2023-02-01 10:15 ` Johan Hovold 2023-02-02 12:21 ` Krzysztof Kozlowski 2023-02-02 12:21 ` Krzysztof Kozlowski 2023-02-01 10:15 ` [PATCH 18/23] memory: tegra124-emc: " Johan Hovold 2023-02-01 10:15 ` Johan Hovold 2023-02-02 12:21 ` Krzysztof Kozlowski 2023-02-02 12:21 ` Krzysztof Kozlowski 2023-02-01 10:15 ` [PATCH 19/23] memory: tegra20-emc: " Johan Hovold 2023-02-01 10:15 ` Johan Hovold 2023-02-02 12:21 ` Krzysztof Kozlowski 2023-02-02 12:21 ` Krzysztof Kozlowski 2023-02-01 10:15 ` [PATCH 20/23] memory: tegra30-emc: " Johan Hovold 2023-02-01 10:15 ` Johan Hovold 2023-02-02 12:21 ` Krzysztof Kozlowski 2023-02-02 12:21 ` Krzysztof Kozlowski 2023-02-01 10:15 ` [PATCH 21/23] interconnect: drop racy registration API Johan Hovold 2023-02-01 10:15 ` Johan Hovold 2023-02-03 2:58 ` Konrad Dybcio 2023-02-03 2:58 ` Konrad Dybcio 2023-02-01 10:15 ` [PATCH 22/23] interconnect: drop unused icc_get() interface Johan Hovold 2023-02-01 10:15 ` Johan Hovold 2023-02-03 2:59 ` Konrad Dybcio 2023-02-03 2:59 ` Konrad Dybcio 2023-02-01 10:15 ` [PATCH 23/23] interconnect: drop unused icc_link_destroy() interface Johan Hovold 2023-02-01 10:15 ` Johan Hovold 2023-02-02 11:13 ` [PATCH 00/23] interconnect: fix racy provider registration Krzysztof Kozlowski 2023-02-02 11:13 ` Krzysztof Kozlowski 2023-02-02 12:20 ` Johan Hovold 2023-02-02 12:20 ` Johan Hovold
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ZA7cZBF58yMSjG/+@hovoldconsulting.com \ --to=johan@kernel.org \ --cc=a.swigon@samsung.com \ --cc=agross@kernel.org \ --cc=alim.akhtar@samsung.com \ --cc=andersson@kernel.org \ --cc=christophe.jaillet@wanadoo.fr \ --cc=djakov@kernel.org \ --cc=festevam@gmail.com \ --cc=johan+linaro@kernel.org \ --cc=jonathanh@nvidia.com \ --cc=kernel@pengutronix.de \ --cc=konrad.dybcio@linaro.org \ --cc=krzysztof.kozlowski@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=linux-tegra@vger.kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=s.nawrocki@samsung.com \ --cc=shawnguo@kernel.org \ --cc=stable@vger.kernel.org \ --cc=thierry.reding@gmail.com \ --cc=y.oudjana@protonmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.