All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Hocko <mhocko@suse.com>
To: Valentin Schneider <vschneid@redhat.com>
Cc: "Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
	cgroups@vger.kernel.org, linux-mm@kvack.org,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Johannes Weiner" <hannes@cmpxchg.org>,
	"Michal Koutný" <mkoutny@suse.com>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Vladimir Davydov" <vdavydov.dev@gmail.com>,
	"Waiman Long" <longman@redhat.com>,
	"Roman Gushchin" <guro@fb.com>,
	"Shakeel Butt" <shakeelb@google.com>
Subject: Re: [PATCH v5 2/6] mm/memcg: Disable threshold event handlers on PREEMPT_RT
Date: Thu, 2 Mar 2023 12:24:27 +0100	[thread overview]
Message-ID: <ZACHa4wrtwpQbmP2@dhcp22.suse.cz> (raw)
In-Reply-To: <xhsmh1qm7pibs.mognet@vschneid.remote.csb>

On Thu 02-03-23 10:18:31, Valentin Schneider wrote:
> On 02/03/23 08:45, Michal Hocko wrote:
> > On Wed 01-03-23 18:23:19, Valentin Schneider wrote:
[...]
> >> I want cgroupv1 to die as much as the next person, but in that specific
> >> situation I kinda need cgroupv1 to behave somewhat sanely on RT with
> >> threshold events :/
> >
> > Could you expand on the usecase?
> >
> 
> In this case it's just some middleware leveraging memcontrol cgroups and
> setting up callbacks for in-cgroup OOM events. This is a supported feature
> in cgroupv2, so this isn't a problem of cgroupv1 vs cgroupv2 feature
> parity, but rather one of being in a transitional phase where the
> middleware itself hasn't fully migrated to using cgroupv2.

How is this related to the RT kernel config? memcg OOM vs any RT
assumptions do not really get along well AFAICT.

-- 
Michal Hocko
SUSE Labs


WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko-IBi9RG/b67k@public.gmane.org>
To: Valentin Schneider <vschneid-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: "Sebastian Andrzej Siewior"
	<bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
	"Andrew Morton"
	<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
	"Johannes Weiner"
	<hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
	"Michal Koutný" <mkoutny-IBi9RG/b67k@public.gmane.org>,
	"Peter Zijlstra" <peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
	"Thomas Gleixner" <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
	"Vladimir Davydov"
	<vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	"Waiman Long" <longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	"Roman Gushchin" <guro-b10kYP2dOMg@public.gmane.org>,
	"Shakeel Butt" <shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH v5 2/6] mm/memcg: Disable threshold event handlers on PREEMPT_RT
Date: Thu, 2 Mar 2023 12:24:27 +0100	[thread overview]
Message-ID: <ZACHa4wrtwpQbmP2@dhcp22.suse.cz> (raw)
In-Reply-To: <xhsmh1qm7pibs.mognet-lVOlpLwaOlUmbyhZVYo91WPO1xz+ivuR@public.gmane.org>

On Thu 02-03-23 10:18:31, Valentin Schneider wrote:
> On 02/03/23 08:45, Michal Hocko wrote:
> > On Wed 01-03-23 18:23:19, Valentin Schneider wrote:
[...]
> >> I want cgroupv1 to die as much as the next person, but in that specific
> >> situation I kinda need cgroupv1 to behave somewhat sanely on RT with
> >> threshold events :/
> >
> > Could you expand on the usecase?
> >
> 
> In this case it's just some middleware leveraging memcontrol cgroups and
> setting up callbacks for in-cgroup OOM events. This is a supported feature
> in cgroupv2, so this isn't a problem of cgroupv1 vs cgroupv2 feature
> parity, but rather one of being in a transitional phase where the
> middleware itself hasn't fully migrated to using cgroupv2.

How is this related to the RT kernel config? memcg OOM vs any RT
assumptions do not really get along well AFAICT.

-- 
Michal Hocko
SUSE Labs

  reply	other threads:[~2023-03-02 11:24 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-26 20:41 [PATCH v5 0/6] mm/memcg: Address PREEMPT_RT problems instead of disabling it Sebastian Andrzej Siewior
2022-02-26 20:41 ` Sebastian Andrzej Siewior
2022-02-26 20:41 ` [PATCH v5 1/6] mm/memcg: Revert ("mm/memcg: optimize user context object stock access") Sebastian Andrzej Siewior
2022-02-26 20:41   ` Sebastian Andrzej Siewior
2022-02-26 20:41 ` [PATCH v5 2/6] mm/memcg: Disable threshold event handlers on PREEMPT_RT Sebastian Andrzej Siewior
2022-02-26 20:41   ` Sebastian Andrzej Siewior
2023-03-01 18:23   ` Valentin Schneider
2023-03-01 18:23     ` Valentin Schneider
2023-03-02  7:45     ` Michal Hocko
2023-03-02  7:45       ` Michal Hocko
2023-03-02 10:18       ` Valentin Schneider
2023-03-02 10:18         ` Valentin Schneider
2023-03-02 11:24         ` Michal Hocko [this message]
2023-03-02 11:24           ` Michal Hocko
2023-03-02 12:30           ` Valentin Schneider
2023-03-02 12:30             ` Valentin Schneider
2023-03-02 12:56             ` Michal Hocko
2023-03-02 12:56               ` Michal Hocko
2023-03-02 14:34               ` Valentin Schneider
2023-03-02 14:34                 ` Valentin Schneider
2023-03-02 19:52                 ` Valentin Schneider
2023-03-02 19:52                   ` Valentin Schneider
2022-02-26 20:41 ` [PATCH v5 3/6] mm/memcg: Protect per-CPU counter by disabling preemption on PREEMPT_RT where needed Sebastian Andrzej Siewior
2022-02-26 20:41   ` Sebastian Andrzej Siewior
2022-02-28  8:05   ` Michal Hocko
2022-02-28  8:05     ` Michal Hocko
2022-02-28 11:08     ` Sebastian Andrzej Siewior
2022-02-28 11:08       ` Sebastian Andrzej Siewior
2022-02-28 11:23       ` Michal Hocko
2022-02-28 11:23         ` Michal Hocko
2022-02-28 12:35         ` Sebastian Andrzej Siewior
2022-02-28 12:35           ` Sebastian Andrzej Siewior
2022-02-26 20:41 ` [PATCH v5 4/6] mm/memcg: Opencode the inner part of obj_cgroup_uncharge_pages() in drain_obj_stock() Sebastian Andrzej Siewior
2022-02-26 20:41   ` Sebastian Andrzej Siewior
2022-02-26 20:41 ` [PATCH v5 5/6] mm/memcg: Protect memcg_stock with a local_lock_t Sebastian Andrzej Siewior
2022-02-26 20:41   ` Sebastian Andrzej Siewior
2022-02-28  8:06   ` Michal Hocko
2022-02-28  8:06     ` Michal Hocko
2022-02-26 20:41 ` [PATCH v5 6/6] mm/memcg: Disable migration instead of preemption in drain_all_stock() Sebastian Andrzej Siewior
2022-02-26 20:41   ` Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZACHa4wrtwpQbmP2@dhcp22.suse.cz \
    --to=mhocko@suse.com \
    --cc=akpm@linux-foundation.org \
    --cc=bigeasy@linutronix.de \
    --cc=cgroups@vger.kernel.org \
    --cc=guro@fb.com \
    --cc=hannes@cmpxchg.org \
    --cc=linux-mm@kvack.org \
    --cc=longman@redhat.com \
    --cc=mkoutny@suse.com \
    --cc=peterz@infradead.org \
    --cc=shakeelb@google.com \
    --cc=tglx@linutronix.de \
    --cc=vdavydov.dev@gmail.com \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.