Re: [PATCH v13 07/10] drm/bridge: anx7625: Register Type C mode switches

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Pin-yen Lin <treapking@chromium.org>
Cc: "Andrzej Hajda" <andrzej.hajda@intel.com>,
	"Neil Armstrong" <neil.armstrong@linaro.org>,
	"Robert Foss" <rfoss@kernel.org>,
	"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
	"Jonas Karlman" <jonas@kwiboo.se>,
	"Jernej Skrabec" <jernej.skrabec@gmail.com>,
	"David Airlie" <airlied@gmail.com>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Daniel Scally" <djrscally@gmail.com>,
	"Heikki Krogerus" <heikki.krogerus@linux.intel.com>,
	"Sakari Ailus" <sakari.ailus@linux.intel.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	"Prashant Malani" <pmalani@chromium.org>,
	"Benson Leung" <bleung@chromium.org>,
	"Guenter Roeck" <groeck@chromium.org>,
	"Xin Ji" <xji@analogixsemi.com>,
	"Javier Martinez Canillas" <javierm@redhat.com>,
	"Lyude Paul" <lyude@redhat.com>,
	linux-kernel@vger.kernel.org,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	chrome-platform@lists.linux.dev,
	"Nícolas F . R . A . Prado" <nfraprado@collabora.com>,
	"Marek Vasut" <marex@denx.de>,
	"Hsin-Yi Wang" <hsinyi@chromium.org>,
	devicetree@vger.kernel.org, "Allen Chen" <allen.chen@ite.com.tw>,
	dri-devel@lists.freedesktop.org,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"Stephen Boyd" <swboyd@chromium.org>,
	linux-acpi@vger.kernel.org
Subject: Re: [PATCH v13 07/10] drm/bridge: anx7625: Register Type C mode switches
Date: Mon, 6 Mar 2023 13:55:24 +0200	[thread overview]
Message-ID: <ZAXUrJDtHmm7+50H@smile.fi.intel.com> (raw)
In-Reply-To: <20230303143350.815623-8-treapking@chromium.org>

On Fri, Mar 03, 2023 at 10:33:47PM +0800, Pin-yen Lin wrote:
> Register USB Type-C mode switches when the "mode-switch" property and
> relevant ports are available in Device Tree. Configure the crosspoint
> switch based on the entered alternate mode for a specific Type-C
> connector.
> 
> Crosspoint switch can also be used for switching the output signal for
> different orientations of a single USB Type-C connector, but the
> orientation switch is not implemented yet. A TODO is added for this.

...

> +	ctx->port_data = devm_kcalloc(
> +		dev, switch_desc->num_typec_switches,
> +		sizeof(struct anx7625_typec_port_data), GFP_KERNEL);

I believe I have commented on this (indentation)...

> +

...and this (blank line).

> +	if (!ctx->port_data) {
> +		ret = -ENOMEM;
> +		goto unregister_mux;
> +	}

...

> +		ctx->port_data[i].orientation = (dp_lanes[0] / 2 == 0) ?
> +			TYPEC_ORIENTATION_REVERSE : TYPEC_ORIENTATION_NORMAL;

I believe that this is an error prone check, you should rather do the opposite,
i.e.  ' % 2  == 0'.

-- 
With Best Regards,
Andy Shevchenko