All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Magnus Damm <magnus.damm@gmail.com>,
	Saravana Kannan <saravanak@google.com>,
	linux-renesas-soc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] soc: renesas: rmobile-sysc: Use of_fwnode_handle() helper
Date: Wed, 8 Mar 2023 18:22:39 +0200	[thread overview]
Message-ID: <ZAi2T4mYefbLTI9U@smile.fi.intel.com> (raw)
In-Reply-To: <d49b9fb20d68709b12692558aca91997e6b06fb4.1678272276.git.geert+renesas@glider.be>

On Wed, Mar 08, 2023 at 11:48:17AM +0100, Geert Uytterhoeven wrote:
> Use the existing of_fwnode_handle() helper instead of open-coding the
> same operation.

LGTM,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> To be queued in renesas-devel-for-v6.4.
> 
>  drivers/soc/renesas/rmobile-sysc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/renesas/rmobile-sysc.c b/drivers/soc/renesas/rmobile-sysc.c
> index 204e6135180b919c..728ebac98e14a5cc 100644
> --- a/drivers/soc/renesas/rmobile-sysc.c
> +++ b/drivers/soc/renesas/rmobile-sysc.c
> @@ -343,7 +343,7 @@ static int __init rmobile_init_pm_domains(void)
>  			break;
>  		}
>  
> -		fwnode_dev_initialized(&np->fwnode, true);
> +		fwnode_dev_initialized(of_fwnode_handle(np), true);
>  	}
>  
>  	put_special_pds();

-- 
With Best Regards,
Andy Shevchenko



WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Magnus Damm <magnus.damm@gmail.com>,
	Saravana Kannan <saravanak@google.com>,
	linux-renesas-soc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] soc: renesas: rmobile-sysc: Use of_fwnode_handle() helper
Date: Wed, 8 Mar 2023 18:22:39 +0200	[thread overview]
Message-ID: <ZAi2T4mYefbLTI9U@smile.fi.intel.com> (raw)
In-Reply-To: <d49b9fb20d68709b12692558aca91997e6b06fb4.1678272276.git.geert+renesas@glider.be>

On Wed, Mar 08, 2023 at 11:48:17AM +0100, Geert Uytterhoeven wrote:
> Use the existing of_fwnode_handle() helper instead of open-coding the
> same operation.

LGTM,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> To be queued in renesas-devel-for-v6.4.
> 
>  drivers/soc/renesas/rmobile-sysc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/renesas/rmobile-sysc.c b/drivers/soc/renesas/rmobile-sysc.c
> index 204e6135180b919c..728ebac98e14a5cc 100644
> --- a/drivers/soc/renesas/rmobile-sysc.c
> +++ b/drivers/soc/renesas/rmobile-sysc.c
> @@ -343,7 +343,7 @@ static int __init rmobile_init_pm_domains(void)
>  			break;
>  		}
>  
> -		fwnode_dev_initialized(&np->fwnode, true);
> +		fwnode_dev_initialized(of_fwnode_handle(np), true);
>  	}
>  
>  	put_special_pds();

-- 
With Best Regards,
Andy Shevchenko



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-03-08 16:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-08 10:48 [PATCH] soc: renesas: rmobile-sysc: Use of_fwnode_handle() helper Geert Uytterhoeven
2023-03-08 10:48 ` Geert Uytterhoeven
2023-03-08 16:22 ` Andy Shevchenko [this message]
2023-03-08 16:22   ` Andy Shevchenko
2023-03-08 20:35   ` Saravana Kannan
2023-03-08 20:35     ` Saravana Kannan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZAi2T4mYefbLTI9U@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=geert+renesas@glider.be \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=saravanak@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.