From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Mickaël Salaün" <mic@digikod.net>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Randy Dunlap" <rdunlap@infradead.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Niklas Schnelle" <schnelle@linux.ibm.com>,
"Bjorn Helgaas" <helgaas@kernel.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
"Pali Rohár" <pali@kernel.org>,
"Maciej W. Rozycki" <macro@orcam.me.uk>,
"Juergen Gross" <jgross@suse.com>,
"Dominik Brodowski" <linux@dominikbrodowski.net>,
linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org,
sparclinux@vger.kernel.org, linux-pci@vger.kernel.org,
xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org
Cc: Miguel Ojeda <ojeda@kernel.org>,
Richard Henderson <richard.henderson@linaro.org>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Matt Turner <mattst88@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Gregory Clement <gregory.clement@bootlin.com>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Nicholas Piggin <npiggin@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Anatolij Gustschin <agust@denx.de>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
"David S. Miller" <davem@davemloft.net>,
Bjorn Helgaas <bhelgaas@google.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Subject: Re: [PATCH v8 7/7] pcmcia: Convert to use less arguments in pci_bus_for_each_resource()
Date: Wed, 5 Apr 2023 11:30:18 +0300 [thread overview]
Message-ID: <ZC0xmk71jQrx3AeH@smile.fi.intel.com> (raw)
In-Reply-To: <20230330162434.35055-8-andriy.shevchenko@linux.intel.com>
On Thu, Mar 30, 2023 at 07:24:34PM +0300, Andy Shevchenko wrote:
...
> @@ -960,12 +960,9 @@ static int nonstatic_autoadd_resources(struct pcmcia_socket *s)
> */
> if (s->cb_dev->bus->number == 0)
> return -EINVAL;
> -
> - for (i = 0; i < PCI_BRIDGE_RESOURCE_NUM; i++) {
> - res = s->cb_dev->bus->resource[i];
> -#else
> - pci_bus_for_each_resource(s->cb_dev->bus, res, i) {
> #endif
> +
> + pci_bus_for_each_resource(s->cb_dev->bus, res) {
> if (!res)
> continue;
As pointed out in the reply to Bjorn's email this hunk needs to be revisited,
since I wrote the documentation for the above call I have started understanding
the deal behind this special treatment for X86 case.
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Mickaël Salaün" <mic@digikod.net>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Randy Dunlap" <rdunlap@infradead.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Niklas Schnelle" <schnelle@linux.ibm.com>,
"Bjorn Helgaas" <helgaas@kernel.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
"Pali Rohár" <pali@kernel.org>,
"Maciej W. Rozycki" <macro@orcam.me.uk>,
"Juergen Gross" <jgross@suse.com>,
"Dominik Brodowski" <linux@dominikbrodowski.net>,
linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org,
sparclinux@vger.kernel.org, linux-pci@vger.kernel.org,
xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org
Cc: Andrew Lunn <andrew@lunn.ch>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Stefano Stabellini <sstabellini@kernel.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
Gregory Clement <gregory.clement@bootlin.com>,
Richard Henderson <richard.henderson@linaro.org>,
Russell King <linux@armlinux.org.uk>,
Nicholas Piggin <npiggin@gmail.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Rich Felker <dalias@libc.org>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
Miguel Ojeda <ojeda@kernel.org>, Matt Turner <mattst88@gmail.com>,
Anatolij Gustschin <agust@denx.de>,
"David S. Miller" <davem@davemloft.net>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH v8 7/7] pcmcia: Convert to use less arguments in pci_bus_for_each_resource()
Date: Wed, 5 Apr 2023 11:30:18 +0300 [thread overview]
Message-ID: <ZC0xmk71jQrx3AeH@smile.fi.intel.com> (raw)
In-Reply-To: <20230330162434.35055-8-andriy.shevchenko@linux.intel.com>
On Thu, Mar 30, 2023 at 07:24:34PM +0300, Andy Shevchenko wrote:
...
> @@ -960,12 +960,9 @@ static int nonstatic_autoadd_resources(struct pcmcia_socket *s)
> */
> if (s->cb_dev->bus->number == 0)
> return -EINVAL;
> -
> - for (i = 0; i < PCI_BRIDGE_RESOURCE_NUM; i++) {
> - res = s->cb_dev->bus->resource[i];
> -#else
> - pci_bus_for_each_resource(s->cb_dev->bus, res, i) {
> #endif
> +
> + pci_bus_for_each_resource(s->cb_dev->bus, res) {
> if (!res)
> continue;
As pointed out in the reply to Bjorn's email this hunk needs to be revisited,
since I wrote the documentation for the above call I have started understanding
the deal behind this special treatment for X86 case.
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Mickaël Salaün" <mic@digikod.net>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Randy Dunlap" <rdunlap@infradead.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Niklas Schnelle" <schnelle@linux.ibm.com>,
"Bjorn Helgaas" <helgaas@kernel.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
"Pali Rohár" <pali@kernel.org>,
"Maciej W. Rozycki" <macro@orcam.me.uk>,
"Juergen Gross" <jgross@suse.com>,
"Dominik Brodowski" <linux@dominikbrodowski.net>,
linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org,
sparclinux@vger.kernel.org, linux-pci@vger.kernel.org,
xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org
Cc: Miguel Ojeda <ojeda@kernel.org>,
Richard Henderson <richard.henderson@linaro.org>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Matt Turner <mattst88@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Gregory Clement <gregory.clement@bootlin.com>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Nicholas Piggin <npiggin@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Anatolij Gustschin <agust@denx.de>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
"David S. Miller" <davem@davemloft.net>,
Bjorn Helgaas <bhelgaas@google.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Subject: Re: [PATCH v8 7/7] pcmcia: Convert to use less arguments in pci_bus_for_each_resource()
Date: Wed, 5 Apr 2023 11:30:18 +0300 [thread overview]
Message-ID: <ZC0xmk71jQrx3AeH@smile.fi.intel.com> (raw)
In-Reply-To: <20230330162434.35055-8-andriy.shevchenko@linux.intel.com>
On Thu, Mar 30, 2023 at 07:24:34PM +0300, Andy Shevchenko wrote:
...
> @@ -960,12 +960,9 @@ static int nonstatic_autoadd_resources(struct pcmcia_socket *s)
> */
> if (s->cb_dev->bus->number == 0)
> return -EINVAL;
> -
> - for (i = 0; i < PCI_BRIDGE_RESOURCE_NUM; i++) {
> - res = s->cb_dev->bus->resource[i];
> -#else
> - pci_bus_for_each_resource(s->cb_dev->bus, res, i) {
> #endif
> +
> + pci_bus_for_each_resource(s->cb_dev->bus, res) {
> if (!res)
> continue;
As pointed out in the reply to Bjorn's email this hunk needs to be revisited,
since I wrote the documentation for the above call I have started understanding
the deal behind this special treatment for X86 case.
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Mickaël Salaün" <mic@digikod.net>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Randy Dunlap" <rdunlap@infradead.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Niklas Schnelle" <schnelle@linux.ibm.com>,
"Bjorn Helgaas" <helgaas@kernel.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
"Pali Rohár" <pali@kernel.org>,
"Maciej W. Rozycki" <macro@orcam.me.uk>,
"Juergen Gross" <jgross@suse.com>,
"Dominik Brodowski" <linux@dominikbrodowski.net>,
linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org
Cc: Miguel Ojeda <ojeda@kernel.org>,
Richard Henderson <richard.henderson@linaro.org>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Matt Turner <mattst88@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Gregory Clement <gregory.clement@bootlin.com>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Nicholas Piggin <npiggin@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Anatolij Gustschin <agust@denx.de>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
"David S. Miller" <davem@davemloft.net>,
Bjorn Helgaas <bhelgaas@google.com>,
Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH v8 7/7] pcmcia: Convert to use less arguments in pci_bus_for_each_resource()
Date: Wed, 5 Apr 2023 11:30:18 +0300 [thread overview]
Message-ID: <ZC0xmk71jQrx3AeH@smile.fi.intel.com> (raw)
In-Reply-To: <20230330162434.35055-8-andriy.shevchenko@linux.intel.com>
On Thu, Mar 30, 2023 at 07:24:34PM +0300, Andy Shevchenko wrote:
...
> @@ -960,12 +960,9 @@ static int nonstatic_autoadd_resources(struct pcmcia_socket *s)
> */
> if (s->cb_dev->bus->number == 0)
> return -EINVAL;
> -
> - for (i = 0; i < PCI_BRIDGE_RESOURCE_NUM; i++) {
> - res = s->cb_dev->bus->resource[i];
> -#else
> - pci_bus_for_each_resource(s->cb_dev->bus, res, i) {
> #endif
> +
> + pci_bus_for_each_resource(s->cb_dev->bus, res) {
> if (!res)
> continue;
As pointed out in the reply to Bjorn's email this hunk needs to be revisited,
since I wrote the documentation for the above call I have started understanding
the deal behind this special treatment for X86 case.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-04-05 8:30 UTC|newest]
Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 16:24 [PATCH v8 0/7] Add pci_dev_for_each_resource() helper and update users Andy Shevchenko
2023-03-30 16:24 ` Andy Shevchenko
2023-03-30 16:24 ` Andy Shevchenko
2023-03-30 16:24 ` Andy Shevchenko
2023-03-30 16:24 ` [PATCH v8 1/7] kernel.h: Split out COUNT_ARGS() and CONCATENATE() Andy Shevchenko
2023-03-30 16:24 ` Andy Shevchenko
2023-03-30 16:24 ` Andy Shevchenko
2023-03-30 16:24 ` Andy Shevchenko
2023-03-30 16:24 ` [PATCH v8 2/7] PCI: Introduce pci_resource_n() Andy Shevchenko
2023-03-30 16:24 ` Andy Shevchenko
2023-03-30 16:24 ` Andy Shevchenko
2023-03-30 16:24 ` Andy Shevchenko
2023-03-30 16:24 ` [PATCH v8 3/7] PCI: Introduce pci_dev_for_each_resource() Andy Shevchenko
2023-03-30 16:24 ` Andy Shevchenko
2023-03-30 16:24 ` Andy Shevchenko
2023-03-30 16:24 ` Andy Shevchenko
2023-03-30 16:24 ` [PATCH v8 4/7] PCI: Document pci_bus_for_each_resource() to avoid confusion Andy Shevchenko
2023-03-30 16:24 ` Andy Shevchenko
2023-03-30 16:24 ` Andy Shevchenko
2023-03-30 16:24 ` Andy Shevchenko
2023-03-30 16:24 ` [PATCH v8 5/7] PCI: Allow pci_bus_for_each_resource() to take less arguments Andy Shevchenko
2023-03-30 16:24 ` Andy Shevchenko
2023-03-30 16:24 ` Andy Shevchenko
2023-03-30 16:24 ` Andy Shevchenko
2023-04-05 11:50 ` Andy Shevchenko
2023-04-05 11:50 ` Andy Shevchenko
2023-04-05 11:50 ` Andy Shevchenko
2023-04-05 11:50 ` Andy Shevchenko
2023-04-05 20:11 ` Bjorn Helgaas
2023-04-05 20:11 ` Bjorn Helgaas
2023-04-05 20:11 ` Bjorn Helgaas
2023-04-05 20:11 ` Bjorn Helgaas
2023-03-30 16:24 ` [PATCH v8 6/7] EISA: Convert to use less arguments in pci_bus_for_each_resource() Andy Shevchenko
2023-03-30 16:24 ` Andy Shevchenko
2023-03-30 16:24 ` Andy Shevchenko
2023-03-30 16:24 ` Andy Shevchenko
2023-03-30 16:24 ` [PATCH v8 7/7] pcmcia: " Andy Shevchenko
2023-03-30 16:24 ` Andy Shevchenko
2023-03-30 16:24 ` Andy Shevchenko
2023-03-30 16:24 ` Andy Shevchenko
2023-04-05 8:30 ` Andy Shevchenko [this message]
2023-04-05 8:30 ` Andy Shevchenko
2023-04-05 8:30 ` Andy Shevchenko
2023-04-05 8:30 ` Andy Shevchenko
2023-04-04 16:11 ` [PATCH v8 0/7] Add pci_dev_for_each_resource() helper and update users Bjorn Helgaas
2023-04-04 16:11 ` Bjorn Helgaas
2023-04-04 16:11 ` Bjorn Helgaas
2023-04-04 16:11 ` Bjorn Helgaas
2023-04-05 8:28 ` Andy Shevchenko
2023-04-05 8:28 ` Andy Shevchenko
2023-04-05 8:28 ` Andy Shevchenko
2023-04-05 8:28 ` Andy Shevchenko
2023-04-05 20:18 ` Bjorn Helgaas
2023-04-05 20:18 ` Bjorn Helgaas
2023-04-05 20:18 ` Bjorn Helgaas
2023-04-05 20:18 ` Bjorn Helgaas
2023-04-06 10:31 ` Andy Shevchenko
2023-04-06 10:31 ` Andy Shevchenko
2023-04-06 10:31 ` Andy Shevchenko
2023-04-06 10:31 ` Andy Shevchenko
2023-05-09 18:21 ` Bjorn Helgaas
2023-05-09 18:21 ` Bjorn Helgaas
2023-05-09 18:21 ` Bjorn Helgaas
2023-05-12 10:56 ` Andy Shevchenko
2023-05-12 10:56 ` Andy Shevchenko
2023-05-12 10:56 ` Andy Shevchenko
2023-05-12 19:48 ` Bjorn Helgaas
2023-05-12 19:48 ` Bjorn Helgaas
2023-05-12 19:48 ` Bjorn Helgaas
2023-05-30 21:24 ` Bjorn Helgaas
2023-05-30 21:24 ` Bjorn Helgaas
2023-05-30 21:24 ` Bjorn Helgaas
2023-05-30 21:24 ` Bjorn Helgaas
2023-05-31 18:48 ` Jonas Gorski
2023-05-31 18:48 ` Jonas Gorski
2023-05-31 21:30 ` Bjorn Helgaas
2023-05-31 21:30 ` Bjorn Helgaas
2023-05-31 21:30 ` Bjorn Helgaas
2023-05-31 21:30 ` Bjorn Helgaas
2023-06-01 11:17 ` Jonas Gorski
2023-06-01 11:17 ` Jonas Gorski
2023-06-01 11:17 ` Jonas Gorski
2023-06-01 11:17 ` Jonas Gorski
2023-06-05 14:04 ` Andy Shevchenko
2023-06-05 14:04 ` Andy Shevchenko
2023-06-05 14:04 ` Andy Shevchenko
2023-06-05 14:04 ` Andy Shevchenko
2023-06-01 16:25 ` Andy Shevchenko
2023-06-01 16:25 ` Andy Shevchenko
2023-06-01 16:25 ` Andy Shevchenko
2023-06-01 16:25 ` Andy Shevchenko
2023-06-01 16:27 ` Andy Shevchenko
2023-06-01 16:27 ` Andy Shevchenko
2023-06-01 16:27 ` Andy Shevchenko
2023-06-01 16:27 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZC0xmk71jQrx3AeH@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=agust@denx.de \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=christophe.leroy@csgroup.eu \
--cc=dalias@libc.org \
--cc=davem@davemloft.net \
--cc=glaubitz@physik.fu-berlin.de \
--cc=gregory.clement@bootlin.com \
--cc=helgaas@kernel.org \
--cc=ink@jurassic.park.msu.ru \
--cc=jgross@suse.com \
--cc=kw@linux.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@dominikbrodowski.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=macro@orcam.me.uk \
--cc=mattst88@gmail.com \
--cc=mic@digikod.net \
--cc=mika.westerberg@linux.intel.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=ojeda@kernel.org \
--cc=oleksandr_tyshchenko@epam.com \
--cc=pali@kernel.org \
--cc=philmd@linaro.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rdunlap@infradead.org \
--cc=richard.henderson@linaro.org \
--cc=schnelle@linux.ibm.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=sparclinux@vger.kernel.org \
--cc=sstabellini@kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=xen-devel@lists.xenproject.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.