Re: [PATCH v1 2/6] dt-bindings: display: bridge: toshiba,tc358768: Add TC9594

From: Francesco Dolcini <francesco@dolcini.it>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
	Robert Foss <rfoss@kernel.org>,
	Francesco Dolcini <francesco@dolcini.it>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Jonas Karlman <jonas@kwiboo.se>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Peter Ujfalusi <peter.ujfalusi@ti.com>,
	devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Andrzej Hajda <andrzej.hajda@intel.com>,
	Francesco Dolcini <francesco.dolcini@toradex.com>
Subject: Re: [PATCH v1 2/6] dt-bindings: display: bridge: toshiba,tc358768: Add TC9594
Date: Fri, 31 Mar 2023 11:30:52 +0200	[thread overview]
Message-ID: <ZCaoTDjvAUZJYP3s@francesco-nb.int.toradex.com> (raw)
In-Reply-To: <ff88e5d3-4c31-7698-b8d1-8a03b9fea643@linaro.org>

On Fri, Mar 31, 2023 at 10:42:40AM +0200, Krzysztof Kozlowski wrote:
> On 30/03/2023 11:59, Francesco Dolcini wrote:
> > From: Francesco Dolcini <francesco.dolcini@toradex.com>
> > 
> > Add TC9594, from the software point of view this is identical to
> > TC358768 with the main difference being automotive qualified.
> > 
> > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> > ---
> >  .../devicetree/bindings/display/bridge/toshiba,tc358768.yaml | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml
> > index d6dac186ac59..8f22093b61ae 100644
> > --- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml
> > +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml
> > @@ -4,19 +4,20 @@
> >  $id: http://devicetree.org/schemas/display/bridge/toshiba,tc358768.yaml#
> >  $schema: http://devicetree.org/meta-schemas/core.yaml#
> >  
> > -title: Toshiba TC358768/TC358778 Parallel RGB to MIPI DSI bridge
> > +title: Toshiba TC358768/TC358778/TC9594 Parallel RGB to MIPI DSI bridge
> >  
> >  maintainers:
> >    - Peter Ujfalusi <peter.ujfalusi@ti.com>
> >  
> >  description: |
> > -  The TC358768/TC358778 is bridge device which converts RGB to DSI.
> > +  The TC358768/TC358778/TC9594 is bridge device which converts RGB to DSI.
> >  
> >  properties:
> >    compatible:
> >      enum:
> >        - toshiba,tc358768
> >        - toshiba,tc358778
> > +      - toshiba,tc9594
> 
> If it is the same, why they are not compatible?

I assume I am not understanding something very basic ...

The register description and SW functionality of all these 3 parts is
identical.

How should be the compatible described in the DT schema in this case?

> I got only three patches out of six, thus I cannot check by myself.

Here the whole series: https://lore.kernel.org/all/20230330095941.428122-1-francesco@dolcini.it/

Do you want to me to send the whole series and not just the DT binding
next time? Happy to do it, if you prefer.

Francesco