From: Zhao Liu <zhao1.liu@linux.intel.com>
To: "Thomas Hellstr�m" <thomas.hellstrom@linux.intel.com>,
"Matthew Auld" <matthew.auld@intel.com>,
"Tvrtko Ursulin" <tvrtko.ursulin@linux.intel.com>
Cc: "Ira Weiny" <ira.weiny@intel.com>,
"Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Nirmoy Das" <nirmoy.das@intel.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Chris Wilson" <chris@chris-wilson.co.uk>,
"Christian K�nig" <christian.koenig@amd.com>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
"Tvrtko Ursulin" <tvrtko.ursulin@linux.intel.com>,
"Zhenyu Wang" <zhenyu.z.wang@intel.com>,
"Zhao Liu" <zhao1.liu@intel.com>
Subject: Re: [PATCH v2 9/9] drm/i915: Use kmap_local_page() in gem/i915_gem_execbuffer.c
Date: Mon, 10 Apr 2023 17:08:45 +0800 [thread overview]
Message-ID: <ZDPSHYn02GWTSMG4@liuzhao-OptiPlex-7080> (raw)
In-Reply-To: <2177327.1BCLMh4Saa@suse>
Thanks all for your review!
On Fri, Mar 31, 2023 at 05:32:17PM +0200, Fabio M. De Francesco wrote:
> Date: Fri, 31 Mar 2023 17:32:17 +0200
> From: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
> Subject: Re: [PATCH v2 9/9] drm/i915: Use kmap_local_page() in
> gem/i915_gem_execbuffer.c
>
> On venerd? 31 marzo 2023 13:30:20 CEST Tvrtko Ursulin wrote:
> > On 31/03/2023 05:18, Ira Weiny wrote:
>
[snip]
>
> > However I am unsure if disabling pagefaulting is needed or not. Thomas,
> > Matt, being the last to touch this area, perhaps you could have a look?
> > Because I notice we have a fallback iomap path which still uses
> > io_mapping_map_atomic_wc. So if kmap_atomic to kmap_local conversion is
> > safe, does the iomap side also needs converting to
> > io_mapping_map_local_wc? Or they have separate requirements?
>
> AFAIK, the requirements for io_mapping_map_local_wc() are the same as for
> kmap_local_page(): the kernel virtual address is _only_ valid in the caller
> context, and map/unmap nesting must be done in stack-based ordering (LIFO).
>
> I think a follow up patch could safely switch to io_mapping_map_local_wc() /
> io_mapping_unmap_local_wc since the address is local to context.
>
> However, not being an expert, reading your note now I suspect that I'm missing
> something. Can I ask why you think that page-faults disabling might be
> necessary?
About the disabling of pagefault here, could you please talk more about
it? :-)
From previous discussions and commit history, I didn't find relevant
information and I lack background knowledge about it...
If we have the reason to diable pagefault, I will fix and refresh the new
version.
Thanks,
Zhao
>
> Thanks,
>
> Fabio
>
> > Regards,
> >
> > Tvrtko
>
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Zhao Liu <zhao1.liu@linux.intel.com>
To: "Thomas Hellstr�m" <thomas.hellstrom@linux.intel.com>,
"Matthew Auld" <matthew.auld@intel.com>,
"Tvrtko Ursulin" <tvrtko.ursulin@linux.intel.com>
Cc: "Tvrtko Ursulin" <tvrtko.ursulin@linux.intel.com>,
"Zhenyu Wang" <zhenyu.z.wang@intel.com>,
"Ira Weiny" <ira.weiny@intel.com>,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
"Chris Wilson" <chris@chris-wilson.co.uk>,
dri-devel@lists.freedesktop.org,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
"Christian K�nig" <christian.koenig@amd.com>,
"Zhao Liu" <zhao1.liu@intel.com>,
"Nirmoy Das" <nirmoy.das@intel.com>
Subject: Re: [PATCH v2 9/9] drm/i915: Use kmap_local_page() in gem/i915_gem_execbuffer.c
Date: Mon, 10 Apr 2023 17:08:45 +0800 [thread overview]
Message-ID: <ZDPSHYn02GWTSMG4@liuzhao-OptiPlex-7080> (raw)
In-Reply-To: <2177327.1BCLMh4Saa@suse>
Thanks all for your review!
On Fri, Mar 31, 2023 at 05:32:17PM +0200, Fabio M. De Francesco wrote:
> Date: Fri, 31 Mar 2023 17:32:17 +0200
> From: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
> Subject: Re: [PATCH v2 9/9] drm/i915: Use kmap_local_page() in
> gem/i915_gem_execbuffer.c
>
> On venerd? 31 marzo 2023 13:30:20 CEST Tvrtko Ursulin wrote:
> > On 31/03/2023 05:18, Ira Weiny wrote:
>
[snip]
>
> > However I am unsure if disabling pagefaulting is needed or not. Thomas,
> > Matt, being the last to touch this area, perhaps you could have a look?
> > Because I notice we have a fallback iomap path which still uses
> > io_mapping_map_atomic_wc. So if kmap_atomic to kmap_local conversion is
> > safe, does the iomap side also needs converting to
> > io_mapping_map_local_wc? Or they have separate requirements?
>
> AFAIK, the requirements for io_mapping_map_local_wc() are the same as for
> kmap_local_page(): the kernel virtual address is _only_ valid in the caller
> context, and map/unmap nesting must be done in stack-based ordering (LIFO).
>
> I think a follow up patch could safely switch to io_mapping_map_local_wc() /
> io_mapping_unmap_local_wc since the address is local to context.
>
> However, not being an expert, reading your note now I suspect that I'm missing
> something. Can I ask why you think that page-faults disabling might be
> necessary?
About the disabling of pagefault here, could you please talk more about
it? :-)
From previous discussions and commit history, I didn't find relevant
information and I lack background knowledge about it...
If we have the reason to diable pagefault, I will fix and refresh the new
version.
Thanks,
Zhao
>
> Thanks,
>
> Fabio
>
> > Regards,
> >
> > Tvrtko
>
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Zhao Liu <zhao1.liu@linux.intel.com>
To: "Thomas Hellstr�m" <thomas.hellstrom@linux.intel.com>,
"Matthew Auld" <matthew.auld@intel.com>,
"Tvrtko Ursulin" <tvrtko.ursulin@linux.intel.com>
Cc: "Zhenyu Wang" <zhenyu.z.wang@intel.com>,
"Ira Weiny" <ira.weiny@intel.com>,
"David Airlie" <airlied@gmail.com>,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
"Chris Wilson" <chris@chris-wilson.co.uk>,
dri-devel@lists.freedesktop.org,
"Daniel Vetter" <daniel@ffwll.ch>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
"Christian K�nig" <christian.koenig@amd.com>,
"Zhao Liu" <zhao1.liu@intel.com>,
"Nirmoy Das" <nirmoy.das@intel.com>
Subject: Re: [Intel-gfx] [PATCH v2 9/9] drm/i915: Use kmap_local_page() in gem/i915_gem_execbuffer.c
Date: Mon, 10 Apr 2023 17:08:45 +0800 [thread overview]
Message-ID: <ZDPSHYn02GWTSMG4@liuzhao-OptiPlex-7080> (raw)
In-Reply-To: <2177327.1BCLMh4Saa@suse>
Thanks all for your review!
On Fri, Mar 31, 2023 at 05:32:17PM +0200, Fabio M. De Francesco wrote:
> Date: Fri, 31 Mar 2023 17:32:17 +0200
> From: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
> Subject: Re: [PATCH v2 9/9] drm/i915: Use kmap_local_page() in
> gem/i915_gem_execbuffer.c
>
> On venerd? 31 marzo 2023 13:30:20 CEST Tvrtko Ursulin wrote:
> > On 31/03/2023 05:18, Ira Weiny wrote:
>
[snip]
>
> > However I am unsure if disabling pagefaulting is needed or not. Thomas,
> > Matt, being the last to touch this area, perhaps you could have a look?
> > Because I notice we have a fallback iomap path which still uses
> > io_mapping_map_atomic_wc. So if kmap_atomic to kmap_local conversion is
> > safe, does the iomap side also needs converting to
> > io_mapping_map_local_wc? Or they have separate requirements?
>
> AFAIK, the requirements for io_mapping_map_local_wc() are the same as for
> kmap_local_page(): the kernel virtual address is _only_ valid in the caller
> context, and map/unmap nesting must be done in stack-based ordering (LIFO).
>
> I think a follow up patch could safely switch to io_mapping_map_local_wc() /
> io_mapping_unmap_local_wc since the address is local to context.
>
> However, not being an expert, reading your note now I suspect that I'm missing
> something. Can I ask why you think that page-faults disabling might be
> necessary?
About the disabling of pagefault here, could you please talk more about
it? :-)
From previous discussions and commit history, I didn't find relevant
information and I lack background knowledge about it...
If we have the reason to diable pagefault, I will fix and refresh the new
version.
Thanks,
Zhao
>
> Thanks,
>
> Fabio
>
> > Regards,
> >
> > Tvrtko
>
>
>
next prev parent reply other threads:[~2023-04-10 9:00 UTC|newest]
Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 7:32 [PATCH v2 0/9] drm/i915: Replace kmap_atomic() with kmap_local_page() Zhao Liu
2023-03-29 7:32 ` [Intel-gfx] " Zhao Liu
2023-03-29 7:32 ` Zhao Liu
2023-03-29 7:32 ` [PATCH v2 1/9] drm/i915: Use kmap_local_page() in gem/i915_gem_object.c Zhao Liu
2023-03-29 7:32 ` [Intel-gfx] " Zhao Liu
2023-03-29 7:32 ` Zhao Liu
2023-03-30 21:56 ` Ira Weiny
2023-03-30 21:56 ` [Intel-gfx] " Ira Weiny
2023-03-30 21:56 ` Ira Weiny
2023-03-29 7:32 ` [PATCH v2 2/9] drm/i915: Use memcpy_[from/to]_page() in gem/i915_gem_pyhs.c Zhao Liu
2023-03-29 7:32 ` [Intel-gfx] " Zhao Liu
2023-03-29 7:32 ` Zhao Liu
2023-03-30 23:01 ` Ira Weiny
2023-03-30 23:01 ` [Intel-gfx] " Ira Weiny
2023-03-30 23:01 ` Ira Weiny
2023-03-29 7:32 ` [PATCH v2 3/9] drm/i915: Use kmap_local_page() in gem/i915_gem_shmem.c Zhao Liu
2023-03-29 7:32 ` [Intel-gfx] " Zhao Liu
2023-03-29 7:32 ` Zhao Liu
2023-03-29 7:32 ` [PATCH v2 4/9] drm/i915: Use kmap_local_page() in gem/selftests/huge_pages.c Zhao Liu
2023-03-29 7:32 ` [Intel-gfx] " Zhao Liu
2023-03-29 7:32 ` Zhao Liu
2023-03-31 3:04 ` Ira Weiny
2023-03-31 3:04 ` [Intel-gfx] " Ira Weiny
2023-03-31 3:04 ` Ira Weiny
2023-03-29 7:32 ` [PATCH v2 5/9] drm/i915: Use kmap_local_page() in gem/selftests/i915_gem_coherency.c Zhao Liu
2023-03-29 7:32 ` Zhao Liu
2023-03-29 7:32 ` [Intel-gfx] " Zhao Liu
2023-03-31 3:07 ` Ira Weiny
2023-03-31 3:07 ` [Intel-gfx] " Ira Weiny
2023-03-31 3:07 ` Ira Weiny
2023-03-29 7:32 ` [PATCH v2 6/9] drm/i915: Use kmap_local_page() in gem/selftests/i915_gem_context.c Zhao Liu
2023-03-29 7:32 ` Zhao Liu
2023-03-29 7:32 ` [Intel-gfx] " Zhao Liu
2023-03-31 3:33 ` Ira Weiny
2023-03-31 3:33 ` [Intel-gfx] " Ira Weiny
2023-03-31 3:33 ` Ira Weiny
2023-03-31 8:05 ` Tvrtko Ursulin
2023-03-31 8:05 ` [Intel-gfx] " Tvrtko Ursulin
2023-03-31 8:05 ` Tvrtko Ursulin
2023-03-29 7:32 ` [PATCH v2 7/9] drm/i915: Use memcpy_from_page() in gt/uc/intel_uc_fw.c Zhao Liu
2023-03-29 7:32 ` Zhao Liu
2023-03-29 7:32 ` [Intel-gfx] " Zhao Liu
2023-03-29 7:32 ` [PATCH v2 8/9] drm/i915: Use kmap_local_page() in i915_cmd_parser.c Zhao Liu
2023-03-29 7:32 ` Zhao Liu
2023-03-29 7:32 ` [Intel-gfx] " Zhao Liu
2023-03-31 3:36 ` Ira Weiny
2023-03-31 3:36 ` [Intel-gfx] " Ira Weiny
2023-03-31 3:36 ` Ira Weiny
2023-03-29 7:32 ` [PATCH v2 9/9] drm/i915: Use kmap_local_page() in gem/i915_gem_execbuffer.c Zhao Liu
2023-03-29 7:32 ` Zhao Liu
2023-03-29 7:32 ` [Intel-gfx] " Zhao Liu
2023-03-31 4:18 ` Ira Weiny
2023-03-31 4:18 ` [Intel-gfx] " Ira Weiny
2023-03-31 4:18 ` Ira Weiny
2023-03-31 11:30 ` Tvrtko Ursulin
2023-03-31 11:30 ` Tvrtko Ursulin
2023-03-31 11:30 ` [Intel-gfx] " Tvrtko Ursulin
2023-03-31 15:32 ` Fabio M. De Francesco
2023-03-31 15:32 ` [Intel-gfx] " Fabio M. De Francesco
2023-03-31 15:32 ` Fabio M. De Francesco
2023-04-10 9:08 ` Zhao Liu [this message]
2023-04-10 9:08 ` [Intel-gfx] " Zhao Liu
2023-04-10 9:08 ` Zhao Liu
2023-04-12 15:45 ` Tvrtko Ursulin
2023-04-12 15:45 ` [Intel-gfx] " Tvrtko Ursulin
2023-04-12 15:45 ` Tvrtko Ursulin
2023-04-14 10:45 ` Zhao Liu
2023-04-14 10:45 ` [Intel-gfx] " Zhao Liu
2023-04-14 10:45 ` Zhao Liu
2023-04-17 11:24 ` Tvrtko Ursulin
2023-04-17 11:24 ` Tvrtko Ursulin
2023-04-17 11:24 ` [Intel-gfx] " Tvrtko Ursulin
2023-04-17 14:53 ` Rodrigo Vivi
2023-04-17 14:53 ` [Intel-gfx] " Rodrigo Vivi
2023-04-17 14:53 ` Rodrigo Vivi
2023-10-18 16:19 ` Zhao Liu
2023-10-18 16:19 ` [Intel-gfx] " Zhao Liu
2023-10-18 16:19 ` Zhao Liu
2023-10-19 9:02 ` Tvrtko Ursulin
2023-10-19 9:02 ` [Intel-gfx] " Tvrtko Ursulin
2023-10-19 9:02 ` Tvrtko Ursulin
2023-03-29 8:17 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Replace kmap_atomic() with kmap_local_page() Patchwork
2023-03-29 8:18 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-03-29 8:37 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-03-29 16:03 ` [PATCH v2 0/9] " Fabio M. De Francesco
2023-03-29 16:03 ` Fabio M. De Francesco
2023-03-29 16:03 ` [Intel-gfx] " Fabio M. De Francesco
2023-03-30 16:00 ` Zhao Liu
2023-03-30 16:00 ` Zhao Liu
2023-03-30 16:00 ` [Intel-gfx] " Zhao Liu
2023-03-29 19:51 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZDPSHYn02GWTSMG4@liuzhao-OptiPlex-7080 \
--to=zhao1.liu@linux.intel.com \
--cc=airlied@gmail.com \
--cc=chris@chris-wilson.co.uk \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=fmdefrancesco@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ira.weiny@intel.com \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=matthew.auld@intel.com \
--cc=nirmoy.das@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=thomas.hellstrom@linux.intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
--cc=zhao1.liu@intel.com \
--cc=zhenyu.z.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.