From: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net> To: Thomas Zimmermann <tzimmermann@suse.de> Cc: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>, linux-fbdev@vger.kernel.org, "Helge Deller" <deller@gmx.de>, "Rob Clark" <robdclark@gmail.com>, "Laurent Pinchart" <laurent.pinchart@ideasonboard.com>, "Geert Uytterhoeven" <geert@linux-m68k.org>, "Jingoo Han" <jg1.han@samsung.com>, "Tomi Valkeinen" <tomi.valkeinen@ti.com>, "Daniel Vetter" <daniel.vetter@ffwll.ch>, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fbdev: Update fbdev source file paths Date: Thu, 31 Aug 2023 08:44:59 +0200 [thread overview] Message-ID: <ZPA26xdbTRdfuveS@probook> (raw) In-Reply-To: <d9a02d20-8b59-cbdd-d054-eac14f9771d2@suse.de> [-- Attachment #1: Type: text/plain, Size: 1735 bytes --] On Wed, Aug 30, 2023 at 09:10:26AM +0200, Thomas Zimmermann wrote: > Hi > > Am 29.08.23 um 22:02 schrieb Jonathan Neuschäfer: > > The files fbmem.c, fb_defio.c, fbsysfs.c, fbmon.c, modedb.c, and > > fbcmap.c were moved to drivers/video/fbdev, and subsequently to > > drivers/video/fbdev/core, in the commits listed below. > > > > Reported by kalekale in #kernel (Libera IRC). > > > > Fixes: f7018c213502 ("video: move fbdev to drivers/video/fbdev") > > Fixes: 19757fc8432a ("fbdev: move fbdev core files to separate directory") > > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net> > > IMHO these comments might just be removed. I think it's nice to have some sort of visual separation between groups of functions in fb.h, which these comments provide at the moment. Therefore I'm currently leaning towards my patch as it is, but I'm willing to have my mind changed and do a v2 which just removes the comments. Thanks > > Best regards > Thomas > > > --- > > include/linux/fb.h | 12 ++++++------ > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/include/linux/fb.h b/include/linux/fb.h > > index ce7d588edc3e6..3cda5b9f2469b 100644 > > --- a/include/linux/fb.h > > +++ b/include/linux/fb.h > > @@ -592,7 +592,7 @@ extern ssize_t fb_sys_write(struct fb_info *info, const char __user *buf, > > __FB_DEFAULT_SYS_OPS_DRAW, \ > > __FB_DEFAULT_SYS_OPS_MMAP > > > > -/* drivers/video/fbmem.c */ > > +/* drivers/video/fbdev/core/fbmem.c */ > > extern int register_framebuffer(struct fb_info *fb_info); > > extern void unregister_framebuffer(struct fb_info *fb_info); > > extern int fb_prepare_logo(struct fb_info *fb_info, int rotate); [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net> To: Thomas Zimmermann <tzimmermann@suse.de> Cc: linux-fbdev@vger.kernel.org, "Daniel Vetter" <daniel.vetter@ffwll.ch>, "Helge Deller" <deller@gmx.de>, "Jingoo Han" <jg1.han@samsung.com>, "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, "Tomi Valkeinen" <tomi.valkeinen@ti.com>, "Geert Uytterhoeven" <geert@linux-m68k.org>, "Laurent Pinchart" <laurent.pinchart@ideasonboard.com> Subject: Re: [PATCH] fbdev: Update fbdev source file paths Date: Thu, 31 Aug 2023 08:44:59 +0200 [thread overview] Message-ID: <ZPA26xdbTRdfuveS@probook> (raw) In-Reply-To: <d9a02d20-8b59-cbdd-d054-eac14f9771d2@suse.de> [-- Attachment #1: Type: text/plain, Size: 1735 bytes --] On Wed, Aug 30, 2023 at 09:10:26AM +0200, Thomas Zimmermann wrote: > Hi > > Am 29.08.23 um 22:02 schrieb Jonathan Neuschäfer: > > The files fbmem.c, fb_defio.c, fbsysfs.c, fbmon.c, modedb.c, and > > fbcmap.c were moved to drivers/video/fbdev, and subsequently to > > drivers/video/fbdev/core, in the commits listed below. > > > > Reported by kalekale in #kernel (Libera IRC). > > > > Fixes: f7018c213502 ("video: move fbdev to drivers/video/fbdev") > > Fixes: 19757fc8432a ("fbdev: move fbdev core files to separate directory") > > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net> > > IMHO these comments might just be removed. I think it's nice to have some sort of visual separation between groups of functions in fb.h, which these comments provide at the moment. Therefore I'm currently leaning towards my patch as it is, but I'm willing to have my mind changed and do a v2 which just removes the comments. Thanks > > Best regards > Thomas > > > --- > > include/linux/fb.h | 12 ++++++------ > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/include/linux/fb.h b/include/linux/fb.h > > index ce7d588edc3e6..3cda5b9f2469b 100644 > > --- a/include/linux/fb.h > > +++ b/include/linux/fb.h > > @@ -592,7 +592,7 @@ extern ssize_t fb_sys_write(struct fb_info *info, const char __user *buf, > > __FB_DEFAULT_SYS_OPS_DRAW, \ > > __FB_DEFAULT_SYS_OPS_MMAP > > > > -/* drivers/video/fbmem.c */ > > +/* drivers/video/fbdev/core/fbmem.c */ > > extern int register_framebuffer(struct fb_info *fb_info); > > extern void unregister_framebuffer(struct fb_info *fb_info); > > extern int fb_prepare_logo(struct fb_info *fb_info, int rotate); [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-08-31 6:45 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-08-29 20:02 [PATCH] fbdev: Update fbdev source file paths Jonathan Neuschäfer 2023-08-29 20:02 ` Jonathan Neuschäfer 2023-08-30 7:10 ` Thomas Zimmermann 2023-08-30 7:10 ` Thomas Zimmermann 2023-08-31 6:44 ` Jonathan Neuschäfer [this message] 2023-08-31 6:44 ` Jonathan Neuschäfer 2023-08-31 8:51 ` Daniel Vetter 2023-08-31 8:51 ` Daniel Vetter 2023-08-31 9:02 ` Helge Deller 2023-08-31 21:49 ` Helge Deller 2023-09-01 17:19 ` Jonathan Neuschäfer 2023-09-01 17:19 ` Jonathan Neuschäfer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ZPA26xdbTRdfuveS@probook \ --to=j.neuschaefer@gmx.net \ --cc=daniel.vetter@ffwll.ch \ --cc=deller@gmx.de \ --cc=dri-devel@lists.freedesktop.org \ --cc=geert@linux-m68k.org \ --cc=jg1.han@samsung.com \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=robdclark@gmail.com \ --cc=tomi.valkeinen@ti.com \ --cc=tzimmermann@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.